Skip to content

fix(ci): fix DockerHub semver tagging and coordinate MCP Registry publish - #139

Merged
hapheus merged 2 commits into
mainfrom
fix/dockerhub-mcp-publish-coordination
Nov 10, 2026
Merged

hapheus merged 2 commits into
mainfrom
fix/dockerhub-mcp-publish-coordination

Conversation

@hapheus

@hapheus hapheus commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes DockerHub semver tagging and synchronizes the MCP Registry publication workflow with Docker Hub image availability.

Key Changes

  • DockerHub Tagging: Added type=semver,pattern={{version}} to .github/workflows/publish-dockerhub.yml so release tags publish both vX.Y.Z and X.Y.Z (e.g. docker.io/hapheus/torproxy:2.7.3).
  • MCP Publish Synchronization: Added a polling loop in .github/workflows/publish-mcp.yml to wait for the OCI image to become available on Docker Hub before attempting to publish server.json to the MCP Registry.
  • Version Bump: Bumped version to 2.7.3 across all synchronized single-source-of-truth files (pyproject.toml, docker/Dockerfile, server.json, uv.lock, CHANGELOG.md, and docs/releases.md).

Closes #138

@MustermenschAlex MustermenschAlex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent fix. Synchronizing the DockerHub semver tag pattern with server.json's OCI identifier and inserting a deterministic bounded wait loop in publish-mcp.yml eliminates the publish race condition completely while preserving contract integrity across all files. Approved.

@kuenstlichedummheit-sys kuenstlichedummheit-sys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the race condition between the workflows. Polling docker manifest inspect with a 450s total ceiling prevents the registry from complaining about missing OCI blobs. Clean and fail-safe.

majorungustl
majorungustl previously approved these changes Nov 10, 2026

@majorungustl majorungustl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and pragmatic fix. Tagging the bare semver tag on DockerHub fixes the mismatch, and checking before pushing saves unnecessary 400s. LGTM, ship it!

@MustermenschAlex MustermenschAlex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved after adding changelog comparison link. Excellent.

@kuenstlichedummheit-sys kuenstlichedummheit-sys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog link looks crisp. Re-approved.

@majorungustl majorungustl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved for 0bd0db0. Good to go!

@hapheus
hapheus merged commit 2cf672c into main Nov 10, 2026
12 checks passed
@hapheus
hapheus deleted the fix/dockerhub-mcp-publish-coordination branch November 10, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): fix DockerHub semver tagging and coordinate MCP Registry publish

4 participants