Repository navigation
fix(ci): fix DockerHub semver tagging and coordinate MCP Registry publish - #139
Conversation
MustermenschAlex
left a comment
There was a problem hiding this comment.
Excellent fix. Synchronizing the DockerHub semver tag pattern with server.json's OCI identifier and inserting a deterministic bounded wait loop in publish-mcp.yml eliminates the publish race condition completely while preserving contract integrity across all files. Approved.
kuenstlichedummheit-sys
left a comment
There was a problem hiding this comment.
Nice catch on the race condition between the workflows. Polling docker manifest inspect with a 450s total ceiling prevents the registry from complaining about missing OCI blobs. Clean and fail-safe.
majorungustl
left a comment
There was a problem hiding this comment.
Straightforward and pragmatic fix. Tagging the bare semver tag on DockerHub fixes the mismatch, and checking before pushing saves unnecessary 400s. LGTM, ship it!
0bd0db0
MustermenschAlex
left a comment
There was a problem hiding this comment.
Re-approved after adding changelog comparison link. Excellent.
kuenstlichedummheit-sys
left a comment
There was a problem hiding this comment.
Changelog link looks crisp. Re-approved.
majorungustl
left a comment
There was a problem hiding this comment.
Re-approved for 0bd0db0. Good to go!
Summary
Fixes DockerHub semver tagging and synchronizes the MCP Registry publication workflow with Docker Hub image availability.
Key Changes
type=semver,pattern={{version}}to.github/workflows/publish-dockerhub.ymlso release tags publish bothvX.Y.ZandX.Y.Z(e.g.docker.io/hapheus/torproxy:2.7.3)..github/workflows/publish-mcp.ymlto wait for the OCI image to become available on Docker Hub before attempting to publishserver.jsonto the MCP Registry.2.7.3across all synchronized single-source-of-truth files (pyproject.toml,docker/Dockerfile,server.json,uv.lock,CHANGELOG.md, anddocs/releases.md).Closes #138