chore(pin): complete the .18 pin — overlay re-extracted, contract fixtures re-recorded (#636) - #637
Merged
Merged
Conversation
…tures re-recorded (#636) #634 moved the vendored-binary lock to v1.18.10-amicode.18 but left the two dependent artifact families behind: the app-bundle overlay/manifest still pinned .16 (with #620's hand-carried titlebar files, unreachable- green by the drift gate's design) and the service-contract golden fixtures still recorded .17 (the failing assertion's own remedy). The sweep: extractor at .18 (554 files, round-trip byte-identical, drift gate FULL PASS with re-derivation), fixtures re-recorded from the .18 fork binary (71 entries), and the six extension tests that pinned the .16 overlay API updated to the fork's deliberate .18 changes (vaultNodeLocked → opts.vaultLocked callback; effectiveMount inlined; #323's dblclick-close superseded by dblclick-rename + middle-click-close). Closes #623. Unblocks #622 and main.
aarontrowbridge
marked this pull request as ready for review
August 29, 2026 13:08
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #636. Closes #623. Unblocks #622 and main.
What
mainhas been red since #620 because the.18pin (#634) moved only the vendored-binary lock — its two dependent artifact families never followed. This completes the sweep mechanically:v1.18.10-amicode.18— 554 files, round-trip byte-identical to the fork tag;drift_gate.mjsfull PASS with re-derivation (fresh extraction == committed manifest). Carries the fork's own merged.16→.18delta (89 files, +2705/−1328): the chat-ui polish, the tab-UX rework, the vault-model refactor..18binary (asset-sha-verified via the sanctioned fetch path) — 71 entries; the self-tracking pin assertion passes..16overlay API (scope amendment on Complete the .18 pin: re-extract the app-bundle overlay + re-record the service-contract fixtures (unblocks #622 and main) #636 with the full reasoning): four retired with pointers (vaultNodeLocked→ the fork's injectedopts.vaultLockedcallback;effectiveMount→ inlined invault-browser.tsx), the titlebar regression rewritten to the fork's.18contract (dblclick renames, middle-click closes — BUG: Double-clicking a session tab does not close it #323's interaction superseded by the fork's own design).Evidence
drift_gate.mjsexit 0 WITH the fork present (the strongest check).terminal×2 +pasqal_python×1 fail identically on pristine main on this dev box (python-venv + HOME environment flakes; pass on CI) — not part of this diff.Director-drafted in the harness-agnostic campaign (worktree off main; the shared checkout untouched).