Repository navigation
build: go 1.26.10 for GO-2026-6809 - #61
Merged
Merged
Conversation
govulncheck, which CI runs as a failing check, reports GO-2026-6809 (crypto/x509 trusting compromised intermediates) on go1.26.9, reached through every HTTPS call this CLI makes. It is fixed in go1.26.10. The same finding is on main today, so without this the vulnerability job fails here and on the next push to main, and tag.yml publishes nothing from a commit whose CI did not pass. Only the go directive moves; no dependency changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises the
godirective from 1.26.9 to 1.26.10 to fix GO-2026-6809 (crypto/x509 trusting compromised intermediate certificates). Every HTTPS call this CLI makes can reach the affected code. The README and CONTRIBUTING lines that state the minimum Go version are updated to match. No dependency changes:go.sumis untouched.Why now
The
Known vulnerabilitiesjob (govulncheck@v1.8.0) is a failing check, and today it fails onmain. Every push tomaintherefore leaves CI red.tag.ymlonly runs after CI passes onmain, so nothing can be released until this is fixed.govulncheck on
main(b3aea03):govulncheck on this branch:
Release
This PR does not publish a release.
internal/tui.Versionstays at 0.1.34, and thev0.1.34tag already exists, so after CI passes onmain,tag.ymlreports that the tag is already published and stops. The fixed toolchain ships with the next version bump.The user merges this PR.
Checks
Reproduced locally from
.github/workflows/ci.ymlwith go1.26.10, fetched byGOTOOLCHAIN=auto:gofmt -l .is cleango mod verifypassesgo vet ./...passesgo test -race -shuffle=on ./...passesgovulncheck@v1.8.0finds no vulnerabilities#60 carries the same commit so that its CI stays green; a rebase drops it once this is merged.
🤖 Generated with Claude Code