Repository navigation
Fix low findings from the Fable review of the 47f2c8d29e sync - #305
Merged
Merged
Conversation
- knip: ignore runtimeInstructions.ts exports; its only consumer (Antigravity) is cut - Mark the codexThreadRuntimeParams export as a Coder seam and list it in the seams doc - PullRequestStackMenu: take upstream's text, since GitLab never reaches native stacks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #304. Two Fable 5.1 reviewers (server/packages; web/client-runtime/docs) found no high or medium issues. This fixes the three low ones:
pnpm knip:checkfailed:PULL_REQUEST_LINKING_INSTRUCTIONSinruntimeInstructions.tslost its only consumer when Antigravity was cut. Added the file to knip'signoreIssuesso it stays upstream's.codexThreadRuntimeParamsis exported (upstream keeps it private) for the fork'sCodexAdapterV2.test.ts. Marked withCoder:and listed in the seams doc.PullRequestStackMenu.tsxmixed#Nand!N. The seams doc keeps native-stack text upstream's (GitLab never produces native stacks), so the file is now upstream's verbatim.Also: live check of #275 on coder-only 7990df0 passed with two linked workspaces (Open approval and the task title both open B's child with the approval card; approving continues it).
Verification:
pnpm knip:check, seams-check,vp fmt --checkon changed files,typecheck:server,typecheck:web,CodexAdapterV2.test.ts(133),PullRequestStackMenu.browser.test.tsx(2).🤖 Generated with Claude Code