Repository navigation
Fix Fable review findings from the ade473018d sync - #310
Merged
Merged
Conversation
Fable review of the ade4730 sync (PR #309) found pingdotgg#30623/pingdotgg#30624 non-voice changes reverted together with the dictation hooks: - ComposerPrimaryActions: the pending-answer button honours isSendDisabled again. - ui/textarea.tsx and useLocalStorage.ts are upstream's (rows sizing, storage.clear() notifies subscribers). - shared keybindingMatching.ts carried and keybindings.ts back to upstream's re-export form minus the composer.dictation binding. The seams doc now lists every file the voice revert touched and the client-side providerCatalogsOnDemand omission (pingdotgg#28487). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the Fable 5.1 review of the ade4730 sync (#309). Two reviewers found no high-severity issues, one medium and several lows, all caused by the per-file voice revert also dropping non-voice upstream hunks.
isSendDisabled(rewinding, messages loading, preparing worktree…). Restored as upstream.ui/textarea.tsx: upstream'srowsminimum-height sizing is back (PR forms and settings textareas).useLocalStorage.ts: another tab'sstorage.clear()notifies subscribers again.keybindingMatching.tsis carried (feat(desktop): dictate into browser annotations with the same consent pingdotgg/t3code#30624), andkeybindings.tsis upstream's re-export form minus thecomposer.dictationbinding. This removes a 113-line delta. No package export, because only the desktop app imports it.coder-only.md: the voice cut entry now lists every file it touched, and the client-sideproviderCatalogsOnDemandomission (perf(mobile): faster thread sync, connects, and reconnects on bad wifi pingdotgg/t3code#28487) is recorded as a seam.Left as is:
ChatView.tsx's constantfeedbackUploadingstub, which predates this sync. It keeps upstream's lines intact for the Codex feedback cut.Verification:
fmt --checkon the changed files; shared, web, server and helper typechecks;knip:check;seams-check;sync-check --only unused-locals;test:shared:coder;test:web:coder(4029 unit, 569 browser);pnpm build.🤖 Generated with Claude Code