Repository navigation
fix: install curl for the Vector download and purge it after - #135
Merged
Merged
Conversation
The production base image carries no curl since scalo 2.14.22, so the Vector download layer failed with "curl: not found" and #134's release run published nothing. The layer now installs curl, downloads and checks the archive, and purges curl in the same RUN, so the shipped image still has no HTTP client.
|
Released in v1.0.57 -- https://github.com/hyperi-io/dfe-transform-vector/releases/tag/v1.0.57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#134's release run (40898663085) built both binaries and then failed the Container job: the Vector download layer runs
curl, and the production base image carries no curl since scalo 2.14.22 (/bin/sh: 1: curl: not found). Nothing was tagged or published.src/vector-layer.dockerfileinstalls curl, downloads and checksums the Vector archive, then purges curl in the same RUN, so the shipped image still has no HTTP client.Proved locally:
docker buildof the regenerated Dockerfile (stub app binary, amd64) succeeds, and in the imagecurlis absent,vector --versionprints 0.60.0, the licence files are in /usr/share/doc/vector, bash is present for the health check, and the user is 1000. The image was removed after. hadolint is clean and the deployment integration tests pass.Merging with the release trailer cuts the release #134 should have.