Repository navigation
Add configurable ingress TLS modes - #77
jsturtevant wants to merge 7 commits into
Conversation
d57f54a to
ee4db8e
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical TLS bugs can delete customer-managed Secrets during uninstall, break installations using non-default HTTPS ports or Azure ACME, and reuse expiring ACME certificates after switching to self-signed mode.
6 open issues
Enable ambient credentials for Azure DNS-01 issuance · New Use the configured HTTPS port for endpoint probes · New Require selfSigned mode before reusing a TLS Secret · New Reject knative-eventing for existing TLS Secrets · New Retry the first cert-manager webhook-admitted resource · New Enforce cancellation and deadlines in TLS and DNS probes · New
What changed in this PR
Adds configurable TLS to Lampyr’s shared ingress installation, preparing for production AKS integration under #76 while keeping self-signed certificates as the default.
Changes:
- Adds validated ACME, existing-Secret, and stable ingress IP settings.
- Integrates certificate configuration, ownership checks, and mode-transition cleanup.
- Adds DNS, certificate, and HTTPS readiness checks, persisted health metadata, and validation tests.
| File | Description |
|---|---|
cli/src/platform_host.rs |
Defines and validates ingress settings, forwards them to bootstrap, and adds configuration tests. |
cli/src/bootstrap.rs |
Implements TLS modes, cert-manager identity setup, cleanup, readiness checks, and certificate validation tests. |
Review effort: Balanced
ee4db8e to
8d0a9cb
Compare
There was a problem hiding this comment.
🟡 Changes recommended
External TLS Secrets are accepted in the Lampyr-owned knative-eventing namespace, where uninstall can delete them, violating the customer-managed Secret ownership guarantee.
8 open issues
Reject knative-eventing for existing TLS Secrets Require selfSigned mode before reusing a TLS Secret Use the configured HTTPS port for endpoint probes Enable ambient credentials for Azure DNS-01 issuance Validate external certificates cover both requested wildcards · New Pass ingress settings through provider-backed installs · New Enforce cancellation and deadlines in TLS and DNS probes Retry the first cert-manager webhook-admitted resource
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Enabling ambient credentials for namespaced Issuers lets namespace editors and admins use the ingress DNS identity to obtain certificates for names anywhere in its authorized DNS zone.
3 open issues
8 resolved since last review
Reject knative-eventing for existing TLS Secrets Require selfSigned mode before reusing a TLS Secret Use the configured HTTPS port for endpoint probes Enable ambient credentials for Azure DNS-01 issuance Pass ingress settings through provider-backed installs Validate external certificates cover both requested wildcards Enforce cancellation and deadlines in TLS and DNS probes Retry the first cert-manager webhook-admitted resource
Review effort: Balanced
fec5239 to
cdb9876
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The policy omits Azure DNS Challenges, and teardown can remove the boundary before credential-bearing Pods terminate, leaving paths for unauthorized use of Lampyr’s Azure DNS identity.
2 open issues
3 resolved since last review
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
The policy uses the wrong API group for Challenges, so the dry-run probe is not denied and the issuer-boundary check times out, blocking every ACME installation from enabling its identity.
1 open issue
2 resolved since last review
Review effort: Balanced
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
e29ab48 to
d4bc05c
Compare
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Unresolved flaws discard retiring credentials before reconciliation succeeds, allow provider metadata to overwrite authoritative ingress state, and let TLS probes accept certificates that application clients reject.
4 open issues
Review effort: Balanced
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
Supplied configuration can bypass approval or differ from the changes shown on providerless installs and reinstalls, while ingress replacement drops generated ACME fields and causes validation failures.
2 open issues
4 resolved since last review
Review effort: Balanced
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
Credential approval omits installed and retiring state, allowing cleanup mutations to bypass approval and remain absent from persisted plans, while the new helper ignores installed credentials and deterministically fails its test.
2 open issues
Review effort: Balanced
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>


AKS production ingress needs platform TLS support before provider resources can be connected. This keeps self-signed certificates as the default and adds cert-manager ACME and external Secret modes with certificate and endpoint readiness checks.
Part of #76.