Skip to content

Add configurable ingress TLS modes - #77

Open
jsturtevant wants to merge 7 commits into
mainfrom
feat/issue-76-ingress-tls
Open

jsturtevant wants to merge 7 commits into
mainfrom
feat/issue-76-ingress-tls

Conversation

@jsturtevant

Copy link
Copy Markdown
Collaborator

AKS production ingress needs platform TLS support before provider resources can be connected. This keeps self-signed certificates as the default and adds cert-manager ACME and external Secret modes with certificate and endpoint readiness checks.

Part of #76.

Copilot AI balanced review requested due to automatic review settings November 20, 2026 19:44
@jsturtevant
jsturtevant added this pull request to stack #80 November 20, 2026 19:44
@jsturtevant
jsturtevant force-pushed the feat/issue-76-ingress-tls branch from d57f54a to ee4db8e Compare November 20, 2026 19:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved critical TLS bugs can delete customer-managed Secrets during uninstall, break installations using non-default HTTPS ports or Azure ACME, and reuse expiring ACME certificates after switching to self-signed mode.

6 open issues
What changed in this PR

Adds configurable TLS to Lampyr’s shared ingress installation, preparing for production AKS integration under #76 while keeping self-signed certificates as the default.

Changes:

  • Adds validated ACME, existing-Secret, and stable ingress IP settings.
  • Integrates certificate configuration, ownership checks, and mode-transition cleanup.
  • Adds DNS, certificate, and HTTPS readiness checks, persisted health metadata, and validation tests.
File Description
cli/​src/​platform_host.rs Defines and validates ingress settings, forwards them to bootstrap, and adds configuration tests.
cli/​src/​bootstrap.rs Implements TLS modes, cert-manager identity setup, cleanup, readiness checks, and certificate validation tests.

Review effort: Balanced

Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/platform_host.rs Resolved
Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/bootstrap.rs Resolved
Copilot AI balanced review requested due to automatic review settings November 20, 2026 19:51
@jsturtevant
jsturtevant force-pushed the feat/issue-76-ingress-tls branch from ee4db8e to 8d0a9cb Compare November 20, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/platform_host.rs Resolved
Copilot AI balanced review requested due to automatic review settings November 20, 2026 23:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/platform_host.rs Resolved
Copilot AI balanced review requested due to automatic review settings November 20, 2026 23:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the configurable ingress TLS changes.

3 open issues

Review effort: Balanced

@jsturtevant
jsturtevant force-pushed the feat/issue-76-ingress-tls branch from fec5239 to cdb9876 Compare November 20, 2026 23:58
Copilot AI balanced review requested due to automatic review settings November 20, 2026 23:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The policy omits Azure DNS Challenges, and teardown can remove the boundary before credential-bearing Pods terminate, leaving paths for unauthorized use of Lampyr’s Azure DNS identity.

2 open issues
3 resolved since last review

Review effort: Balanced

Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/bootstrap.rs Resolved
Copilot AI balanced review requested due to automatic review settings November 21, 2026 00:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The policy uses the wrong API group for Challenges, so the dry-run probe is not denied and the issuer-boundary check times out, blocking every ACME installation from enabling its identity.

1 open issue
2 resolved since last review

Review effort: Balanced

Comment thread cli/src/bootstrap.rs Resolved
Copilot AI balanced review requested due to automatic review settings November 21, 2026 00:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The policy omits the Challenge API group, leaving Challenges unprotected and causing the readiness probe to time out before identity configuration on otherwise-valid ACME installations.

1 open issue

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 21, 2026 00:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed to evaluate a critical DNS credential-boundary bypass alongside TLS-trust and installation-startup concerns.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@jsturtevant
jsturtevant force-pushed the feat/issue-76-ingress-tls branch from e29ab48 to d4bc05c Compare November 21, 2026 00:58
Copilot AI balanced review requested due to automatic review settings November 21, 2026 00:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Provider-supplied admission policies bypass capability enforcement and manifest approval, allowing cluster-wide changes without declaring the required capability or obtaining approval.

4 open issues

Review effort: Balanced

Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/bootstrap.rs Resolved
Comment thread cli/src/platform_host.rs Resolved
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 01:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Unresolved flaws discard retiring credentials before reconciliation succeeds, allow provider metadata to overwrite authoritative ingress state, and let TLS probes accept certificates that application clients reject.

4 open issues

Review effort: Balanced

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 01:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Supplied configuration can bypass approval or differ from the changes shown on providerless installs and reinstalls, while ingress replacement drops generated ACME fields and causes validation failures.

2 open issues
4 resolved since last review

Review effort: Balanced

Comment thread cli/src/cluster.rs Resolved
Comment thread cli/src/cluster.rs Resolved
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 02:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because unpublished critical findings indicate lost ACME runtime fields and approval plans that can diverge from the configuration actually executed.

2 open issues

Review effort: Balanced

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 02:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

TLS credential transitions can bypass approval while deleting admission policies, and rotation approval descriptions omit cleanup of current and retiring credentials.

1 open issue
2 resolved since last review

Review effort: Balanced

Comment thread cli/src/cluster.rs Resolved
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 02:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Credential approval omits installed and retiring state, allowing cleanup mutations to bypass approval and remain absent from persisted plans, while the new helper ignores installed credentials and deterministically fails its test.

2 open issues

Review effort: Balanced

Comment thread cli/src/cluster.rs Resolved
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 21, 2026 02:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed to weigh unpublished concerns about stale annotation ownership after failed issuance and incomplete DNS readiness coverage.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants