Repository navigation
fix(frontend): give Vite a manualChunks function so the build works on Vite 6 and 8 - #343
Merged
Merged
Conversation
…n Vite 6 and 8 Vite 8 builds with Rolldown, which rejects the object form of build.rollupOptions.output.manualChunks (TypeError: manualChunks is not a function). The function form keeps the same plotly chunk on both. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZkJwTENF5faco36Cn5
|
hyperpolymath
marked this pull request as ready for review
November 14, 2026 16:01
hyperpolymath
enabled auto-merge (squash)
November 14, 2026 16:01
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
3 of 4 tasks
hyperpolymath
added a commit
that referenced
this pull request
Nov 17, 2026
… on React 18 and 19 types (#344) ## Change and reason Dependabot's React bump (#332, react 18.3.1 to 19.3.1, @types/react 19.3.0) fails `tsc && vite build` with: ``` src/views/TreeView.tsx(186,21): error TS2554: Expected 1 arguments, but got 0. src/views/TreeView.tsx(231,23): error TS2554: Expected 1 arguments, but got 0. ``` React 19's types make the `useRef` argument required. `useRef<number>()` in `TreeView.tsx` (two places: `saveTimer`, `scrollTimer`) becomes `useRef<number | undefined>(undefined)`, which typechecks on React 18 and 19 types and behaves the same at runtime. A search of `frontend/src` found no other argument-less `useRef`/`createRef`. Same forward-compatible preparation as #342 and #343. ## Validation Bun 1.4.4, `bun install --frozen-lockfile --ignore-scripts`, in `frontend/`: - Baseline (unchanged tree, React 18): `bun run build` passes, `bun run typecheck` passes, `bun test src` 90 pass / 0 fail. - After the change (React 18): build passes (`built in 34.45s`), typecheck passes, 90 pass / 0 fail. - React 19 in a scratch copy outside the repo (react and react-dom 19.3.1, @types/react 19.3.0, @types/react-dom 19.3.0), nothing committed: - Unfixed source (negative control): `tsc` reproduces exactly the two TS2554 errors above; tests 90 pass / 0 fail. - Fixed source: `bun run build` passes (`built in 20.22s`), tests 90 pass / 0 fail. Not run: Julia and R jobs (this change touches one frontend file); CI on this PR covers them. `scripts/lint-sonar-reliability.sh` and SonarCloud were not run locally. ## Scope One file, two lines. No `package.json` or lockfile change; the React bump itself stays in #332. ## Contribution checks - [x] I followed [CONTRIBUTING.md](../CONTRIBUTING.md). - [x] This branch starts at current main (6bb2ad2) and contains no merges from fork main. - [ ] CI has run and passes. - [x] Existing licensing, citation and acknowledgement text is unchanged. --- _Generated by [Claude Code](https://claude.ai/code/session_01J4QvDiW8qD4f2JDQJ4buGo)_ ## CI/gate The account ruleset "Branch-Floor" requires a status check named exactly `CI/gate`; this repository never emitted it. Commit 6ca65cc adds one job to `.github/workflows/ci.yml`: id `ci-status`, `name: CI/gate`, `needs` all seven other jobs (denominator 7), `if: always()`, `permissions: {}`, pure `run:` shell (no `uses:`, nothing new to pin). No trigger, path filter, existing job or check name was changed. The branch still starts at the tip of origin/main (6bb2ad2) with no merge commits; no rebase was needed. Rules, from the `if:` conditions in the file: - `gate` and `occupancy_gate` (detectors) must be `success`. - `test`, `standards`, `agda` are governed by `gate`: `success` when `gate` succeeded with `relevant == 'true'`, `skipped` only when `gate` succeeded with `relevant == 'false'`. - `occupancy`, `disagreement` are governed by `occupancy_gate` in the same way. - A skip while the detector failed, was cancelled, was skipped, or gave no usable output fails the gate. `failure`, `cancelled`, empty or unknown results exit 1. - A table of job, result, expected, verdict goes to the log and `$GITHUB_STEP_SUMMARY`. Local evidence (decision script extracted from the YAML, run with `NEEDS_JSON` set by hand; `jq`): - all success, both detectors relevant: exit 0 - agda failure: exit 1 - test cancelled: exit 1 - designed skip (both detectors success, relevant false, five jobs skipped): exit 0 - skips with `gate` failed: exit 1 - skips with `gate` skipped: exit 1 - detector says relevant but job skipped: exit 1 - unknown result `weird`: exit 1 - empty `needs`: exit 1 YAML parsed with Bun's YAML parser: the new job's name, needs and the unchanged `on:` block were read back correctly. NOT RUN: the repository's Julia test `test/unit/test_install_pins.jl` (no Julia here; by reading it, `CI/gate` has no `${{` and no matrix, so it should hold), `actionlint` (not installed). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **CI** * Added a required status check that verifies relevance gates and governed job results, and reports a summary of the outcomes. * **Refactor** * No user-visible behavior changes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Change and reason
Dependabot's Vite 8.3.7 bump (#335) fails the frontend build in the Julia tests job:
TypeError: manualChunks is not a function. Vite 8 builds with Rolldown, which rejects the object form ofbuild.rollupOptions.output.manualChunksthatfrontend/vite.config.tsused. The failure is real, not a CI fault. The config now uses the function form, which Rollup (Vite 6) and Rolldown (Vite 8) both accept, and it produces the sameplotlychunk.Validation
tscpasses, then the build fails at the config).bun run buildpasses on the current Vite 6.4.5 and on Vite 8.3.7 in a scratch copy; both emit aplotly-*.jschunk.@vitejs/plugin-react4.x is not addressed here; chore(deps-dev): bump @vitejs/plugin-react from 4.7.0 to 6.3.0 in /frontend #333 is the plugin bump.Scope
One file, no lockfile change, no runtime change. The other Dependabot bumps (#332, #333, #334, #336) are separate; #336 is fixed by #342.
Contribution checks
Generated by Claude Code