Skip to content

build(frontend): upgrade Vite 8, React 19, react-router 7 and TypeScript 7 together - #347

Merged
hyperpolymath merged 2 commits into
mainfrom
claude/focused-meitner-uf53td
Nov 17, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
claude/focused-meitner-uf53td

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Change and reason

One change: the pending frontend upgrades applied together, replacing five stale Dependabot PRs whose branches keep failing the branch-freshness rule. Supersedes Dependabot PRs 332, 333, 334, 335 and 336 (they are not closed by this PR).

Package Before After
vite ^6.4.5 ^8.3.7 (locked 8.3.7)
@vitejs/plugin-react ^4.3.4 ^6.3.0
typescript ^5.7.2 ^7.0.2
react-router-dom ^6.30.6 ^7.18.5
react ^18.3.1 ^19.3.1
react-dom ^18.3.1 ^19.3.1 (Dependabot's react PR left it on 18, a runtime mismatch)
@types/react ^18.3.18 ^19.3.0
@types/react-dom ^18.3.5 ^19.3.0

Source changes: none were needed. frontend/vite.config.ts already used the function form of manualChunks and useRef already passes an explicit initial value (#344). Only frontend/package.json and frontend/bun.lock change. The lockfile change is needed because these are dependency upgrades; it was regenerated with Bun 1.4.4. No test or config pins the old frontend versions (grepped test/, config/, scripts/, .github/).

Validation

Bun 1.4.4, run in frontend/ from a clean node_modules with bun install --frozen-lockfile --ignore-scripts.

Check Baseline (main) After
build (tsc && vite build) pass pass (Vite 8.3.7, 354 modules)
typecheck pass pass (TypeScript 7.0.2)
unit tests (bun test src) 90 pass, 0 fail 90 pass, 0 fail
scripts/lint-sonar-reliability.sh not run OK, no S2871 or S7758 findings

Runtime smoke test (headless Chromium via Playwright, built dist served with SPA fallback, API requests answered 503): 15 routes visited by URL and 4 reached by clicking links.

Baseline After
page errors 0 0
console errors (non-API) 0 0
routes with non-empty rendered content 15 of 15 15 of 15, same final paths and same text length on every route
click navigation (/studies, /jobs, /databases, /config) same same
expected API failures (503) 191 194 (polling timing jitter; all to /api or /files)

NOT RUN: the Julia and R test suites locally, and check-pr-freshness.sh (the clone is shallow and the script refuses: "shallow clone; check out with fetch-depth: 0"). By hand, the merge base of HEAD and origin/main equals origin/main (e4e39aa), and the branch has one commit and no merge commits.

Scope

Left out: any source refactor, .github/dependabot.yml, and CONTRIBUTING.md. Its "Settled decisions" section still says "React 18"; the owner decides whether to update it.

Contribution checks

  • I followed CONTRIBUTING.md.
  • This branch starts at current upstream main and contains no merges from fork main (checked by hand; the script could not run on the shallow clone).
  • CI has run and passes (pending).
  • Existing licensing, citation and acknowledgement text is unchanged.

Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Frontend guidance now reflects React 19 while retaining the documented choices for TypeScript, Vite, bun, and the frontend project location.
  • User-Facing Changes
    • No changes to app features or behavior are described in this update.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 02:11
@linear-code
linear-code Bot marked this pull request as ready for review November 17, 2026 02:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The documented frontend decision now specifies React 19. The frontend package manifest updates React, React Router DOM, TypeScript, Vite, and related package versions.

Changes: Frontend toolchain

Layer / File(s) Summary
Document and update frontend versions
CONTRIBUTING.md, frontend/package.json
The documented frontend decision changes from React 18 to React 19. The package manifest updates React and React DOM to 19.3.1, React Router DOM to 7.18.5, React type packages to 19.3.0, the Vite React plugin to 6.3.0, TypeScript to 7.0.2, and Vite to 8.3.7.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

Suggested reviewers: joshuajewell

Merge Risk: Minimal · up to 52b16

The PR upgrades the frontend toolchain to React 19, Vite 8, TypeScript 7 and React Router 7, and updates the settled-decisions text in CONTRIBUTING.md to match. No concrete defect was found. CI is still pending, so confirm that the pinned-version install and build succeed before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: upgrading the frontend stack (Vite 8, React 19, react-router 7, TypeScript 7) together. The PR objectives and the package.json summary confirm this. The title is speci…
Description check Passed The description follows the template. It has a Change and reason section that explains the single change and what it supersedes. It has a Validation section that lists the Bun version, the commands ru…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: upgrading the frontend stack (Vite 8, React 19, react-router 7, TypeScript 7) together. The PR objectives and the package.json summary confirm this. The title is specific and accurate, and it is a single line of reasonable length. The 83-character length is slightly long but acceptable.

Full details: Description check

Explanation

The description follows the template. It has a Change and reason section that explains the single change and what it supersedes. It has a Validation section that lists the Bun version, the commands run, baseline and after results, and what was not run. It has a Scope section that names what was left out and explains the lockfile change. All four contribution checks appear. The CI box is unchecked because CI is pending, which the author states. The description is thorough and specific.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 5601416 and 52b16b1.

Files ignored due to path filters: 1

  • frontend/bun.lock is excluded by !**/*.lock
Files selected for processing: 2

  • CONTRIBUTING.md
  • frontend/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

…ipt 7 together

Replaces Dependabot PRs 332-336 with one tested change.

- vite ^6.4.5 -> ^8.3.7
- @vitejs/plugin-react ^4.3.4 -> ^6.3.0
- typescript ^5.7.2 -> ^7.0.2
- react-router-dom ^6.30.6 -> ^7.18.5
- react ^18.3.1 -> ^19.3.1
- react-dom ^18.3.1 -> ^19.3.1 (Dependabot's react PR left it on 18)
- @types/react ^18.3.18 -> ^19.3.0
- @types/react-dom ^18.3.5 -> ^19.3.0

No source edits were needed: build, typecheck and the 90 unit tests pass
unchanged. frontend/bun.lock regenerated with Bun 1.4.4.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDiW8qD4f2JDQJ4buGo
The frontend upgrade in this pull request moves React 18 to 19. The
settled-decisions list named React 18, so it is updated in the same
change. The decision itself is unchanged: one UI stack, React and
TypeScript, built by Vite and managed with bun. Changed on the owner's
instruction of 2026-11-17; the list says a pull request does not reopen
these decisions, and this one does not.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDiW8qD4f2JDQJ4buGo
@hyperpolymath
hyperpolymath force-pushed the claude/focused-meitner-uf53td branch from 354688e to 52b16b1 Compare November 17, 2026 16:16
Copilot AI balanced review requested due to automatic review settings November 17, 2026 16:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 35e3164 into main Nov 17, 2026
22 checks passed
@hyperpolymath
hyperpolymath deleted the claude/focused-meitner-uf53td branch November 17, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants