Skip to content

ci: repair main's failing checks (standards pins, DEED registry, scorecard perms, Hypatia SARIF) - #402

Open
hyperpolymath wants to merge 5 commits into
mainfrom
claude/great-knuth-oaq263
Open

hyperpolymath wants to merge 5 commits into
mainfrom
claude/great-knuth-oaq263

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

This fixes the root causes of most of main's (9ef24aa) red checks. It also lists what this PR cannot make green, and why. Every claim below was reproduced locally against main, then shown passing on this branch, wherever it could run outside GitHub.

Changes

Check on main Root cause (measured) Fix in this PR
governance.yml, secret-scanner.yml, scorecard.yml: failure, 0 jobs, name == path (1) At the pinned standards SHAs (da2c748a, 74d2f66f), standards' own actions.lock keys actions/checkout@3d3c42e5… with ref: '3d3c42e5…'. That is a self-SHA leaf, and the runner refuses it as an "invalid lockfile pin" (the same error the Dependabot PRs show). (2) Job-level uses: does not follow the standards transfer, so hyperpolymath/standards/… does not resolve. Re-pinned to metadatastician/standards@c0604136 (standards HEAD, which has ref: 'v7.0.1') using standards' own propagate-workflow-pins.sh --fix, which calls relock-standards-pin.sh. No hand edits to actions.lock.
scorecard.yml after re-pin scorecard-reusable.yml@c0604136 has its scorecard job request actions: read. The caller's job-level permissions: replaces read-all, so GitHub would reject the workflow. Added actions: read. A caller-grants ≥ callee-requests check fails before this change and passes after it.
Dogfood Gate / Validate DEED manifests audits/assail-classifications.a2ml has no identity or version. The file was also inert: panic-attack's legacy reader only parses (classification …) s-expressions, and these 14 entries used a - suppression: YAML form. Replaced with audits/assail-classifications_praxis.deed, the path panic-attack reads first. It has zero active classifications, so behaviour is unchanged (measured below). The 14 boilerplate candidates are kept as comments marked unreviewed and not active.
Hypatia: Path does not exist: hypatia.sarif A secondary error. setup-beam failed first, so the converter never ran, and the always() upload still fired. Upload is guarded with hashFiles('hypatia.sarif') != ''. The job still fails, now only on its real cause.

❌ Blockers this PR does not clear

  1. Hypatia: erlef/setup-beam@v1.24.0 cannot map ImageOS=ubuntu26. v1.24.1 adds it (ubuntu26 → ubuntu-26.04), and hex.pm publishes OTP-27.3.4.9 and Elixir v1.18.6-otp-27 builds for 26.04. The lock record must be regenerated by gh actions-lock. This session cannot run it: the tool needs the GitHub REST API for erlef/setup-beam and the other actions in that workflow, and the session's GitHub access only covers repositories with credentials attached. I did not hand-write the record. To finish it: change .github/workflows/hypatia-scan.yml to erlef/setup-beam@v1.24.1, then run gh actions-lock .github/workflows/hypatia-scan.yml.
  2. Governance will now start, and is expected to go red on Actions lockfile verify. check-lock-pin-contract.sh reports 42 violations (canon rule 10: lock keys must be SHA-pinned). The count is identical on main and on this branch, so the change didn't cause it. It was hidden while governance died at startup. The same root cause produces 31 of SonarCloud's 79 new-code vulnerabilities (githubactions:S7637). One fix clears both, and Claude/create claude md 013mf sv2x31y e2 dtls pz no r3 #1 too: inline-SHA-pin every uses: (@<sha> # vX.Y.Z), then run the estate repair order gh actions-lock → relock-sha-keys.sh → complete-job-refs.sh → close-lock.sh → prune-stale.sh. This needs the API access described in Claude/create claude md 013mf sv2x31y e2 dtls pz no r3 #1. Other governance jobs (no-new-a2ml, language-policy, deed-conformance and so on) have never run here, and I have not simulated them.
  3. Pre-existing lock drift: check-lock-sync.sh reports orphan dependency records trufflehog@v3.93.8 and gitleaks/gitleaks-action@v2.3.9, identical on main. prune-stale.sh only prunes workflow entries. The repair order in chore(deps): Bump tracing-subscriber from 0.3.20 to 0.3.22 in /components/core #2 removes these.
  4. Actions allow-list: this PR calls metadatastician/standards. If the allow-list only admits hyperpolymath/*, these three workflows will startup_failure. Fix with widen-actions-allowlist.sh.

SonarCloud / SonarQube (report only, nothing disabled)

  • SonarQube job (build.yml): token or config problem. The scanner dies on GET api.sonarcloud.io/analysis/jres → HTTP 403. Measured: that endpoint returns 200 anonymously and 403 with an invalid bearer token, so the SONAR_TOKEN secret is invalid, expired or revoked. Regenerate it in SonarCloud and update the repository secret.
  • SonarCloud Code Analysis: real finding. Automatic analysis of 9ef24aa succeeded, and the quality gate is ERROR on new_security_rating = 3 > 1 (new-code window since 2026-07-01). There are 79 open vulnerabilities on new code: 75 MAJOR and 4 MINOR. 31 are githubactions:S7637 (see blocker chore(deps): Bump tracing-subscriber from 0.3.20 to 0.3.22 in /components/core #2). 13 are shell:S6505/S6506 (installs without --ignore-scripts, curl without HTTPS-only redirects). The rest are docker/text/web rules. These need code changes, not configuration.

Dependabot

Once main is green I will tell you before commenting ·@·d·ependabot r·ecreate on PRs #380, #381, #382 and #387. I have not commented yet.

RSR Quality Checklist

Required

  • Tests pass: CI-only change. The local evidence is below.
  • No banned language patterns. The only script added (a permission checker) lives outside the repo, in bash.
  • No unsafe blocks
  • SPDX headers present on the new deed
  • No secrets, credentials or .env files

Testing (each reproduced on main, then shown passing on this branch)

  • deed-ecosystem/validate-action/validate-deed.sh at the locked fedffb3c: main 1 error (assail-classifications.a2ml: Missing required identity field), branch 0 errors (23 files).
  • metadatastician/standards 1-formats/deed/tools/deed_lint.js (bun): new deed OK. Negative control: the old file's content fails (deed must begin with at least one SPDX header line). --self-test OK.
  • panic-attack (built from hyperpolymath/panic-attack@7b9f145; it reads the deed registry strictly): assail on this branch exits 0. Negative control: the same tree with :profile wrong-profile exits 1 with malformed classification registry … invalid :profile. Behaviour unchanged: the weak-point sets (category, location, suppressed) from assail on main and on this branch are identical (4 findings, 4 suppressed by the built-in rules, 0 by the registry, before and after).
  • propagate-workflow-pins.sh audit: 3× BEHIND. After --fix: RELOCKED. check-lock-pin-contract.sh exempts the new record as a reusable edge.
  • Caller ⊇ callee permission check: scorecard FAIL before the perms commit, all three pass after.
  • actionlint v1.7.7: clean on all touched workflows.
  • Sonar 403: reproduced as anonymous 200 vs. bogus-token 403 on the same endpoint.

🤖 Generated with Claude Code

https://claude.ai/code/session_01J4QvDjkNc8Zno9wCLe72sm

…0604136

governance.yml, scorecard.yml and secret-scanner.yml died on every run
with conclusion=failure, 0 jobs and name == path. Two causes, both cured
here by the estate's own tooling (standards scripts/propagate-workflow-pins.sh
--fix, which calls scripts/relock-standards-pin.sh; no hand edits):

1. At the old pins (da2c748a, 74d2f66f) standards' own actions.lock keyed
   actions/checkout@3d3c42e5 with ref: '3d3c42e5...' (the SHA repeated).
   The runner refuses that record ("invalid lockfile pin") in every
   caller. Standards HEAD records ref: 'v7.0.1'.
2. GitHub does not follow the standards transfer for job-level `uses:`,
   so hyperpolymath/standards/... never resolves. Moved to the canonical
   owner metadatastician.

actions.lock gains the metadatastician/standards@c0604136 caller-side
record (nested uses = the union of the called reusables' actions) and the
leaf records it needs, copied from standards' lock at that commit.
check-lock-pin-contract.sh exempts that one record as a reusable edge.

Needs metadatastician/standards on the Actions allow-list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDjkNc8Zno9wCLe72sm
…s deed

Dogfood Gate / "Validate DEED manifests" failed on main with
  audits/assail-classifications.a2ml: Missing required identity field

That file was also inert. Its 14 entries used a `- suppression:` YAML
dialect, and panic-attack's legacy reader only parses
`(classification ...)` s-expressions, so nothing was ever suppressed. Every
entry carried the same generic "Automated estate triage" text, not an
audit of the file.

Replaced with audits/assail-classifications_praxis.deed, the registry path
panic-attack reads first (src/assail/classifications.rs DEED_PATH), in the
canonical form: SPDX header, :schema-version, :canonical-name,
:beholding-chora (hyperpolymath estate chora), :profile
assail-classifications, and ZERO classification clauses. Behaviour is
unchanged: nothing was suppressed before and nothing is suppressed now.
The 14 candidates are kept as comments marked unreviewed and not active.

Verified locally:
- metadatastician/standards 1-formats/deed/tools/deed_lint.js: OK
  (the old file's content fails it: no SPDX header)
- deed-ecosystem validate-action (fedffb3c, the locked commit): 23 files,
  0 errors (was 1)

A2ML is retired for new content. This removes one .a2ml and adds no new one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDjkNc8Zno9wCLe72sm
The caller job's permissions block replaces the workflow-level read-all.
scorecard-reusable.yml at c0604136 has its `scorecard` job request
actions: read, which the caller did not grant, so GitHub would reject the
workflow at parse time. Checked caller-grants >= callee-requests for all
three standards callers. Before this change, scorecard failed the check;
after it, all three pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDjkNc8Zno9wCLe72sm
On main the scan job failed at erlef/setup-beam (ImageOS ubuntu26 is
unknown to v1.24.0), so the converter never ran. The always() upload
step then added a second, misleading error: "Path does not exist:
hypatia.sarif". With a hashFiles guard the job still fails, now only on
its real cause. A broken converter is still a failed step, so no silent
pass is possible.

This does NOT fix the scan itself. That needs erlef/setup-beam v1.24.1
(maps ubuntu26 -> ubuntu-26.04; hex.pm has OTP-27.3.4.9 and Elixir
1.18.6-otp-27 builds for it) plus a gh actions-lock regeneration, which
this session could not run. See the PR's blocker list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDjkNc8Zno9wCLe72sm
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores

    • Updated the shared workflows used for governance, security scoring and secret scanning.
    • Security report uploads are now skipped when no report is available.
  • Security

    • Removed existing audit suppressions, allowing the affected findings to be surfaced.
    • Added an empty classification registry. Findings remain unclassified until they have been reviewed and supported by an audit rationale.

The pull request changes three reusable workflow references and the Scorecards job permissions. It adds a file-existence check to the SARIF upload condition. It also removes 14 audit suppressions and adds an empty DEED classification registry.

Changes: CI workflow updates

Layer / File(s) Summary
Reusable workflow references
.github/workflows/governance.yml, .github/workflows/scorecard.yml, .github/workflows/secret-scanner.yml
The governance, Scorecards, and secret-scanner jobs now use reusable workflows from metadatastician/standards. The Scorecards job adds actions: read to its permissions and no longer inherits secrets.
SARIF upload condition
.github/workflows/hypatia-scan.yml
The upload condition also requires hypatia.sarif to exist. The existing always() condition and fork pull-request exclusion remain.

Audit classification registry

Layer / File(s) Summary
Empty registry and suppression removal
audits/assail-classifications_praxis.deed, audits/assail-classifications.a2ml
The new DEED file documents an empty classification list and 14 unreviewed candidates. The legacy file containing 14 suppressions is removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 68ba0

This PR re-pins the reusable workflows, tightens Scorecard permissions and secret handling, guards the SARIF upload, and replaces the old suppression file with an empty classification registry. The diff shows no new runtime or security risk. The author discloses that some checks still fail for reasons outside this diff: the Hypatia runner image mapping, the SonarQube token, and a possible actions allow-list restriction. Those need separate follow-up.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: CI repairs on main across standards pins, the DEED registry, scorecard permissions and the Hypatia SARIF upload. It is specific and matches the changeset. It is long a…
Description check Passed The description is closely related to the changeset. It covers the standards re-pin, the scorecard actions: read permission, the replacement of the audit registry with a DEED file, the Hypatia SARIF g…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: CI repairs on main across standards pins, the DEED registry, scorecard permissions and the Hypatia SARIF upload. It is specific and matches the changeset. It is long at 96 characters, but it remains a single clear sentence.

Full details: Description check

Explanation

The description is closely related to the changeset. It covers the standards re-pin, the scorecard actions: read permission, the replacement of the audit registry with a DEED file, the Hypatia SARIF guard, and the testing performed. It also lists remaining blockers.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4d3f6eb4-e962-4c39-80f6-9e7f434a0c40
Commits

Reviewing files that changed from the base of the PR and between de8894e and 68ba0c2.

Files selected for processing: 1

  • .github/workflows/scorecard.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 1

  • GitHub Check: CodeRabbit
CI failures not shown inline: 2

GitHub Actions: Hypatia Security Scan / 0_Hypatia Neurosymbolic Analysis.txt: ci: repair main's failing checks (standards pins, DEED registry, scorecard perms, Hypatia SARIF)

Conclusion: failure

View job details

##[group]Run erlef/setup-beam@v1.24.0
 with:
   elixir-version: 1.18
   otp-version: 27
   github-***REDACTED_SECRET_ASSIGNMENT***
   otp-architecture: 64
   install-hex: true
   install-rebar: true
   version-type: loose
   disable_problem_matchers: false
   hexpm-mirrors: https://builds.hex.pm
 ##[endgroup]
 ##[error]Tried to map a target OS from env. variable 'ImageOS' (got ubuntu26), but failed. If you're using a self-hosted runner, you should set 'env': 'ImageOS': ... to one of the following: ['ubuntu22', 'ubuntu24', 'win19', 'win22', 'win25', 'macos13', 'macos14', 'macos15', 'macos26']

GitHub Actions: Build / 0_SonarQube.txt: ci: repair main's failing checks (standards pins, DEED registry, scorecard perms, Hypatia SARIF)

Conclusion: failure

View job details

##[group]Run SonarSource/sonarqube-scan-action@v8.1.0
 with:
   projectBaseDir: .
   scannerVersion: 8.1.0.6389
   scannerBinariesUrl: https://binaries.sonarsource.com/Distribution/sonar-scanner-cli
   skipSignatureVerification: false
 env:
   SONAR_***REDACTED_SECRET_ASSIGNMENT***
 ##[endgroup]
 Installing Sonar Scanner CLI 8.1.0.6389 for linux-x64...
 Downloading from: https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-8.1.0.6389-linux-x64.zip
 Downloading signature from: https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-8.1.0.6389-linux-x64.zip.asc
 Importing SonarSource public key from hkps://keyserver.ubuntu.com...
 [command]/usr/bin/gpg --homedir /home/runner/work/_temp/gpg-home-1794933325688-2391 --batch --keyserver hkps://keyserver.ubuntu.com --recv-keys 679F1EE92B19609DE816FDE81DB198F93525EC1A
 gpg: keybox '/home/runner/work/_temp/gpg-home-1794933325688-2391/pubring.kbx' created
 gpg: /home/runner/work/_temp/gpg-home-1794933325688-2391/trustdb.gpg: trustdb created
 gpg: key 1DB198F93525EC1A: public key "SonarSource Sàrl <infra@sonarsource.com>" imported
 gpg: Total number processed: 1
 gpg:               imported: 1
 Successfully imported key from hkps://keyserver.ubuntu.com
 ✓ SonarSource public key imported successfully
 Verifying GPG signature...
 [command]/usr/bin/gpg --homedir /home/runner/work/_temp/gpg-home-1794933325688-2391 --batch --verify /home/runner/work/_temp/74c3aa55-5bb1-46ca-b692-03a4ca31e459 /home/runner/work/_temp/41f6e4c1-126a-4d48-b6f3-6bcdc6ff0bac
 gpg: Signature made Tue Apr 21 07:20:26 2026 UTC
 gpg:                using RSA key D1436C0DBACEA48702AF97C363F1DD7753B8B315
 gpg: Good signature from "SonarSource Sàrl <infra@sonarsource.com>" [unknown]
 gpg: WARNING: This key is not certified with a trusted signature!
 gpg:          There is no indication that the signature belongs to the owner.
 Primary key fingerprint: 679F 1EE9 2B19 609D E816  FDE8 1DB1 98F9 3525 EC1A
   ...
Additional comments: 1

.github/workflows/scorecard.yml: 1

15-15: Stability & Availability

The concern asks whether an external actions policy might reject this reusable workflow. That premise depends on live account settings that this review cannot establish from the checked-out source. The PR already reports this risk as an open operational item. The diff does not break an explicit repository contract, so the concern is not a code defect that this review should raise.

SonarCloud flagged githubactions:S7635 ("Only pass required secrets") on
the scorecard caller in this PR. scorecard-reusable.yml at c0604136
declares no workflow_call secrets and references none (it uses only
github.token), so `secrets: inherit` handed it every repository secret
for nothing. Removing it changes no behaviour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDjkNc8Zno9wCLe72sm

Copy link
Copy Markdown
Owner Author

CI status on de8894e, and what 68ba0c2 changes:

  • Hypatia Neurosymbolic Analysis: red, blocker Claude/create claude md 013mf sv2x31y e2 dtls pz no r3 #1 in the description, not something this PR introduced. The run now fails only at erlef/setup-beam@v1.24.0 (Tried to map a target OS from env. variable 'ImageOS' (got ubuntu26)). The secondary Path does not exist: hypatia.sarif error from main is gone, as intended. Clearing it needs erlef/setup-beam@v1.24.1 plus a gh actions-lock .github/workflows/hypatia-scan.yml regeneration, which this session cannot run because it has no GitHub API access to the action repos.
  • SonarCloud Code Analysis: the PR's own new-code issue is fixed in 68ba0c2. The PR analysis had exactly one issue: githubactions:S7635 on scorecard.yml (secrets: inherit). The scorecard reusable at c0604136 declares no secrets and reads none, so the inherit is removed with no change in behaviour. If the gate stays at C after re-analysis, it will be the project's existing new-code backlog (79 issues on main), not this diff.

Generated by Claude Code

Copy link
Copy Markdown
Owner Author

SonarQube (build.yml) on 68ba0c2 is red for the same reason as on main (9ef24aa). This PR did not cause it. The scanner stops before any analysis:

ERROR Failed to query JRE metadata: GET https://api.sonarcloud.io/analysis/jres?os=linux&arch=x86_64 failed with HTTP 403 Forbidden. Please check the property sonar.token or the environment variable SONAR_TOKEN.

That endpoint returns 200 without a token and 403 with an invalid one, so the SONAR_TOKEN repository secret is invalid, expired or revoked. The fix is a new token from SonarCloud (organization hyperpolymath, project hyperpolymath_academic-workflow-suite) saved as the SONAR_TOKEN secret. No code change in this PR can fix it, and the job is left enabled.


Generated by Claude Code

@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Owner Author

Governance and Secret Scanner moved from failure (0 jobs, name == file path) on main to startup_failure with their real workflow names on this PR. The name now resolving means the workflow files parse and the metadatastician/standards reusables are found. Parse-level and resolution faults are fixed.

The remaining startup_failure is blocker #4 (Actions allow-list), not this diff:

  • actions.lock has no dangling edges on main or on this head (every ref under workflows: and every nested uses: has a top-level record; checked offline). That rules out the other known startup_failure cause.
  • CI/CD (ci.yml, which this PR does not touch) shows the same startup_failure on main and here.
  • The re-pinned reusables call metadatastician/standards plus actions this repo has never run (denoland/setup-deno, oven-sh/setup-bun, ossf/scorecard-action, actions/cache@v6.1.0, …). A narrowed allow-list rejects these at startup.

Fix: run widen-actions-allowlist.sh for this repository so it admits metadatastician/standards and the actions its reusables lock. I can't read or change the allow-list from this session.


Generated by Claude Code

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 17, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants