Repository navigation
docs(plan): verifier family plan; stale metadata corrected - #20
Conversation
|
Caution Review failedThe pull request is closed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
| @@ -0,0 +1,326 @@ | |||
| // SPDX-License-Identifier: CC-BY-SA-4.0 | |||
|
🟠 indeterminate · commit Advisory: 11 row(s), worst 🟠 indeterminate (0 critical, 0 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 0 (0 reporter observations; 0 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: error — the scanner produced no SARIF projection
panic-attack assail: 20 finding(s)
pons asinorum: 9 finding(s)
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): not_run — enrolled, but no report-back was received
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): not_run — enrolled, but no report-back was received
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): not_run — enrolled, but no report-back was received
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
The Sonar project key still named zigprove. The citation abstract claimed more than the README. The changelog had no entry for the 2026-11-07 repair, the u8 pilot or the finite-model replay. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmp1i8PGVHkq3u2iNz
FAMILY-ULTRAPLAN.adoc holds the work that Atoma shares with quintessence, Apodeixis.jl, bactrian, canonry and chancel: measured state, aspect evaluation, shared packages F1 to F12, waves W0 to W5, model roles, CI design and the ECHIDNA coprocessor findings. ULTRAPLAN.adoc gains one section that maps stages R0 to R5 to that plan. Existing stages, gates and task IDs do not change. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zmp1i8PGVHkq3u2iNz
384eb28 to
d4bb167
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4bb1674a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Requires the SONAR_TOKEN repository secret + a SonarCloud project (owner setup). | ||
| sonar.organization=hyperpolymath | ||
| sonar.projectKey=hyperpolymath_zigprove | ||
| sonar.projectKey=hyperpolymath_atoma |
There was a problem hiding this comment.
Keep the scanner pointed at the provisioned project
When SONAR_TOKEN is configured, this redirects the SonarQube workflow from the repository's documented existing project, hyperpolymath_zigprove (docs/audit/2026-11-07-soundness-sprint.adoc:149-151), to hyperpolymath_atoma, but this change neither provisions that project nor migrates the token/permissions. Because sonar.projectKey identifies the unique target project and project-scoped tokens authorize only that project (SonarQube Cloud analysis parameters), configured scans will fail or stop updating the established project until that external migration occurs; retain the existing key or complete and document the migration atomically.
Useful? React with 👍 / 👎.
| |=== | ||
| | Stage | Family wave and packages | Lead | Size | Notes | ||
| | R0 | W0 | Sonnet | S | Done, apart from the inherited template drift (F1). | ||
| | R1 | W1 and W2: F3, F6, F7 | Opus | L | Extract the evidence kit from the replay scripts here. Then finish the alias counterexample and the typed boundary. |
There was a problem hiding this comment.
Assign F5 before scheduling completion of W1
When this table is used as Atoma's execution map, R1 claims W1 but assigns only F3, F6, and F7, omitting F5. The family plan defines F5 as the benchmark package, makes a real benchmark baseline part of W1's exit evidence (FAMILY-ULTRAPLAN.adoc:158), and explicitly lists adding Atoma's replay and mutant-rejection benchmarks as its next step (FAMILY-ULTRAPLAN.adoc:239); no later Atoma stage owns F5. Following the new mapping therefore cannot close W1 as defined, so add F5 to R1 or explicitly assign it to another stage.
Useful? React with 👍 / 👎.
| | F8 | Zig seam. `atoma` checks the Zig code that `quintessence` (NIF) and `bactrian` (FFI) admit. | One provider, two consumers | ||
| | F9 | BEAM actor protocol layer. `quintessence` Layer B and `bactrian` Layer B use the same K-CUT rules, occupancy bound and upstream Agda authorities. | Same semantics, two front ends | ||
| | F10 | Coprocessor contract with ECHIDNA. See the section below. | One contract | ||
| | F11 | Proof Witness Grade recipe for theory: receipt for `PWG-3`, then a Rocq leg and a Lean leg. Applies to `canonry` and to the `atoma` Agda modules. | Same recipe |
There was a problem hiding this comment.
Generate the PWG-1 receipt after both recheck legs
When F11 is followed literally, the receipt is created at PWG-3 before the Rocq and Lean witnesses exist, and the Atoma mapping repeats that order at ULTRAPLAN.adoc:183. The repository's grade policy defines PWG-3 as the canonical Agda check, PWG-2i/PWG-2ii as the one- and two-leg rechecks, and only PWG-1 as adding a current per-commit receipt for every witness (verification/proofs/README.adoc:56-61). A receipt generated before the legs cannot bind those later witnesses and therefore cannot establish PWG-1; reorder F11 or explicitly regenerate the final receipt after both legs.
Useful? React with 👍 / 👎.
| `Apodeixis.jl`, `bactrian`, `canonry`, `chancel`) is in | ||
| link:FAMILY-ULTRAPLAN.adoc[the family plan]. That plan holds the shared work | ||
| packages F1 to F12, the waves W0 to W5, the model roles and the effort scale. | ||
| Atoma is the pathfinder: each shared package is done here first. |
There was a problem hiding this comment.
Limit the pathfinder rule to Atoma-applicable packages
When agents use this as an execution rule, requiring every F1-F12 package to be done in Atoma first conflicts with the family plan's own package scopes: F1 must be fixed in rsr-template-repo and synced rather than patched in a child (FAMILY-ULTRAPLAN.adoc:79,108), while F9 is specifically the BEAM actor layer shared by quintessence and bactrian (FAMILY-ULTRAPLAN.adoc:87). Neither can be implemented in Atoma first, so the universal rule makes the schedule impossible; qualify it to packages for which Atoma is the designated provider and name an appropriate first repository for the others.
Useful? React with 👍 / 👎.



Summary
Two commits, each reviewable alone. Documentation and metadata only. No tool, proof or gate changes.
docs: stale project metadata and missing changelog entries.docs(plan): the shared plan for the six sibling verifiers, and one new section in the Atoma plan.Changes
sonar-project.properties: the project key still namedzigprove.CITATION.cff: the abstract claimed more than the README. It now says experimental, closed Zig subset, not a general sound verifier.CHANGELOG.adoc: entries for the 2026-11-07 repair, the u8 pilot and the finite-model replay. Facts come fromdocs/audit/2026-11-07-source-replay.adocand the plan.docs/plan/FAMILY-ULTRAPLAN.adoc(new): measured state ofatoma,quintessence,Apodeixis.jl,bactrian,canonryandchancelon 2026-11-15; aspect evaluation; common work F1 to F12 against bespoke work; waves W0 to W5; model roles (advisor, Opus, Sonnet, Haiku) and effort sizes; CI design; ECHIDNA coprocessor findings; shared-library verdicts.docs/plan/ULTRAPLAN.adoc: one appended section maps stages R0 to R5 to the family plan. Existing stages, gates, estimates and task IDs do not change.The family plan lives here because
docs/decisions/ATOMA-SIBLING-TRANSFER.adocalready makes Atoma the first slice. The owner can move it.RSR Quality Checklist
CHANGELOGupdatedTesting
Measured in this session, unchanged by this PR:
zig build testintools/atomagave 24 of 24 passed (Zig 0.15.2);verification/atoma/check-agda.shgave 4 modules, 0 postulates, 0 holes (Agda 2.6.3).scripts/atoma-gate.shwas not run locally; theAtoma soundnessworkflow is the evidence for it.Estate checks run and passing:
check-no-placeholders.sh,check-internal-links.sh,check-no-md-in-docs.sh,check-spdx-headers.sh,check-lock-sync.sh,check_root_shape_test.sh.Generated by Claude Code