Repository navigation
fix(proofs): take the template's check-proofs.sh - #25
Conversation
check_proofs_test (estate-rules) fails on atoma main (9 of 14 controls) because atoma's scripts/check-proofs.sh is an older version than the template's. The template's closes gate holes: lean 'sorry', coqc exiting 0 on Admitted (via scripts/scan-dangerous.sh, already identical here), idris2 unsolved holes, and the PROOF-POLICY section 2.1 Agda invocation (--cubical-compatible). Atoma's copy also hard-coded two extra scan roots (verification/atoma, examples/atoma). Checked, not assumed: atoma's agda and idris2 MANIFESTs already name verification/atoma/agda and examples/atoma/frame-v1/abi, and all 4 .agda and 3 .idr files under those trees sit under the named roots, so the template's manifest-named-roots scan covers the same files today. Verified locally: check_proofs_test rc 0 (was failing); the gate still fails, not skips, with no toolchain (rc 1); bash -n ok. NOT verified: Agda, Idris2, Coq and Lean are not installed here, so whether atoma's real proofs pass the stricter gate and the added --cubical-compatible flag is only shown by CI. If they do not, that is a finding to fix in the proofs, not a reason to loosen the gate. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zk1VxiWdKq68AQx2Ev
|
🟢 clean · commit Advisory: 11 row(s), worst 🟠 indeterminate (0 critical, 0 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 1 (1 reporter observations; 1 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: 4 finding(s)
panic-attack assail: 20 finding(s)
pons asinorum: 9 finding(s)
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): not_run — enrolled, but no report-back was received
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): not_run — enrolled, but no report-back was received
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): not_run — enrolled, but no report-back was received
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This branch now also contains the PROOF-STATUS shape fix from #24 (merged in as Still not verified: whether atoma's real proofs pass the stricter If #24 merges first, this PR just shrinks to the Generated by Claude Code |
|
Correction to my previous comment: this PR was already merged ( What this means now: Generated by Claude Code |



estate-rulesalso fails on atomamainatcheck_proofs_test(9 of 14 controls), because atoma'sscripts/check-proofs.shis an older version than the template's. This takes the template's version.What the template's version adds (holes first)
leansorryhandling;coqcexiting 0 onAdmitted(caught viascripts/scan-dangerous.sh, already identical here);idris2unsolved holes; and the PROOF-POLICY §2.1 Agda invocation (--cubical-compatible).Checked, not assumed: atoma's extra scan roots
Atoma's copy hard-coded two extra roots (
verification/atoma,examples/atoma). The template scans the proof dir plus every root the MANIFESTs name. Atoma's agda and idris2 MANIFESTs already nameverification/atoma/agdaandexamples/atoma/frame-v1/abi, and all 4.agdaand 3.idrfiles under those trees sit under the named roots, so both scripts cover the same files today. Trade-off: a future proof file added elsewhere underverification/atomaorexamples/atomais no longer flagged as unlisted unless a manifest names its root.Verified locally
check_proofs_testrc 0 (was failing); the real gate still fails, not skips, with no toolchain (rc 1). With #24 also applied, 57 of the 58 plainestate-rulessteps pass locally; the other,chain_mint_test, needsuuidgen(absent in my sandbox) and passes in CI on apodeixis (same step,estate-rulesgreen on itsmain).NOT verified (please read)
Agda, Idris2, Coq and Lean are not installed in my sandbox. Whether atoma's real proofs pass the stricter gate and the added
--cubical-compatibleflag is shown only by CI. If they do not, that is a finding about the proofs to fix, not a reason to loosen the gate.Decision I made for you
I asked this as a selector; it was interrupted, so I took the option I had marked recommended. Close this PR to keep atoma on its older, weaker gate. This PR alone does not clear
estate-rules: it needs #24 as well (the PROOF-STATUS shape).Generated by Claude Code