Repository navigation
Define the Proven and adapter proof boundaries with executable mismatch evidence - #26
Conversation
|
Caution Review failedThe pull request is closed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
🟢 clean · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 20 (20 reporter observations; 19 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: 4 finding(s)
panic-attack assail: 20 finding(s)
pons asinorum: 9 finding(s)
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): 11 finding(s)
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): 96 finding(s)
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): 185 finding(s)
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9598c18f31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ZIG | ||
| "$zig" build-obj "$proven/ffi/zig/src/main.zig" -lc -femit-bin="$work/proven.o" > "$evidence/zig-build.log" 2>&1 | ||
| "$zig" build-exe "$work/probe.zig" "$work/proven.o" -lc -femit-bin="$work/probe" >> "$evidence/zig-build.log" 2>&1 | ||
| "$work/probe" > "$evidence/zig-results.txt" 2>&1 |
There was a problem hiding this comment.
Preserve runtime failures as probe errors
If either generated executable exits nonzero—for example, the Zig wrapper reaches error.UnexpectedStatus after the ABI starts returning an error—set -e terminates the script at this command before the result validation or diff runs. Because Zig commonly exits with status 1 in that case, callers receive the same status reserved for an observed Idris/Zig disagreement even though no comparison occurred; the Idris pipeline has the same early-exit problem under pipefail. Capture each executable's status and report such execution failures as probe errors (exit 2) before comparing their output.
Useful? React with 👍 / 👎.



The first real consumer probe demonstrates that Proven's RefC-compiled header predicate and Zig export disagree on lone CR, lone LF and embedded CR. This records the semantic decisions for the next Atoma milestone and adds a diagnostic that executes both implementations and fails on disagreement.
The design covers exact-byte marshaling, null/length and ownership contracts, finite protocol decoding, real transport registration, source-to-model refinement, source-bound replay, witness identity and appropriate reuse of Mathesis. It links the checked Sholes line-ending/streaming work in hyperpolymath/sholes#15. Mathesis' feature-reachability theorem was rechecked in Agda, Lean and Rocq/coqchk; its missing/status modules were rechecked in strict compatible Agda.
Validation:
bash -nandgit diff --checkpass.This is an evidence-backed design and regression diagnostic, not a repaired FFI or extended Atoma verifier. The document gives ordered implementation packets and explicit completion criteria. The ordinary Atoma checks are not changed to pretend this known consumer failure is a successful proof.