Skip to content

chore(arrival-pack): take the template's generated Proofs guidance - #36

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/arrival-pack-proofs
Nov 15, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/arrival-pack-proofs

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

The template now generates the ## Proofs block inside the arrival-pack region (hyperpolymath/rsr-template-repo#413), with the PROOF-POLICY §1.1 and §8.1 wording fixes from hyperpolymath/rsr-template-repo#400. This carries that engine here and regenerates CLAUDE.md.

Owner decision by selector, 2026-11-15.

Changes

  • .machine_readable/arrival-pack/arrival-pack.ncl and extract.sh: copied from the template at 894038e.
  • CLAUDE.md: regenerated. The hand-authored Proofs copy below the region (older wording) is removed, so the block appears once.
  • tests/workflows/governance_policy_test.sh: the template's version, which asserts the Proofs block is inside the generated region. The old version asserts the opposite and fails after this change.

Regenerating also brings the template's newer estate-common text: the kyq data-format paragraph in Canon pointers, the chora-registry wording, a reworded Identity line (the id itself is unchanged), and an "Anchor override" line read from this repo's own deed (Node.js, npm). Please check that last line is true for this repo.

scripts/deed-field.sh is deliberately not upgraded: the existing copy is enough for the new engine, and upgrading it would also need a newer uuid_v8_test.sh.

RSR Quality Checklist

Required

  • Tests pass (just test) — not run locally. Left to CI.
  • No banned language patterns
  • No secrets, credentials, or .env files included

Testing

  • bash .machine_readable/arrival-pack/verify.sh → in sync with the deed.
  • All 55 scripts under tests/ run before and after: no result changed. The same 3 fail both times in the session container (check_adoc_renders_test, julia_library_test, ffi_strings_test); not investigated, not caused by this change.
  • The generated Proofs block is byte-identical to the template's.

Generated by Claude Code

…sr-template-repo#413)

The template now generates the '## Proofs' block inside the arrival-pack
region (rsr-template-repo#413), with the PROOF-POLICY §1.1 and §8.1 wording
from rsr-template-repo#400. This carries the engine here and regenerates
CLAUDE.md; the hand-authored copy below the region is removed so the block
appears once. governance_policy_test.sh is the template's, which asserts the
block is inside the region.

Regenerating also brings the template's newer estate-common wording and
identity line. scripts/deed-field.sh is left as it is.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zoc4g7WLgAwdMTnzPM
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Hypatia grid green

🟢 clean · commit a6ec79a5fee3 · run 43700695618 · scope: this change (4 file(s))

Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change.

Unique graded findings across gating and advisory rows: 20 (20 reporter observations; 19 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Raw Hypatia alert-derived observations: 39 (code-scanning, Dependabot and secret-scanning; some may also be in SARIF; not an extra total).

Reporter Gate Status Critical High Medium Minor Since previous revision
Hypatia scan gating 🟢 clean 0 0 0 0 — same commit (no revision comparison)
panic-attack assail advisory 🟢 clean 0 0 0 0 — same commit (no revision comparison)
pons asinorum advisory 🟢 clean 0 0 0 0 — same commit (no revision comparison)
echidnabot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
rhodibot (RSR compliance) advisory 🟢 clean 0 0 0 0 — same commit (no revision comparison)
panicbot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
sustainabot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
glambot (presentation quality) advisory 🔵 minor 0 0 0 6 — same commit (no revision comparison)
seambot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
finishingbot (release readiness) advisory 🔴 high 0 9 5 0 — same commit (no revision comparison)
cipherbot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
accessibilitybot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
Hypatia scan: 4 finding(s)
  • 4 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
panic-attack assail: 18 finding(s)
  • 18 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
pons asinorum: 9 finding(s)
  • 9 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
  • ⚪ not applicable: template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): 11 finding(s)
  • 11 further finding(s) in files this change does not touch: reported, not graded (0 critical, 10 high).
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
  • ⚪ not applicable: panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
  • ⚪ not applicable: reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): 88 finding(s)
  • info GS-001 — Install git-seo for comprehensive SEO analysis: https://github.com/hyperpolymath/git-seo
  • info MACH-007 — ECOSYSTEM.scm not found in .machine_readable/ directory.
  • info MACH-007 — META.scm not found in .machine_readable/ directory.
  • info MACH-007 — STATE.scm not found in .machine_readable/ directory.
  • info MACH-005 — No robots.txt found. Consider adding one for crawler control.
  • info VIS-005 — CLAUDE.md:9 — Line 177 characters exceeds max length of 80.
  • 82 further finding(s) in files this change does not touch: reported, not graded (0 critical, 2 high).
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
  • ⚪ not applicable: template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): 177 finding(s)
  • high V1-DOC-ROADMAP.adoc — Required file ROADMAP.adoc not found (Project roadmap).
  • high TOOL-001 — .tool-versions file not found for asdf/mise version management.
  • high SCM-001-NEUROSYM.scm — Required SCM file NEUROSYM.scm not found (Neurosymbolic AI documentation).
  • high SCM-001-AGENTIC.scm — Required SCM file AGENTIC.scm not found (Agentic AI integration documentation).
  • high SCM-001-PLAYBOOK.scm — Required SCM file PLAYBOOK.scm not found (Operational playbooks and procedures).
  • high SCM-001-ECOSYSTEM.scm — Required SCM file ECOSYSTEM.scm not found (Project's place in the ecosystem).
  • high SCM-001-META.scm — Required SCM file META.scm not found (Meta-level information and architectural decisions).
  • high SCM-001-STATE.scm — Required SCM file STATE.scm not found (Project state and progress tracking).
  • high PH-100 — Found 127 placeholders, exceeds maximum allowed (0)
  • medium V1-COM-CONTRIBUTING.md — CONTRIBUTING.md file not found (Contribution guidelines).
  • medium V1-COM-CODE_OF_CONDUCT.md — CODE_OF_CONDUCT.md file not found (Code of conduct).
  • medium V1-SEC-001 — SECURITY.md not found for responsible disclosure.
  • medium TEST-001 — Could not determine if this is a Rust or Deno project.
  • medium REL-004 — No SECURITY.md file found
  • 163 further finding(s) in files this change does not touch: reported, not graded (0 critical, 4 high).
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
  • ⚪ not applicable: template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
  • ⚪ not applicable: template default: enrol once the repository serves HTML

Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run.

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 15, 2026 09:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T10:01:58.063478Z a6ec79a Draft marked ready
🔒 Security Review ✅ Completed 2026-11-15T10:02:19.565667Z a6ec79a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath merged commit 4bd48e8 into main Nov 15, 2026
42 checks passed
@hyperpolymath
hyperpolymath deleted the claude/arrival-pack-proofs branch November 15, 2026 09:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6ec79a5fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +24 to +25
if std.array.length data.anchor_forbidden == 0 then ""
else "\n- **Anchor override** (ANCHOR) — This repo's anchor forbids: %{std.string.join ", " data.anchor_forbidden}. The anchor overrides the estate policy above."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render allowed anchor overrides

When an anchor explicitly allows a language denied by the estate policy—or supplies only an allowed list—this condition emits no corresponding override, even though extract.sh reads anchor_allowed. The generated guidance therefore continues telling agents that the language is forbidden, contradicting the repo-specific anchor; include allowed entries in the override and emit it when either list is nonempty.

Useful? React with 👍 / 👎.

Comment on lines +115 to +118
dependency's whole import cone compiles under the prover's safe mode with zero
postulates, it is *checked, not assumed*: record the cone (root module, flags,
postulate count of zero, library name, version and pin) instead of an
`ASSUMED` row (policy §1.1). A cone with a postulate, or compiled outside safe

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Synchronize the proof guide's dependency exception

When a dependency's import cone passes the new safe-mode/zero-postulate rule, this generated guidance tells agents to record it as checked rather than ASSUMED, but verification/proofs/README.adoc still requires every relied-on dependency to be recorded as ASSUMED. Since the generated section explicitly directs agents to that README as the repo-specific mapping, the two authoritative instructions now produce conflicting proof-status records; update the guide and its governance assertions with the same exception.

Useful? React with 👍 / 👎.

# This repo: `%{data.canonical_name}`

- **Identity** — uuid `%{data.uuid}`; clade `%{data.clade_primary}` (secondary `%{data.clade_secondary}`); born %{data.born}; forge `%{data.forge_gh}`.
- **Identity** — chora id `%{data.uuid}`; clade: %{data.clade_aid}; born %{data.born}; forge `%{data.forge_gh}`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not label a legacy literal as the chora id

For this repository, data.uuid is #u8"gv-clade-index:github.com/hyperpolymath/bactrian", which scripts/deed-field.sh explicitly treats as a legacy computed literal rather than the opaque #uuid"…" chora id minted from the birth path. The generated arrival pack now calls that legacy value the chora id, so agents can use the wrong identifier for repository identity; migrate the deed first or distinguish legacy literals in the rendered label.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants