Repository navigation
chore(arrival-pack): take the template's generated Proofs guidance - #36
Conversation
…sr-template-repo#413) The template now generates the '## Proofs' block inside the arrival-pack region (rsr-template-repo#413), with the PROOF-POLICY §1.1 and §8.1 wording from rsr-template-repo#400. This carries the engine here and regenerates CLAUDE.md; the hand-authored copy below the region is removed so the block appears once. governance_policy_test.sh is the template's, which asserts the block is inside the region. Regenerating also brings the template's newer estate-common wording and identity line. scripts/deed-field.sh is left as it is. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zoc4g7WLgAwdMTnzPM
|
Caution Review failedThe pull request is closed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
|
🟢 clean · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 20 (20 reporter observations; 19 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: 4 finding(s)
panic-attack assail: 18 finding(s)
pons asinorum: 9 finding(s)
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): 11 finding(s)
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): 88 finding(s)
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): 177 finding(s)
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6ec79a5fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if std.array.length data.anchor_forbidden == 0 then "" | ||
| else "\n- **Anchor override** (ANCHOR) — This repo's anchor forbids: %{std.string.join ", " data.anchor_forbidden}. The anchor overrides the estate policy above." |
There was a problem hiding this comment.
Render allowed anchor overrides
When an anchor explicitly allows a language denied by the estate policy—or supplies only an allowed list—this condition emits no corresponding override, even though extract.sh reads anchor_allowed. The generated guidance therefore continues telling agents that the language is forbidden, contradicting the repo-specific anchor; include allowed entries in the override and emit it when either list is nonempty.
Useful? React with 👍 / 👎.
| dependency's whole import cone compiles under the prover's safe mode with zero | ||
| postulates, it is *checked, not assumed*: record the cone (root module, flags, | ||
| postulate count of zero, library name, version and pin) instead of an | ||
| `ASSUMED` row (policy §1.1). A cone with a postulate, or compiled outside safe |
There was a problem hiding this comment.
Synchronize the proof guide's dependency exception
When a dependency's import cone passes the new safe-mode/zero-postulate rule, this generated guidance tells agents to record it as checked rather than ASSUMED, but verification/proofs/README.adoc still requires every relied-on dependency to be recorded as ASSUMED. Since the generated section explicitly directs agents to that README as the repo-specific mapping, the two authoritative instructions now produce conflicting proof-status records; update the guide and its governance assertions with the same exception.
Useful? React with 👍 / 👎.
| # This repo: `%{data.canonical_name}` | ||
|
|
||
| - **Identity** — uuid `%{data.uuid}`; clade `%{data.clade_primary}` (secondary `%{data.clade_secondary}`); born %{data.born}; forge `%{data.forge_gh}`. | ||
| - **Identity** — chora id `%{data.uuid}`; clade: %{data.clade_aid}; born %{data.born}; forge `%{data.forge_gh}`. |
There was a problem hiding this comment.
Do not label a legacy literal as the chora id
For this repository, data.uuid is #u8"gv-clade-index:github.com/hyperpolymath/bactrian", which scripts/deed-field.sh explicitly treats as a legacy computed literal rather than the opaque #uuid"…" chora id minted from the birth path. The generated arrival pack now calls that legacy value the chora id, so agents can use the wrong identifier for repository identity; migrate the deed first or distinguish legacy literals in the rendered label.
Useful? React with 👍 / 👎.



Summary
The template now generates the
## Proofsblock inside the arrival-pack region (hyperpolymath/rsr-template-repo#413), with the PROOF-POLICY §1.1 and §8.1 wording fixes from hyperpolymath/rsr-template-repo#400. This carries that engine here and regeneratesCLAUDE.md.Owner decision by selector, 2026-11-15.
Changes
.machine_readable/arrival-pack/arrival-pack.nclandextract.sh: copied from the template at894038e.CLAUDE.md: regenerated. The hand-authored Proofs copy below the region (older wording) is removed, so the block appears once.tests/workflows/governance_policy_test.sh: the template's version, which asserts the Proofs block is inside the generated region. The old version asserts the opposite and fails after this change.Regenerating also brings the template's newer estate-common text: the kyq data-format paragraph in Canon pointers, the chora-registry wording, a reworded Identity line (the id itself is unchanged), and an "Anchor override" line read from this repo's own deed (Node.js, npm). Please check that last line is true for this repo.
scripts/deed-field.shis deliberately not upgraded: the existing copy is enough for the new engine, and upgrading it would also need a neweruuid_v8_test.sh.RSR Quality Checklist
Required
just test) — not run locally. Left to CI..envfiles includedTesting
bash .machine_readable/arrival-pack/verify.sh→ in sync with the deed.tests/run before and after: no result changed. The same 3 fail both times in the session container (check_adoc_renders_test,julia_library_test,ffi_strings_test); not investigated, not caused by this change.Generated by Claude Code