Repository navigation
fix(ci): move the Hypatia pin from be98f74 to the template's 6693f9a - #38
Conversation
The Hypatia scan crashes with a segmentation fault (exit 139) at be98f74 (bactrian#37, run 43705667451). be98f74 predates hypatia#1062 (37b8d01), which stops a BEAM miscompile of Hypatia.Rules.PinSites.walk/4 that crashes the VM in garbage collection. This run crashed on OTP 27.3.4.19, so the OTP 27 pin in hypatia-scan.yml does not avoid it. All six be98f74 sites move to 6693f9a, the pin rsr-template-repo main uses at the same sites. 6693f9a contains 37b8d01. The dogfood-gate checkout stays at 51539ab, as in the template. Checks: scripts/check-hypatia-rule-order.sh, scripts/check-workflow-edges.sh, tests/workflows/verdict_grid_test.sh (197 checks) all pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZkGCWGEyedTtdEHAPT
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
🟢 clean · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 22 (22 reporter observations; 21 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: 4 finding(s)
panic-attack assail: 18 finding(s)
pons asinorum: 9 finding(s)
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): 11 finding(s)
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): 88 finding(s)
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): 177 finding(s)
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |



What
All six
be98f74Hypatia pin sites move to6693f9a, the pin rsr-template-repomainuses at the same sites:hypatia-scan.yml(HYPATIA_SHA)fork-governance.ymlandverdict-grid-publish.yml(--hypatia-ref).machine_readable/policies/hypatia-rule-order.json(scanner.commit)docs/HYPATIA-RULE-ORDER.adoctests/workflows/verdict_grid_test.shThe
dogfood-gate.ymlcheckout stays at51539ab, as in the template. That commit already contains the fix.Why
Hypatia Neurosymbolic Analysisfails on #37 with a segmentation fault: run 43705667451,hypatia-cli.sh scan, exit 139.be98f74predates hypatia#1062 (37b8d01). The BEAM compiler miscompilesHypatia.Rules.PinSites.walk/4: an in-place binary append on a string that is still referenced makes the VM crash in garbage collection. #1062 turns that optimisation off for that module.6693f9acontains37b8d01.This run crashed on OTP 27.3.4.19, so the OTP 27 pin in
hypatia-scan.ymldoes not avoid the crash. #1062 had recorded OTP 27 as unaffected.The crash comes from
main's pins, so the fix belongs onmain. #37 picks it up oncemainis merged into it.Evidence
git merge-base --is-ancestor 37b8d01 6693f9a: true.scripts/check-hypatia-rule-order.shpasses: 7 layers, 8 concerns, 8 clashes, 2 modules.scripts/check-workflow-edges.shpasses: all workflow edges resolve.tests/workflows/verdict_grid_test.sh:PASS: verdict grid lane suite (197 checks).Not done
upload-sarifpin,FLEET_REF, a guard onfork-governance.ymlline 327, and doc wording.6693f9ain four places,51539abindogfood-gate.yml). That belongs in rsr-template-repo.Generated by Claude Code