Repository navigation
feat(doctor): probe the ECHIDNA coprocessor contract #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+209
−1
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5ed7c1e
feat(doctor): probe the ECHIDNA coprocessor contract (optional hint row)
HoTT-stuff 7c67025
fix(doctor): mark the coprocessor row [optional]
HoTT-stuff 3b3dc5a
test(doctor): link timeout only when it exists
HoTT-stuff df8fa21
fix(doctor): do not run the coprocessor probe without timeout
HoTT-stuff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validate JSON fields instead of matching substrings.
If the actual
outcomeis{"BigInt":"7"}, an additionaldetail.outcomecontaining{"BigInt":"6"}satisfies Line 130. With the other expected substrings present, the probe reportspresentfor the wrong GCD.Canonical formatting does not prevent this match. The upstream contract permits additional fields and places the proof flag at
trust.proof. (raw.githubusercontent.com)Parse the JSON and check the intended
schema,status,outcomeandtrust.prooffields. Update the success fixture to usetrust.proof.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decision (coordinator session): the substring checks stay, with no
jq. Reasons, now also in a code comment in df8fa21:"proof":trueor"proof":falsecan only be a key with its value, never part of a message string."proof":trueanywhere in the line gives drift, so a result is never reported present with a true proof flag.falsesits undertrust, and an additive contract change can cause a false drift report on this optional row. Your{"BigInt":"7"}plus extradetail.outcomecase is a real, unlikely gap of this kind.The shared client in the evidence kit will parse the JSON; this pilot stays dependency-free. On naming:
trust.proofis the keyproofinside the objecttrust, so"proof":falsein the line is the same field. The coordinator confirmed this against the real binary: the line contains"trust":{"proof":false,"rank":3,"tier":"LibraryWrapped"}. This thread stays open for the owner to read.Generated by Claude Code