Skip to content

fix(ci): restore release.yml's slsa-github-generator entries in actions.lock - #385

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/actions-lock-slsa
Nov 14, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/actions-lock-slsa

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

governance is red on main, and it was red on #384 for the same reason.

Dependabot's #379 regenerated .github/workflows/actions.lock and dropped the entries that #368 had added by hand for release.yml's job-level reusable workflow, slsa-framework/slsa-github-generator@f7dd8c54… (v2.1.0). gh actions-lock does not handle job-level reusable-workflow refs, so they have to be added by hand. CI's check-lock-sync reports:

FAIL .github/workflows/release.yml
     refs missing from the lockfile: slsa-framework/slsa-github-generator@f7dd8c54c2067bafc12ca7a55595d5ee9b75204a

Changes

The entries are restored byte for byte from #368's lock (282df49), as additions only and in the lock's own key order:

  • the release.yml workflow edge;
  • the dependency records it closes over:
    • the generator, at its SHA and at v2.1.0;
    • its transitive actions/upload-artifact@65c4c4a1… (v4.6.0);
    • its transitive softprops/action-gh-release@c95fe148… (v2.2.1).

No workflow changes.

Verification

Run with the standards tools at the commit governance.yml pins (1725beb):

  • main: check-lock-sync.sh fails with the error above.
  • this branch: check-workflows-parse.sh, check-lock-sync.sh, close-lock.sh --check and check-workflow-duplicate-keys.sh all pass.

Note

Dependabot's lock rewrite will drop these entries again the next time it touches release.yml's neighbours. A lasting fix belongs in the lock tooling, not here.


Generated by Claude Code

…ns.lock

The governance check is red on main. Dependabot's #379 regenerated
actions.lock and dropped the hand-added entries that #368 had put back
for release.yml's job-level reusable workflow,
slsa-framework/slsa-github-generator@f7dd8c54 (v2.1.0). gh actions-lock
does not handle job-level reusable-workflow refs. check-lock-sync now
fails:

  FAIL .github/workflows/release.yml
       refs missing from the lockfile:
       slsa-framework/slsa-github-generator@f7dd8c5

GitHub refuses such a run at startup (zero jobs). This restores, byte for
byte from #368's lock (282df49), the release.yml workflow edge and the
four dependency records it closes over: the generator at the SHA and at
v2.1.0, and its transitive actions/upload-artifact@65c4c4a1 and
softprops/action-gh-release@c95fe148. Additions only, in the lock's own
key order. No workflow changes.

Verification, with the standards tools at the commit governance.yml pins
(1725beb): on main, check-lock-sync fails with the error above. On this
branch, check-workflows-parse, check-lock-sync, close-lock --check and
check-workflow-duplicate-keys all pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

  • .github/workflows/actions.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8bb681da-478e-437d-8fd3-d45f670c955a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@linear-code
linear-code Bot marked this pull request as ready for review November 14, 2026 20:54
@github-actions

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 68 issues detected

Severity Count
🔴 Critical 1
🟠 High 11
🟡 Medium 56

⚠️ Action Required: Critical security issues found!

View findings (sorted by severity)
[
  {
    "line": 70,
    "reason": "believe_me undermines formal verification (4 occurrences, CWE-704, line 70, 269, 279, 289)",
    "type": "believe_me",
    "file": "/home/runner/work/boj-server/boj-server/src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_safety",
    "action": "flag",
    "severity": "critical",
    "evidence": [
      {
        "span": {
          "file": "/home/runner/work/boj-server/boj-server/src/abi/Boj/SafetyLemmas.idr",
          "end_line": 70,
          "start_line": 70
        },
        "rule": "code_safety/believe_me",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Step uses `peter-evans/repository-dispatch` with `token: ${{ secrets.FARM_DISPATCH_TOKEN }}` but has no `if: secrets.FARM_DISPATCH_TOKEN != ''` gate. On repos where the secret hasn't been propagated the action fails on every push, red-maining the repo. Add the step-level gate (or env+if pattern) so the missing-secret path is a clean skip instead of a red.",
    "type": "secret_action_without_presence_gate",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "workflow_audit",
    "action": "peter-evans/repository-dispatch",
    "severity": "high",
    "fix_recipe": "add_secret_presence_gate",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "workflow_audit/secret_action_without_presence_gate",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 29,
    "reason": "job `deploy` in .github/workflows/pages-deploy.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring; it holds the credential next to fetched code (a piped installer or a dependency install/build) in the same step",
    "type": "RE001",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 29,
          "start_line": 29
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code scanning (Hypatia): hypatia/workflow_audit/secret_action_without_presence_gate -- Hypatia workflow_audit: secret_action_without_presence_gate -- 41 day(s) old [STALE]",
    "type": "CSA001",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code scanning (Hypatia): hypatia/code_safety/believe_me -- Hypatia code_safety: believe_me -- 44 day(s) old [STALE]",
    "type": "CSA001",
    "file": "src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "src/abi/Boj/SafetyLemmas.idr",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/proofs.yml is 33 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/proofs.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/proofs.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/workflow_audit/secret_action_without_presence_gate (high) at .github/workflows/instant-sync.yml is 41 days old (threshold: 7 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/workflow_audit/missing_timeout_minutes (medium) at .github/workflows/pages-deploy.yml is 41 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/code_safety/zig_bit_cast (medium) at ffi/zig/src/cartridge_shim.zig is 44 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": "ffi/zig/src/cartridge_shim.zig",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "ffi/zig/src/cartridge_shim.zig",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/code_safety/believe_me (high) at src/abi/Boj/SafetyLemmas.idr is 44 days old (threshold: 7 days) -- overdue for remediation",
    "type": "CSA003",
    "file": "src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "src/abi/Boj/SafetyLemmas.idr",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/push-email-notify.yml is 54 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/push-email-notify.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/push-email-notify.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/dogfood-gate.yml is 54 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/dogfood-gate.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/dogfood-gate.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Job `deploy` in pages-deploy.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
    "type": "missing_timeout_minutes",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "workflow_audit",
    "action": "flag",
    "severity": "medium",
    "recipe_id": "recipe-add-workflow-timeout-minutes",
    "job": "deploy",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "workflow_audit/missing_timeout_minutes",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 44,
    "reason": "job `build-and-push` in .github/workflows/container-publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/container-publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/container-publish.yml",
          "end_line": 44,
          "start_line": 44
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 37,
    "reason": "job `sonarqube` in .github/workflows/build.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/build.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/build.yml",
          "end_line": 37,
          "start_line": 37
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 88,
    "reason": "job `publish-bun` in .github/workflows/publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/publish.yml",
          "end_line": 88,
          "start_line": 88
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 122,
    "reason": "job `publish-jsr` in .github/workflows/publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/publish.yml",
          "end_line": 122,
          "start_line": 122
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 34,
    "reason": "job `dispatch` in .github/workflows/instant-sync.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 34,
          "start_line": 34
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 278,
    "reason": "job `scan` in .github/workflows/hypatia-scan.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring; it holds the credential next to fetched code (a piped installer or a dependency install/build)",
    "type": "RE001",
    "file": ".github/workflows/hypatia-scan.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/hypatia-scan.yml",
          "end_line": 278,
          "start_line": 278
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 46,
    "reason": "job `notify` in .github/workflows/push-email-notify.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/push-email-notify.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/push-email-notify.yml",
          "end_line": 46,
          "start_line": 46
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 38,
    "reason": "workflow .github/workflows/fuzz.yml:38 step `Run core FFI fuzz tests` swallows non-zero exit via `continue-on-error: true` AND `|| true` — failures will be masked",
    "type": "RE005",
    "file": ".github/workflows/fuzz.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/fuzz.yml",
          "end_line": 38,
          "start_line": 38
        },
        "rule": "research_extensions/RE005",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 224,
    "reason": "workflow .github/workflows/abi-drift.yml:224 step `Scope cartridges to verify` swallows non-zero exit via `|| true` — failures will be masked",
    "type": "RE005",
    "file": ".github/workflows/abi-drift.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/abi-drift.yml",
          "end_line": 224,
          "start_line": 224
        },
        "rule": "research_extensions/RE005",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 22,
    "reason": "workflow .github/workflows/pages-deploy.yml:22 job `deploy` has no `timeout-minutes:` — defaults to 360 min on hang",
    "type": "WH006",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "workflow_hardening",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 22,
          "start_line": 22
        },
        "rule": "workflow_hardening/WH006",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 175,
    "reason": "Zig @bitCast reinterprets bits without type checking (1 occurrences, CWE-704, line 175)",
    "type": "zig_bit_cast",
    "file": "/home/runner/work/boj-server/boj-server/ffi/zig/src/cartridge_shim.zig",
    "level": "epi",
    "rule_module": "code_safety",
    "action": "flag",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": "/home/runner/work/boj-server/boj-server/ffi/zig/src/cartridge_shim.zig",
          "end_line": 175,
          "start_line": 175
        },
        "rule": "code_safety/zig_bit_cast",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 58,
    "reason": "Secret found: Generic API key (placeholder-shaped value — verify it is not a real credential)",
    "type": "secret_detected",
    "file": "/home/runner/work/boj-server/boj-server/tools/cartridge-provisioner/README.adoc",
    "level": "epi",
    "rule_module": "security_errors",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": "/home/runner/work/boj-server/boj-server/tools/cartridge-provisioner/README.adoc",
          "end_line": 58,
          "start_line": 58
        },
        "rule": "security_errors/secret_detected",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@hyperpolymath
hyperpolymath merged commit d84b50c into main Nov 14, 2026
45 checks passed
@hyperpolymath
hyperpolymath deleted the fix/actions-lock-slsa branch November 14, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants