Skip to content

docs(cutover): record the 2026-11-13/14 rulings; D4 superseded - #675

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/cutover-rulings-2026-11-14
Nov 14, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/cutover-rulings-2026-11-14

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

What this is

Design only: docs/migrations/scanner-cutover-ponsbot-panicbot.adoc. No workflow, enrolment or code change.

Recorded

  • D2 (2026-11-14): phase 1 shadow runs 14 days; evidence-text differences acceptable, verdict differences not.
  • D3 (2026-11-14): pre-push default becomes panicbot ponsbot hypatia.
  • D4 superseded (2026-11-14): panicbot is the bot harness for panic-attack. It must still run as a plain scanner, but as a bot it should be self-contained, so it gains an optional bridge mode and estate-rescan and bridge-gate move behind it in phase 5. The owner's answer did not name the bridge mode, so this reading is mine: please confirm in review.
  • R14 (relayed): finishingbot is retired or re-pointed at the deed (D312). Design not yet written; recorded as pending.
  • Authority and ownership (relayed 2026-11-13): bots/*/canon/pin.toml is the pin authority; propagate-sha-bump.sh owns standards reusable pins; the cutover thread owns the two scanner lanes; one auto-merge actuator.

D5 and D6 were already settled in the doc; nothing changed there.

Not done

Phase 1 itself (standards enrolment) is a separate PR.



Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the migration plan to reflect completed adapter work and the next phase.
    • Clarified that bridge mode is optional, with standard scanning operating independently.
    • Specified a 14-day shadow period requiring matching verdicts, while allowing evidence text to differ.
    • Updated the pre-push default and documented ownership and review status for the cutover and bridge mode.

Design only. D2 (14-day shadow), D3 (full pre-push set), the superseded D4
(panicbot gets an optional bridge mode; estate-rescan and bridge-gate move
behind it in phase 5), R14 (finishingbot re-point, design not yet written)
and the authority/ownership rulings are recorded. No workflow, enrolment or
code change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZkEdznGjgTixZgjhB6
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The migration document records phase 0 as landed and updates phase 5 with optional panicbot bridge requirements. It also sets the shadow period and pre-push default, and records pin, cutover, and auto-merge ownership.

Changes: Scanner cutover migration

Layer / File(s) Summary
Phase status and bridge requirements
docs/migrations/scanner-cutover-ponsbot-panicbot.adoc
The document marks phase 0 as landed and phase 1 as next. It places Hypatia’s estate rescan and bridge gate behind panicbot’s optional bridge mode in phase 5. Exit criteria require tested bridge mode, unchanged verisim-data shape, and standard scanning that works without bridge mode.
Cutover rulings and ownership
docs/migrations/scanner-cutover-ponsbot-panicbot.adoc
The document sets a 14-day shadow period, allows evidence-text differences while blocking phase 2 on verdict differences, and sets the pre-push default to panicbot ponsbot hypatia. It records pin, cutover, and auto-merge ownership, and leaves bridge-mode review as the remaining open item.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Low · up to 6b090

This documentation update records the cutover rulings. Phase 5 does not yet say which command bridge mode runs for the estate rescan that feeds verisim-data. Clarify this before phase 5 work starts; it does not block merging the document.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 14, 2026 14:07
@hyperpolymath
hyperpolymath merged commit b97e4e1 into main Nov 14, 2026
66 checks passed
@hyperpolymath
hyperpolymath deleted the docs/cutover-rulings-2026-11-14 branch November 14, 2026 14:07
@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T14:11:57.343849Z 6b09039 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b0903946c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


=== 8.3 Decided (owner rulings, 2026-11-14)

D2. **Decided 2026-11-14.** The phase 1 shadow period runs **14 days**. A

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align phase 1 with the 14-day shadow period

This ruling makes elapsed time the phase 1 boundary, but the phase table still says to shadow for a fixed number of PRs and evaluate an agreed sample. When PR volume is unusually high or low, following that table can advance phase 2 before 14 days or prolong the shadow past the decided period. Update the phase 1 change and exit criterion to require the full 14 days.

Useful? React with 👍 / 👎.

Comment on lines +309 to +310
D4 (superseded). **Superseded 2026-11-14** (D4 of 2026-11-13 stood for one
day). The owner's reasoning: panicbot is the harness that lets panic-attack

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mark the replacement D4 as superseding

This paragraph contains the operative 2026-11-14 decision, yet its heading labels that decision itself “superseded”; the old 2026-11-13 D4 is already correctly marked superseded in §8.2. A phase 5 implementer can therefore read the bridge plan as withdrawn. Label this entry as revised/superseding and reserve “superseded” for the prior D4.

Useful? React with 👍 / 👎.

Comment on lines +313 to +316
be self-contained as far as it can be. Consequence: panicbot gains an
*optional* `bridge` mode (a thin subprocess call to `panic-attack bridge
triage`, same pin, same envelope discipline as `scan`). Hypatia's estate
rescan and bridge gate move behind panicbot in phase 5 instead of staying

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Define an adapter path for the estate rescan

The optional mode described here only invokes panic-attack bridge triage, so it cannot replace the estate rescan, which §2.2 identifies as an assail run feeding verisim-data. The existing panicbot scan path emits translated fleet findings rather than the raw report consumed by that pipeline, while phase 5 requires the verisim-data shape to remain unchanged. Specify a separate raw estate-rescan mode or leave that use direct instead of moving both workflows behind the bridge mode.

Useful? React with 👍 / 👎.

Comment on lines +329 to +331
* Pin authority: `bots/*/canon/pin.toml` in gitbot-fleet. Standards reusable
pins are owned by `propagate-sha-bump.sh` with the closure audit, and
Dependabot handles third-party actions only. The pin change in standards is

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Assign scanner-pin updates to a capable mechanism

For phase 1 and subsequent re-pins, this assigns the scanner pins copied into standards workflows to propagate-sha-bump.sh, but that script only handles reusable_workflow_sha_bump_needs_propagation findings and dispatches updates to consumers whose uses: reference contains an old reusable-workflow SHA; it never edits standards' internal panic-ref, pons-ref, or scanner revision values. Following this authority statement therefore leaves those copies stale relative to bots/*/canon/pin.toml; name or add the mechanism that actually synchronizes the scanner pins.

Useful? React with 👍 / 👎.

Comment on lines +340 to +342
=== 8.5 Open

None for phases 0 to 4. The bridge mode of 8.3 D4 is open to review.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the unresolved phase 2 and 3 choices open

The claim that phases 0–4 have no open questions contradicts two unresolved choices earlier in this document: §5 still says to decide how counts_excluded is preserved before the direct row is removed, and §4 says phase 3 must choose between native adapter SARIF and a conversion step. Treating these as closed can let phases 2 or 3 proceed without preserving their existing output contracts, so list them here or settle them explicitly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants