Repository navigation
fix(panicbot): carry unsuppressed test-code findings, as the direct lane does - #677
Conversation
…ane does First shadow run (standards#1562): the direct panic-attack row read critical in a changed test script; panicbot read clean. Same binary, same tree. Of 75 weak points, 51 are production, 6 test_only (not suppressed) and 18 test_only (suppressed). The direct lane keeps the first 57; panicbot dropped the test_only ones, so it reported 51. Owner ruling 2026-11-14: carry them at full severity. translate_all now drops only what panic-attack itself suppressed; test_context is recorded in the finding metadata. Against the real tree panicbot now reports 57, equal to the direct lane. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZkEdznGjgTixZgjhB6
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
…adow fixes (#1567) ## What this is Follow-up to #1562 (phase 1 shadow enrolment). One line: `FLEET_REF` in `.github/workflows/fork-governance.yml` goes from `7fc27784` to gitbot-fleet `14892a53`, which includes the two fixes the first shadow run exposed: - hyperpolymath/gitbot-fleet#676: ponsbot accepts the `source_dirty: "true"` stamp that a `cargo install --git --rev` pons carries on the exact pinned commit. Before it the ponsbot row read orange (`error: pons was built from a dirty tree`). - hyperpolymath/gitbot-fleet#677: panicbot carries unsuppressed test-code findings at full severity, as the direct lane does. Before it panicbot reported 51 findings and read clean where the direct row read critical (57 findings). No line moves, so the line-keyed code-scanning dismissal for `fork-governance.yml` is unaffected (checked: `security-events: write` stays at line 289). ## What to check The Hypatia grid on this PR's own run is the first shadow comparison with both fixes: panicbot should report the same count as the `panic-attack assail` row, and ponsbot should read a real result (not orange), both advisory. --- --- _Generated by [Claude Code](https://claude.ai/code/session_0136P7ZkEdznGjgTixZgjhB6)_ Co-authored-by: Claude <noreply@anthropic.com>



What this is
Second finding from the phase 1 shadow (standards#1562, run 43602190815): the direct panic-attack row read critical in a changed test script, panicbot read clean.
Root cause (measured)
Same panic-attack binary (410a8f8, built locally), same tree. Both invocations (
assail . --outputandassail . --headless) give byte-identical output, so the invocation is not the cause. Of 75 weak points: 51production, 6test_onlynot suppressed, 18test_onlysuppressed. The direct lane keeps 51 + 6 = 57; panicbot'stranslate_alldropped everytest_only/docfinding, so it reported 51. The 6 include the criticalevalinscripts/tests/dismiss-code-scanning-alerts-test.sh.Change (owner ruling 2026-11-14: carry at full severity)
translate_alldrops only what panic-attack itself suppressed. Unsuppressedtest_only/docfindings are carried at their own severity, withtest_contextin the finding metadata. Tests updated: carries unsuppressed test_only and doc, still drops suppressed.Verified
assailnow reports 57 findings (was 51), equal to the direct lane.cargo test --lockedinbots/panicbotall pass (107 unit + integration),cargo fmt --checkandcargo clippy --locked --all-targets -- -D warningsclean.tests/fleet-report-back-test.sh: 212 passed, 0 failed (also withSTANDARDS_DIRset, build test 69 passed). With a real panic-attack on PATH two tests fail; that setup is not what the suite assumes.Not verified
A live CI shadow run. After this and #676 merge, standards'
FLEET_REFneeds bumping; the next shadow run is the test.Generated by Claude Code
Summary by CodeRabbit