Skip to content

fix(rhodibot): take the rsr-profile key set from standards' module - #682

Merged
hyperpolymath merged 1 commit into
mainfrom
rhodibot/rsr-profile-keys-from-module
Nov 15, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
rhodibot/rsr-profile-keys-from-module

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

Follow-up to #678. standards#1605 (merged 2026-11-15 10:39 UTC) defines the (rsr-profile ...) key set; this makes rhodibot's reader match it, as A7 asked.

Changes (bots/rhodibot/src/deed.rs, tests only otherwise)

  • Key set is now exactly :version :spec :declares-against :role :preset :capabilities :add :remove (RSR_PROFILE_KEYS), matching bun 1-formats/deed/tools/deed_lint.js --rsr-profile-keys at standards 10:39 UTC. (notes …) is the one nested clause and is not scanned.
  • Dropped the keys fix(rhodibot): stop demanding A2ML; make CONTRIBUTING/CODE_OF_CONDUCT .adoc|.md toggleable #678 had added for other clauses: :policy (belongs to (anchor …) and (egress …)), :omitted-rationale (belongs inside (notes …)), and :schema-version. Any other top-level key still fails closed.
  • :capabilities, :add and :remove must be lists of strings; symbols are now refused, as the module requires.

A7 confirmed the real template conforms (deed_lint.js --rsr-profile passes on rsr-template-repo main), so this should not change rhodibot's result on the template. I have not re-run rhodibot against the template myself; SysArch's driver run would confirm.

Tests

cargo test in bots/rhodibot passes (172 + 11 + 58 + 1); cargo fmt and cargo clippy --all-targets clean. New tests pin the key set, the refused keys, :omitted-rationale inside (notes …), and string-only lists. The verbatim standards clause test still passes.

Not done here

Left for A7's follow-up PR to #1605 (does not change the key set): empty :capabilities with no :preset refused, (notes …) fields once each, profile only on *_chora.deed. Rhodibot still accepts an empty :capabilities until that is ruled.


Generated by Claude Code

standards#1605 defines (rsr-profile ...) keys as :version :spec
:declares-against :role :preset :capabilities :add :remove, with (notes ...)
as the one nested clause (`deed_lint.js --rsr-profile-keys`). Drop the keys
rhodibot had added for other clauses (:policy belongs to (anchor ...) and
(egress ...), :omitted-rationale to (notes ...), :schema-version to none), and
refuse symbols in :capabilities/:add/:remove, which the module requires to be
strings. Tests pin the set, the refused keys, notes, and string-only lists.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmM7wgb8pXfyFEuRHQ
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 15, 2026 10:44
@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 15, 2026 10:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T10:46:07.325372Z af179f1 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-15T10:46:58.924486Z af179f1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath merged commit c996a60 into main Nov 15, 2026
70 of 71 checks passed
@hyperpolymath
hyperpolymath deleted the rhodibot/rsr-profile-keys-from-module branch November 15, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants