Repository navigation
fix(rhodibot): take the rsr-profile key set from standards' module - #682
Merged
Merged
Conversation
standards#1605 defines (rsr-profile ...) keys as :version :spec :declares-against :role :preset :capabilities :add :remove, with (notes ...) as the one nested clause (`deed_lint.js --rsr-profile-keys`). Drop the keys rhodibot had added for other clauses (:policy belongs to (anchor ...) and (egress ...), :omitted-rationale to (notes ...), :schema-version to none), and refuse symbols in :capabilities/:add/:remove, which the module requires to be strings. Tests pin the set, the refused keys, notes, and string-only lists. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZmM7wgb8pXfyFEuRHQ
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
hyperpolymath
marked this pull request as ready for review
November 15, 2026 10:44
hyperpolymath
enabled auto-merge (squash)
November 15, 2026 10:44
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Follow-up to #678. standards#1605 (merged 2026-11-15 10:39 UTC) defines the
(rsr-profile ...)key set; this makes rhodibot's reader match it, as A7 asked.Changes (
bots/rhodibot/src/deed.rs, tests only otherwise):version :spec :declares-against :role :preset :capabilities :add :remove(RSR_PROFILE_KEYS), matchingbun 1-formats/deed/tools/deed_lint.js --rsr-profile-keysat standards 10:39 UTC.(notes …)is the one nested clause and is not scanned.:policy(belongs to(anchor …)and(egress …)),:omitted-rationale(belongs inside(notes …)), and:schema-version. Any other top-level key still fails closed.:capabilities,:addand:removemust be lists of strings; symbols are now refused, as the module requires.A7 confirmed the real template conforms (
deed_lint.js --rsr-profilepasses on rsr-template-repo main), so this should not change rhodibot's result on the template. I have not re-run rhodibot against the template myself; SysArch's driver run would confirm.Tests
cargo testinbots/rhodibotpasses (172 + 11 + 58 + 1);cargo fmtandcargo clippy --all-targetsclean. New tests pin the key set, the refused keys,:omitted-rationaleinside(notes …), and string-only lists. The verbatim standards clause test still passes.Not done here
Left for A7's follow-up PR to #1605 (does not change the key set): empty
:capabilitieswith no:presetrefused,(notes …)fields once each, profile only on*_chora.deed. Rhodibot still accepts an empty:capabilitiesuntil that is ruled.Generated by Claude Code