Repository navigation
fix(dispatch-runner): give the predicate verdict to Hypatia, and record no_op and unverified (E0-02) - #683
Merged
Conversation
…rd no_op and unverified (E0-02) The runner collapsed each verdict to an outcome and made no call for no_op and unverified, so Hypatia never saw an attempt that fixed nothing. Hypatia's `mix hypatia.record_outcome` now takes --verdict (hypatia E0-01), and stores no_op and unverified as audit rows that carry no credit. The runner learns once per run whether Hypatia knows the option, from the help text of the task and never from an exit code: a Hypatia from before E0-01 ignores an option that it does not know, so a no_op call would be recorded as a success. * Hypatia names --verdict: each of the 5 verdicts is passed with the outcome of the pair table (success for no_op and unverified), and no_op and unverified are recorded. A refusal passes no verdict. * An older Hypatia: no --verdict and no call for no_op or unverified, exactly the calls that the runner made before (checked against the previous script). * The help command fails: the run stops with a visible error. A Hypatia that does not answer is not an older Hypatia. * One line per run says which mode it uses. The automation quarantine (exit 78, before the manifest) and the licence refusal gate are not changed. tests/outcome-verdict-test.sh gets a stub mix on PATH for the 4 cases: 60 checks. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
hyperpolymath
marked this pull request as ready for review
November 15, 2026 18:26
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
scripts/dispatch-runner.shgives its predicate verdict tomix hypatia.record_outcome --verdict, and the call forno_opandunverifiedis no longer skipped. The automationquarantine and the licence refusal gate do not change.
Work order: E0-02 (
hyperpolymath/hypatia,docs/operations/e0-closeout/work-orders/).Depends on hypatia E0-01 (merged). Related: gitbot-fleet #647; hypatia #984, acceptance A3, A5.
Why
The runner collapsed each verdict to an outcome and made no call for
no_opandunverified, soHypatia never saw an attempt that fixed nothing. Hypatia now takes
--verdictand stores thosetwo as audit rows that carry no credit.
The change
hypatia_detect_verdict_mode: learns once per run whether Hypatia knows--verdict, frommix help hypatia.record_outcomeand never from an exit code. A Hypatia from before E0-01ignores an unknown option, so a
no_opcall would be recorded as a success.verdict: each of the 5 verdicts is passed with the outcome of the pair table (success forno_opandunverified), and those two are recorded. A refusal passes no verdict.legacy: no--verdict, and no call forno_oporunverified: the calls the runner madebefore.
off: no calls (reporting off, no checkout, or nomix).older Hypatia.
hypatia_detect_verdict_mode || exit 1, placed afterrecord_outcomeand afterexit 78, so the quarantine still ends the run before the manifest.Evidence
tests/outcome-verdict-test.sh: 60 checks, 0 failures (it had 43; before the change the 17 newones failed because the function did not exist). A stub
mixonPATHrecords its arguments andanswers
helpas each case needs: knows--verdict(all 5 verdicts, outcome and verdict checked),an older Hypatia, a failing help, and reporting off.
tests/automation-quarantine-test.shpasses with no change to that file;tests/hypatia-record-outcome-smoke.shpasses;exit 78is still at line 152, before the new call.the new one in legacy mode, and the 4
mixcalls are identical.mainof hypatia,MIX_ENV=test,HOMEredirected sonothing touched
~/Documents): detection gaveverdict;no_op,unverifiedandfailedwerestored as
verificationno_op, unverified and failed; the real gate countedignored: 2, successes: 0, failures: 1. I removed the rows I created.--verdictpassed in every mode (1 check fails); no_op/unverifiedrecorded for an older Hypatia (2); the option never learned from the help (8); the run does not
stop when help fails (1); a failing help treated as an older Hypatia (3).
Not done, and limits
takes effect only when the quarantine is lifted. The tests extract the runner's functions, as the
existing ones do.
--pattern-idand no--match-kindto Hypatia. Hypatia's E0-18 can nowrecord both; wiring them from the manifest entry is a separate change.
HYPATIA_VERISIM_DATA_PATHisrefused by Mix's
compile_envcheck unless it equals the compile-time path. Anyone who redirectsthe store for a test will hit it.
Process notes
token as hypatia.
at high effort; I did not choose that. Cost: unknown to me; please read it in the Anthropic Console.