Skip to content

ci: aggregate mandatory jobs as CI/gate - #685

Merged
hyperpolymath merged 1 commit into
mainfrom
codex/required-ci-gate-20261116
Nov 16, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
codex/required-ci-gate-20261116

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

The active Branch-Floor ruleset requires CI/gate, but no workflow emits that check. Add a gate to the primary Rust CI workflow which waits for the complete Rust matrix, dispatch contracts and GSBot build/test/dependency audit. All dependency results must be success; failure, cancellation, skipping, missing or unexpected results fail. The gate runs after unsuccessful dependencies and needs no token permissions.

Validation: the actual extracted scripts from this and Hypatia #1181 pass 85 execution controls, including malformed/missing results and every non-success dependency state. Dependency closure confirms that each gate lists every other job in its workflow. Bash syntax, ShellCheck, actionlint and canonical lock sync pass. No action references, vendor lock entries or source-attestation records change.

The branch rules and coverage thresholds are preserved. This aggregates primary CI; separate source-attestation, E2E, governance and security checks remain. Native coverage-upload integration and an 80% coverage claim are not established by this change.

Summary by CodeRabbit

  • Chores
    • Added a CI status check that fails unless the Rust, dispatch-contracts, and GSBot checks all succeed. Missing or unsuccessful results also fail the check.
  • Documentation
    • Documented which checks the CI gate aggregates and how it handles unsuccessful results. Clarified that it does not change branch rules or coverage thresholds.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T10:15:03.288403Z afaa22b PR opened
🔒 Security Review ✅ Completed 2026-11-16T10:16:10.316421Z afaa22b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Rust workflow adds a CI/gate job that checks the results of rust, dispatch-contracts, and gsbot. Documentation describes the gate’s failure conditions, permissions, and relationship to other checks and coverage settings.

Changes: CI Gate

Layer / File(s) Summary
Gate aggregation and result rules
.github/workflows/rust.yml, docs/REQUIRED-CI-GATE.adoc
The workflow adds a five-minute job that fails if any dependency result is not success. The documentation describes these result rules, the gate’s lack of token-permission requirements, and its scope.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to afaa2

This adds the CI/gate check that the branch ruleset requires. The check is emitted for every pull request and fails unless the Rust, dispatch-contract, and GSBot jobs all succeed. No concrete defects were found, and the change is low risk to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: aggregate mandatory jobs as CI/gate" matches the main change. The PR adds a CI/gate job to rust.yml that aggregates the rust, dispatch-contracts, and gsbot jobs and fails when any depen…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: aggregate mandatory jobs as CI/gate" matches the main change. The PR adds a CI/gate job to rust.yml that aggregates the rust, dispatch-contracts, and gsbot jobs and fails when any dependency is not successful. It also adds docs/REQUIRED-CI-GATE.adoc. The title is specific and concise, and it uses the same conventional-commit style as the other titles. It does not mention the documentation file, which is a minor detail and not required.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 7cc3144 and afaa22b.

Files selected for processing: 2

  • .github/workflows/rust.yml
  • docs/REQUIRED-CI-GATE.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit da1ccf2 into main Nov 16, 2026
67 checks passed
@hyperpolymath
hyperpolymath deleted the codex/required-ci-gate-20261116 branch November 16, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants