Skip to content

Mark PROOF-PROGRESS.adoc as superseded - #88

Open
hyperpolymath wants to merge 1 commit into
mainfrom
claude/supersede-proof-progress
Open

hyperpolymath wants to merge 1 commit into
mainfrom
claude/supersede-proof-progress

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

The root PROOF-PROGRESS.adoc says four times that no proofs directory exists (lines 105, 147, 159 and 186). That is wrong: verification/proofs/ holds ten never-instantiated template prover files. docs/status/PROOF-STATUS.adoc already records them accurately, at 0 of 7 obligations done. This PR adds a dated supersession banner pointing to that file and keeps the body as history.

Changes

  • PROOF-PROGRESS.adoc: a [WARNING] banner headed "Superseded 2026-11-16 — do not cite". Nothing else changes.

RSR Quality Checklist

Required

  • Tests pass: documentation only
  • No banned language patterns
  • SPDX license headers present (unchanged)
  • No secrets, credentials, or .env files included

As Applicable

  • Documentation updated

Testing

find verification/proofs -type f \( -name '*.agda' -o -name '*.lean' -o -name '*.v' -o -name '*.idr' -o -name '*.tla' \) | wc -l → 10.


Generated by Claude Code

The root summary (dated from the 2026-06-22 affirmation) says four
times that no proofs directory exists. verification/proofs/ holds ten
never-instantiated template prover files, and docs/status/PROOF-STATUS.adoc
already records them accurately (0 of 7 obligations done). A dated
supersession banner points readers there; the body is kept as history.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Marked the proof progress document as historical and superseded.
    • Directed readers to the current proof status record, which reports 0 of 7 obligations complete and notes that the prover templates are uninstantiated.

A warning marks the proof progress text as superseded and historical. It identifies docs/status/PROOF-STATUS.adoc as the authoritative record and reports a census of 0 of 7 obligations done.

Changes: Proof status documentation

Layer / File(s) Summary
Superseded proof progress notice
PROOF-PROGRESS.adoc
The added warning says that the former claim about the proofs directory is inaccurate, identifies the ten files as uninstantiated templates, and points to the authoritative status record. It labels the remaining text as historical.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

  • hyperpolymath/haec#86: Updates the status document that this change identifies as authoritative and addresses the status of the template files.
Merge Risk: Minimal · up to 52690

This documentation-only change marks the old proof progress text as superseded and points readers to the current proof status record. It poses no runtime risk. CI root-shape failures appear to be pre-existing and are not caused by this edit.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "Mark PROOF-PROGRESS.adoc as superseded" matches the main change: a dated supersession warning added to PROOF-PROGRESS.adoc. It names the file and the action, and it is concise and specific.
Description check Passed The description follows the template's main sections: Summary, Changes, RSR Quality Checklist and Testing. It explains the problem (four incorrect claims that no proofs directory exists), the fix (a d…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description follows the template's main sections: Summary, Changes, RSR Quality Checklist and Testing. It explains the problem (four incorrect claims that no proofs directory exists), the fix (a dated supersession banner pointing to docs/status/PROOF-STATUS.adoc), and gives a reproducible validation command with its result. Checklist items are ticked where they apply. The Screenshots section is omitted, which is acceptable because it is marked as applicable only when relevant. Some Required items are not explicitly addressed, such as the linter and SPDX header check, but the description is mostly complete.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 535f2eec-2e38-4675-b709-1e79c07836cc
Commits

Reviewing files that changed from the base of the PR and between df8e7bb and 52690ac.

Files selected for processing: 1

  • PROOF-PROGRESS.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 2

  • GitHub Check: CodeRabbit
  • GitHub Check: semgrep-cloud-platform/scan
CI failures not shown inline: 6

GitHub Actions: 🟡 Check: Estate rules / 0_estate-rules.txt: Mark PROOF-PROGRESS.adoc as superseded

Conclusion: failure

View job details

##[group]Run bash scripts/check-root-shape.sh .
 �[36;1mbash scripts/check-root-shape.sh .�[0m
 shell: /usr/bin/bash -e {0}
 ##[endgroup]
 FAIL: 5 root entries are not on the allowlist:
   - CHANGELOG.adoc
   - CONTRIBUTING.adoc
   - FUNDING
   - PROOF-PROGRESS.adoc
   - SECURITY.adoc
 Either move them into the appropriate subdirectory, or add a justified
 entry to .machine_readable/root-allow.txt.
 ##[error]Process completed with exit code 1.

GitHub Actions: 🟡 Check: Estate rules / estate-rules: Mark PROOF-PROGRESS.adoc as superseded

Conclusion: failure

View job details

##[group]Run bash scripts/check-root-shape.sh .
 �[36;1mbash scripts/check-root-shape.sh .�[0m
 shell: /usr/bin/bash -e {0}
 ##[endgroup]
 FAIL: 5 root entries are not on the allowlist:
   - CHANGELOG.adoc
   - CONTRIBUTING.adoc
   - FUNDING
   - PROOF-PROGRESS.adoc
   - SECURITY.adoc
 Either move them into the appropriate subdirectory, or add a justified
 entry to .machine_readable/root-allow.txt.
 ##[error]Process completed with exit code 1.

GitHub Actions: CI / required / 0_CI _ required.txt: Mark PROOF-PROGRESS.adoc as superseded

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1m# Print the version before asserting on it: piping straight into�[0m
 �[36;1m# `grep -Fx` under `pipefail` made a mismatch fail with no output at�[0m
 �[36;1m# all, which is what happened here. The pinned image reports a build�[0m
 �[36;1m# suffix, so match on the release rather than the whole string.�[0m
 �[36;1mver="$(idris2 --version)"�[0m
 �[36;1mecho "idris2 --version -> ${ver}"�[0m
 �[36;1mcase "$ver" in�[0m
 �[36;1m  *"0.8.0"*) ;;�[0m
 �[36;1m  *) echo "::error::expected Idris 2 0.8.0, got: ${ver}"; exit 1 ;;�[0m
...
 ##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1mzver="$(zig version)"�[0m
 �[36;1mecho "zig version -> ${zver}"�[0m
 �[36;1mtest "$zver" = '0.15.2' || { echo "::error::expected Zig 0.15.2, got: ${zver}"; exit 1; }�[0m
...
 ##[group]Run set -euo pipefail
...
   - PROOF-PROGRESS.adoc
   - SECURITY.adoc
 Either move them into the appropriate subdirectory, or add a justified
 entry to .machine_readable/root-allow.txt.
 ##[error]Process completed with exit code 1.

GitHub Actions: CI / required / CI _ required: Mark PROOF-PROGRESS.adoc as superseded

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1m# Print the version before asserting on it: piping straight into�[0m
 �[36;1m# `grep -Fx` under `pipefail` made a mismatch fail with no output at�[0m
 �[36;1m# all, which is what happened here. The pinned image reports a build�[0m
 �[36;1m# suffix, so match on the release rather than the whole string.�[0m
 �[36;1mver="$(idris2 --version)"�[0m
 �[36;1mecho "idris2 --version -> ${ver}"�[0m
 �[36;1mcase "$ver" in�[0m
 �[36;1m  *"0.8.0"*) ;;�[0m
 �[36;1m  *) echo "::error::expected Idris 2 0.8.0, got: ${ver}"; exit 1 ;;�[0m

GitHub Actions: CI / required / CI _ required: Mark PROOF-PROGRESS.adoc as superseded

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1mzver="$(zig version)"�[0m
 �[36;1mecho "zig version -> ${zver}"�[0m
 �[36;1mtest "$zver" = '0.15.2' || { echo "::error::expected Zig 0.15.2, got: ${zver}"; exit 1; }�[0m

GitHub Actions: CI / required / CI _ required: Mark PROOF-PROGRESS.adoc as superseded

Conclusion: failure

View job details

##[group]Run set -euo pipefail
 �[36;1mset -euo pipefail�[0m
 �[36;1mfind tests scripts -type f -name '*.sh' -print0 \�[0m
 �[36;1m  | xargs -0 -r bash -n�[0m
 �[36;1mbash tests/check-examples.sh�[0m
 �[36;1mbash tests/aspect_tests.sh�[0m
 �[36;1mbash scripts/check-root-shape.sh .�[0m
 �[36;1mbash tests/workflows/validate_workflows_test.sh�[0m
 shell: bash --noprofile --norc -e -o pipefail {0}
 ##[endgroup]
 �[32mok�[0m   faithful-record.haec → faithful-record.ir.json (well-formed IR, expects p-sufficient)
 �[32mok�[0m   survey-collapse.haec → survey-collapse.ir.json (well-formed IR, expects p-insufficient)
 �[32mok�[0m   station-average.haec → station-average.ir.json (well-formed IR, expects p-sufficient)
 �[33mnote�[0m sibling trope-checker not checked out; skipping schema-drift guard (TROPECHECK_REQUIRED=1 makes this fatal)
 �[33mnote�[0m no checker binary; skipping verdict round-trip (set TROPECHECK_BIN, or TROPECHECK_REQUIRED=1 to make this fatal)
 �[32mexamples: all lower to valid Trope IR�[0m
 ═══════════════════════════════════════════════════════════════
   HAEC — Aspect Tests (Cross-Cutting Concerns)
 ═══════════════════════════════════════════════════════════════
 �[1mAspect 1: SPDX license headers�[0m
 �[32m  PASS: All source files have SPDX headers�[0m
 �[1mAspect 2: Dangerous patterns�[0m
 �[32m  PASS: No dangerous Idris2 patterns (believe_me, assert_total)�[0m
 �[32m  PASS: No dangerous proof patterns (Admitted, sorry, unsafeCoerce)�[0m
 ═══════════════════════════════════════════════════════════════
   Results: �[32mPASS=3�[0m  FAIL=0  WARN=0
 ═══════════════════════════════════════════════════════════════
 FAIL: 5 root entries are not on the allowlist:
   - CHANGELOG.adoc
   - CONTRIBUTING.adoc
   - FUNDING
   - PROOF-PROGRESS.adoc
   - SECURITY.adoc
 Either move them into the appropriate subdirectory, or add a justified
 entry to .machine_readable/root-allow.txt.
 ##[error]Process completed with exit code 1.
Additional context used

GitHub Actions: 🟡 Check: Estate rules / estate-rules

PROOF-PROGRESS.adoc

[error] 1-1: bash scripts/check-root-shape.sh . failed: root entry is not on the allowlist. Move it into an appropriate subdirectory or add a justified entry to .machine_readable/root-allow.txt.

GitHub Actions: CI / required / CI _ required

PROOF-PROGRESS.adoc

[error] 1-1: scripts/check-root-shape.sh . failed: root entry is not on the allowlist. Move it to an appropriate subdirectory or add a justified entry to .machine_readable/root-allow.txt.

@sonarqubecloud

Copy link
Copy Markdown

@linear-code
linear-code Bot marked this pull request as ready for review November 16, 2026 23:20

Copy link
Copy Markdown
Owner Author

estate-rules and CI / required are failing on a check this PR did not cause.

  • The failure: scripts/check-root-shape.sh reports 5 root entries missing from the allowlist: CHANGELOG.adoc, CONTRIBUTING.adoc, FUNDING, PROOF-PROGRESS.adoc and SECURITY.adoc.
  • Why it isn't this PR's: all five files already exist on main. This PR only edits the contents of PROOF-PROGRESS.adoc; it adds and moves nothing.
  • What fixes it: adding entries to .machine_readable/root-allow.txt. That is an owner-only change, already tracked as haec#83 with cherry-pick candidate a7f62e4, so I have not touched it here.

Generated by Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants