fix(fixtures): sync 2.1.7 MAINTAINERS gate with the standards SSOT - #732
Conversation
Mirrors hyperpolymath/standards fix/maintainers-gate-governance-tier, which corrects criterion 2.1.7 from gate = "universal" to gate = "governance-tier". This fixture is a copy of the canon's rsr-criteria-v2.a2ml, so leaving it behind would make the suite assert against a spec the canon no longer holds — the tests would keep passing while measuring the wrong thing, which is the failure mode a fixture copy exists to avoid. Verified: mix test test/a2ml/record_dialect_test.exs test/rules/rsr_conformance_test.exs — 24 tests, 0 failures. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (29)
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe RSR criteria fixture changes criterion ChangesRSR criteria
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized fixture update aligns the 2.1.7 gate value with the referenced standards change without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR updates the 2.1.7 (MAINTAINERS.adoc) criterion in the RSR criteria fixture, moving it from a 'universal' gate to 'governance-tier'. This alignment with the standards SSOT ensures that repositories not subject to governance-tier requirements are not incorrectly penalized for lacking the file.
Codacy analysis indicates the PR is up to standards with no new quality issues. However, there is a risk identified regarding the lack of verification: no regression tests were included to confirm that the rsr_conformance logic correctly excludes this criterion from the denominator for non-governance repositories.
About this PR
- Although the fixture update is correct according to the SSOT, the PR does not include new regression tests to verify that repositories previously penalized by the 'universal' gate are now correctly scored under the 'governance-tier' logic.
Test suggestions
- Verify that criterion 2.1.7 is correctly parsed as part of the 'governance-tier' gate.
- Ensure a repository not declaring 'governance-tier' has criterion 2.1.7 excluded from its conformance denominator in rsr_conformance logic.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that criterion 2.1.7 is correctly parsed as part of the 'governance-tier' gate.
2. Ensure a repository not declaring 'governance-tier' has criterion 2.1.7 excluded from its conformance denominator in rsr_conformance logic.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Mirrors hyperpolymath/standards#665, which corrects criterion 2.1.7 (MAINTAINERS.adoc) from
gate = "universal"togate = "governance-tier".test/fixtures/a2ml/rsr-criteria-v2.a2mlis a copy of the canon's SSOT. Leaving it behind would make the suite assert against a spec the canon no longer holds — the tests would keep passing while measuring the wrong thing, which is precisely the failure mode a fixture copy exists to avoid.Why the underlying fix matters to this repo specifically
lib/rules/rsr_conformance.exis what makes the gate load-bearing: applicable = universal ∪ gated-and-declared, with:naexcluded from the denominator. A criterion mis-gateduniversaltherefore stays in every repo's denominator. A leaf repo that declined MAINTAINERS asTEMPLATE-APPLICABILITY-POLICY.adocexplicitly permits was scored down by this oracle for obeying the canon.Verification
mix test test/a2ml/record_dialect_test.exs test/rules/rsr_conformance_test.exs— 24 tests, 0 failures.Should land together with standards#665.
🤖 Generated with Claude Code