Repository navigation
style(container): convert compose.yaml to KYAML - #6
Merged
Merged
Conversation
Unquote the three quoted keys (service "quintessence" in services and depends_on, volume "quintessence-data") so the file passes the estate KYAML ratchet (kyaml-format.sh --check). Parsed data is unchanged: yq -o=json output is identical before and after. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZpZvi71UBjsZR9WWQp
hyperpolymath
force-pushed
the
claude/quintessence-kyaml-compose
branch
from
November 19, 2026 11:22
44dcb36 to
2d0664b
Compare
hyperpolymath
marked this pull request as ready for review
November 19, 2026 11:22
|
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes the red
estate-rulesjob onmain. The step "Converted YAML stays KYAML" failed becausebuild/container/compose.yamlhad three quoted keys, which the pinnedkyaml-format.sh --checkrejects. This PR unquotes them. No data changes.Changes
build/container/compose.yaml: unquote"quintessence"(service key anddepends_onkey) and"quintessence-data"(volume key). Three lines changed.build/container/compose.example.yaml: already KYAML, not touched.Parsed data is identical before and after (
yq -o=jsonoutput diffed, no difference).RSR Quality Checklist
Required
just testor equivalent): not run. The only check run is the KYAML check below.just fmtor equivalent): not run. The change is a KYAML formatter rewrite.unsafeblocks without// SAFETY:comments (none touched).envfiles includedAs Applicable
Testing
Run locally with the workflow's pinned tools, each verified against its SHA-256 before use:
mikefarah/yq,yq_linux_amd64):sha256sum --checkOK,yq --version=v4.53.3kyaml-format.shat standards75bd5994470661a099df562d6d5ad2fe744dbd66:sha256sum --checkOKbash kyaml-format.sh --check build/container/compose.yaml build/container/compose.example.yaml build/container/stapeln/.gatekeeper.yaml→1 of 3 file(s) are not KYAML, exit 1compose.yaml:rewrote build/container/compose.yamlyq -o=jsonon the file before and after,diffemptyall 3 file(s) are KYAML, exit 0Not run here:
tests/workflows/container_kyaml_test.sh(its CI step runs only in the template, wherearchetypes/exists) andtests/workflows/kyaml_ratchet_test.sh.Screenshots
Not applicable.
Open decisions
None.
Generated by Claude Code