Skip to content

chore(arrival-pack): take the template's generated Proofs guidance - #13

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/arrival-pack-proofs
Nov 15, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/arrival-pack-proofs

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

The template now generates the ## Proofs block inside the arrival-pack region (hyperpolymath/rsr-template-repo#413), with the PROOF-POLICY §1.1 and §8.1 wording fixes from hyperpolymath/rsr-template-repo#400. This carries that engine here and regenerates CLAUDE.md.

It also clears a drift on main: verify.sh reported the arrival-pack region stale, because the deed changed after the pack was last generated. Regenerating brings it back in step.

Owner decision by selector, 2026-11-15.

Changes

  • .machine_readable/arrival-pack/arrival-pack.ncl and extract.sh: copied from the template at 894038e.
  • CLAUDE.md: regenerated. The hand-authored Proofs copy below the region (older wording) is removed, so the block appears once.
  • tests/workflows/governance_policy_test.sh: the template's version, which asserts the Proofs block is inside the generated region.

Regenerating also brings the template's newer estate-common text and a reworded Identity line (the id itself is unchanged), plus an "Anchor override" line read from this repo's own deed. Please check that line is true for this repo.

scripts/deed-field.sh is deliberately not upgraded.

RSR Quality Checklist

Required

  • Tests pass (just test) — not run locally. Left to CI.
  • No banned language patterns
  • No secrets, credentials, or .env files included

Testing

  • bash .machine_readable/arrival-pack/verify.sh → DRIFT on main; in sync after this change.
  • All 54 scripts under tests/ run before and after: no result changed. The same 3 fail both times in the session container (check_adoc_renders_test, devcontainer_test, ffi_strings_test); not investigated, not caused by this change.
  • The generated Proofs block is byte-identical to the template's.

Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated repository guidance to clarify identity and clade placement, supported data formats, migration routing, and validation checks.
    • Added proof-policy guidance covering verification, proof records, dependency boundaries, and theory-only witness grades.
    • Documented an optional anchor override and its restrictions.
  • Bug Fixes
    • Improved deed-list and repository ID parsing, with clearer handling of invalid values and read errors.
    • Updated generated metadata to include anchor policy lists and produce consistently sorted, compact JSON.

…sr-template-repo#413)

The template now generates the '## Proofs' block inside the arrival-pack
region (rsr-template-repo#413), with the PROOF-POLICY §1.1 and §8.1 wording
from rsr-template-repo#400. This carries the engine here and regenerates
CLAUDE.md; the hand-authored copy below the region is removed so the block
appears once. governance_policy_test.sh is the template's, which asserts the
block is inside the region.

Regenerating also brings the template's newer estate-common wording and
identity line. scripts/deed-field.sh is left as it is.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zoc4g7WLgAwdMTnzPM
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The arrival-pack extractor now reads typed deed identity, clade placement, and anchor policy data. The template uses these values to generate revised identity, canon, anchor, and proof-policy guidance. The generated CLAUDE.md content and governance test are updated.

Changes: Arrival-pack generation

Layer / File(s) Summary
Extract deed identity, placement, and anchor data
.machine_readable/arrival-pack/extract.sh
The extractor reads typed UUID values, reports version-5 identities, derives optional clade placement, and emits anchor policy lists as arrays in compact, sorted JSON.
Generate arrival-pack guidance
.machine_readable/arrival-pack/arrival-pack.ncl
The template adds a conditional anchor override and updates CHORA identity, canon pointers, proof-policy guidance, and the repo summary.
Update generated guidance and validation
CLAUDE.md, tests/workflows/governance_policy_test.sh
CLAUDE.md reflects the revised generated guidance and deed provenance. The test checks that proof guidance appears once inside the generated region and in the arrival-pack source.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: Minimal · up to e4039

This change regenerates the arrival-pack guidance from the template and moves the Proofs section into the generated region. It affects documentation and a policy test only. No concrete merge-blocking risk was found.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Hypatia grid green

🟢 clean · commit e4039eed95b8 · run 43700800339 · scope: this change (4 file(s))

Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change.

Unique graded findings across gating and advisory rows: 20 (20 reporter observations; 19 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Raw Hypatia alert-derived observations: 36 (code-scanning, Dependabot and secret-scanning; some may also be in SARIF; not an extra total).

Reporter Gate Status Critical High Medium Minor Since previous revision
Hypatia scan gating 🟢 clean 0 0 0 0 — same commit (no revision comparison)
panic-attack assail advisory 🟢 clean 0 0 0 0 — same commit (no revision comparison)
pons asinorum advisory 🟢 clean 0 0 0 0 — same commit (no revision comparison)
echidnabot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
rhodibot (RSR compliance) advisory 🟢 clean 0 0 0 0 — same commit (no revision comparison)
panicbot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
sustainabot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
glambot (presentation quality) advisory 🔵 minor 0 0 0 6 — same commit (no revision comparison)
seambot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
finishingbot (release readiness) advisory 🔴 high 0 9 5 0 — same commit (no revision comparison)
cipherbot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
accessibilitybot advisory ⚪ not applicable 0 0 0 0 — same commit (no revision comparison)
Hypatia scan: 1 finding(s)
  • 1 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
panic-attack assail: 18 finding(s)
  • 18 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
pons asinorum: 9 finding(s)
  • 9 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
  • ⚪ not applicable: template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): 11 finding(s)
  • 11 further finding(s) in files this change does not touch: reported, not graded (0 critical, 10 high).
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
  • ⚪ not applicable: panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
  • ⚪ not applicable: reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): 86 finding(s)
  • info GS-001 — Install git-seo for comprehensive SEO analysis: https://github.com/hyperpolymath/git-seo
  • info MACH-007 — ECOSYSTEM.scm not found in .machine_readable/ directory.
  • info MACH-007 — META.scm not found in .machine_readable/ directory.
  • info MACH-007 — STATE.scm not found in .machine_readable/ directory.
  • info MACH-005 — No robots.txt found. Consider adding one for crawler control.
  • info VIS-005 — CLAUDE.md:9 — Line 177 characters exceeds max length of 80.
  • 80 further finding(s) in files this change does not touch: reported, not graded (0 critical, 2 high).
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
  • ⚪ not applicable: template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): 176 finding(s)
  • high V1-DOC-ROADMAP.adoc — Required file ROADMAP.adoc not found (Project roadmap).
  • high TOOL-001 — .tool-versions file not found for asdf/mise version management.
  • high SCM-001-NEUROSYM.scm — Required SCM file NEUROSYM.scm not found (Neurosymbolic AI documentation).
  • high SCM-001-AGENTIC.scm — Required SCM file AGENTIC.scm not found (Agentic AI integration documentation).
  • high SCM-001-PLAYBOOK.scm — Required SCM file PLAYBOOK.scm not found (Operational playbooks and procedures).
  • high SCM-001-ECOSYSTEM.scm — Required SCM file ECOSYSTEM.scm not found (Project's place in the ecosystem).
  • high SCM-001-META.scm — Required SCM file META.scm not found (Meta-level information and architectural decisions).
  • high SCM-001-STATE.scm — Required SCM file STATE.scm not found (Project state and progress tracking).
  • high PH-100 — Found 127 placeholders, exceeds maximum allowed (0)
  • medium V1-COM-CONTRIBUTING.md — CONTRIBUTING.md file not found (Contribution guidelines).
  • medium V1-COM-CODE_OF_CONDUCT.md — CODE_OF_CONDUCT.md file not found (Code of conduct).
  • medium V1-SEC-001 — SECURITY.md not found for responsible disclosure.
  • medium TEST-001 — Could not determine if this is a Rust or Deno project.
  • medium REL-004 — No SECURITY.md file found
  • 162 further finding(s) in files this change does not touch: reported, not graded (0 critical, 4 high).
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
  • ⚪ not applicable: template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
  • ⚪ not applicable: template default: enrol once the repository serves HTML

Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run.

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 15, 2026 09:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T10:01:40.942278Z e4039ee Draft marked ready
🔒 Security Review ✅ Completed 2026-11-15T10:00:48.167088Z e4039ee Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4039eed95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +24 to +25
if std.array.length data.anchor_forbidden == 0 then ""
else "\n- **Anchor override** (ANCHOR) — This repo's anchor forbids: %{std.string.join ", " data.anchor_forbidden}. The anchor overrides the estate policy above."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include allowed languages in the anchor override

When a repository's anchor/implementation-policy/allowed list permits a language denied by the estate policy (for example, Go), this condition either omits the override entirely when forbidden is empty or renders only the forbidden entries. Although extract.sh now reads and exports anchor_allowed, the generated guidance still tells agents that the estate denial applies, so minted repositories can receive instructions that contradict their anchor. Build the override from both allowed and forbidden entries.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked. The description is accurate: extract.sh exports anchor_allowed, and arrival-pack.ncl renders only anchor_forbidden, so an anchor that allows an estate-denied language would not show in the generated pack.

It does not bite in this repo: sholes' anchor allows Rust, Idris2, Zig, Scheme, Shell, Just, AsciiDoc and Markdown, none of which the estate policy denies, and forbids Node.js and npm, which the line renders.

Not fixed in this PR: both files are the template's, carried unchanged, so a change to the engine belongs in rsr-template-repo. Raised with the owner.


Generated by Claude Code

Comment thread CLAUDE.md
Comment on lines +92 to +95
dependency's whole import cone compiles under the prover's safe mode with zero
postulates, it is *checked, not assumed*: record the cone (root module, flags,
postulate count of zero, library name, version and pin) instead of an
`ASSUMED` row (policy §1.1). A cone with a postulate, or compiled outside safe

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Synchronize the repo proof guide with the new exception

For dependencies whose complete import cone passes safe mode with zero postulates, this new guidance says to record the dependency as checked rather than ASSUMED, but verification/proofs/README.adoc:75-81 still directs authors to record every relied-upon dependency as ASSUMED without this exception. Since the generated section explicitly points readers to that file as this repository's mapping, proof authors now receive contradictory status-recording instructions; update the repository guide and its test assertions alongside this policy change.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, and the finding is correct. verification/proofs/README.adoc ("Third-party code") still says to record every relied-upon dependency as ASSUMED, with no checked-cone exception, while the generated Proofs block now carries the PROOF-POLICY §1.1 exception.

Not fixed in this PR: that section is byte-identical to the template's (rsr-template-repo at 894038e), and governance_policy_test.sh asserts its wording, so the fix belongs in the template (guide plus test) and then travels here. Raised with the owner.


Generated by Claude Code

@hyperpolymath
hyperpolymath merged commit 36b0a67 into main Nov 15, 2026
46 of 47 checks passed
hyperpolymath added a commit to hyperpolymath/rsr-template-repo that referenced this pull request Nov 15, 2026
…ion; anchor override names allowed languages (#416)

## Summary

Three findings from review of the minted-repo sync (Codex and SonarCloud
on hyperpolymath/sholes#13), fixed at the source. Owner decision by
selector, 2026-11-15.

## Changes

- **Proof guide** — `verification/proofs/README.adoc` told authors to
record every relied-upon dependency as `ASSUMED`, while the generated
Proofs block (#400, #413) carries the PROOF-POLICY §1.1 exception: a
whole import cone that passes safe mode with zero postulates is checked,
not assumed. The guide now carries the exception, and
`governance_policy_test.sh` asserts it in both the guide and the arrival
guidance.
- **Anchor override** — the arrival pack rendered only what an anchor
forbids. It now also names any language the anchor allows that the
estate policy denies. The estate deny list is stated once in
`arrival-pack.ncl`; the language-policy line prints the same list.
- **Wording is new and proposed, please review:** `This repo's anchor
allows, where the estate policy above denies: Go; it forbids: Node.js,
npm. The anchor overrides the estate policy above.`
- Output is unchanged for a repo whose anchor allows no denied language:
this repo's `CLAUDE.md` regenerates byte-identical, and a "forbids only"
repo keeps its current line.
  - Names are compared as written (`go` would not match `Go`).
- **`extract.sh`** — the v5-identity `case` gets a default branch
(SonarCloud `shell:S131`).
- **New controls** —
`tests/workflows/arrival_pack_anchor_override_test.sh` (7 cases), wired
into `estate-rules.yml` as one step after the Nickel install. No action
pins change.

Minted repos are not touched here; carrying the guide, test and engine
to them follows after merge.

## RSR Quality Checklist

### Required

- [ ] Tests pass (`just test`) — not run locally (Idris2 and Zig are not
installed in the session container). Left to CI.
- [x] No banned language patterns
- [x] No secrets, credentials, or `.env` files included
- [x] SPDX header on the new test file

### As Applicable

- [x] Documentation updated (`arrival-pack/README.adoc`, the proof
guide)
- [ ] `CHANGELOG` not updated

## Testing

- `governance_policy_test.sh` → exit 0. Negative control: with the old
guide restored it fails with `proof guide must carry the checked-cone
exception`.
- `arrival_pack_anchor_override_test.sh` → 7 controls, 0 failed.
Negative control: against the engine on `main`, the two allowed-language
cases fail.
- `workflow_edges_test.sh`, `check_lock_sync_test.sh`,
`scripts/check-lock-sync.sh`, arrival-pack `verify.sh`, `just
validate-repo-map` → all pass.
- A run of every script under `tests/` was still in progress when this
PR was opened; result to follow in a comment only if anything changes.

---
_Generated by [Claude
Code](https://claude.ai/code/session_0136P7Zoc4g7WLgAwdMTnzPM)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants