Repository navigation
chore(arrival-pack): take the template's generated Proofs guidance - #13
Conversation
…sr-template-repo#413) The template now generates the '## Proofs' block inside the arrival-pack region (rsr-template-repo#413), with the PROOF-POLICY §1.1 and §8.1 wording from rsr-template-repo#400. This carries the engine here and regenerates CLAUDE.md; the hand-authored copy below the region is removed so the block appears once. governance_policy_test.sh is the template's, which asserts the block is inside the region. Regenerating also brings the template's newer estate-common wording and identity line. scripts/deed-field.sh is left as it is. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zoc4g7WLgAwdMTnzPM
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
|
|
🟢 clean · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 20 (20 reporter observations; 19 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: 1 finding(s)
panic-attack assail: 18 finding(s)
pons asinorum: 9 finding(s)
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
rhodibot (RSR compliance): 11 finding(s)
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
glambot (presentation quality): 86 finding(s)
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
finishingbot (release readiness): 176 finding(s)
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4039eed95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if std.array.length data.anchor_forbidden == 0 then "" | ||
| else "\n- **Anchor override** (ANCHOR) — This repo's anchor forbids: %{std.string.join ", " data.anchor_forbidden}. The anchor overrides the estate policy above." |
There was a problem hiding this comment.
Include allowed languages in the anchor override
When a repository's anchor/implementation-policy/allowed list permits a language denied by the estate policy (for example, Go), this condition either omits the override entirely when forbidden is empty or renders only the forbidden entries. Although extract.sh now reads and exports anchor_allowed, the generated guidance still tells agents that the estate denial applies, so minted repositories can receive instructions that contradict their anchor. Build the override from both allowed and forbidden entries.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Checked. The description is accurate: extract.sh exports anchor_allowed, and arrival-pack.ncl renders only anchor_forbidden, so an anchor that allows an estate-denied language would not show in the generated pack.
It does not bite in this repo: sholes' anchor allows Rust, Idris2, Zig, Scheme, Shell, Just, AsciiDoc and Markdown, none of which the estate policy denies, and forbids Node.js and npm, which the line renders.
Not fixed in this PR: both files are the template's, carried unchanged, so a change to the engine belongs in rsr-template-repo. Raised with the owner.
Generated by Claude Code
| dependency's whole import cone compiles under the prover's safe mode with zero | ||
| postulates, it is *checked, not assumed*: record the cone (root module, flags, | ||
| postulate count of zero, library name, version and pin) instead of an | ||
| `ASSUMED` row (policy §1.1). A cone with a postulate, or compiled outside safe |
There was a problem hiding this comment.
Synchronize the repo proof guide with the new exception
For dependencies whose complete import cone passes safe mode with zero postulates, this new guidance says to record the dependency as checked rather than ASSUMED, but verification/proofs/README.adoc:75-81 still directs authors to record every relied-upon dependency as ASSUMED without this exception. Since the generated section explicitly points readers to that file as this repository's mapping, proof authors now receive contradictory status-recording instructions; update the repository guide and its test assertions alongside this policy change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Checked, and the finding is correct. verification/proofs/README.adoc ("Third-party code") still says to record every relied-upon dependency as ASSUMED, with no checked-cone exception, while the generated Proofs block now carries the PROOF-POLICY §1.1 exception.
Not fixed in this PR: that section is byte-identical to the template's (rsr-template-repo at 894038e), and governance_policy_test.sh asserts its wording, so the fix belongs in the template (guide plus test) and then travels here. Raised with the owner.
Generated by Claude Code
…ion; anchor override names allowed languages (#416) ## Summary Three findings from review of the minted-repo sync (Codex and SonarCloud on hyperpolymath/sholes#13), fixed at the source. Owner decision by selector, 2026-11-15. ## Changes - **Proof guide** — `verification/proofs/README.adoc` told authors to record every relied-upon dependency as `ASSUMED`, while the generated Proofs block (#400, #413) carries the PROOF-POLICY §1.1 exception: a whole import cone that passes safe mode with zero postulates is checked, not assumed. The guide now carries the exception, and `governance_policy_test.sh` asserts it in both the guide and the arrival guidance. - **Anchor override** — the arrival pack rendered only what an anchor forbids. It now also names any language the anchor allows that the estate policy denies. The estate deny list is stated once in `arrival-pack.ncl`; the language-policy line prints the same list. - **Wording is new and proposed, please review:** `This repo's anchor allows, where the estate policy above denies: Go; it forbids: Node.js, npm. The anchor overrides the estate policy above.` - Output is unchanged for a repo whose anchor allows no denied language: this repo's `CLAUDE.md` regenerates byte-identical, and a "forbids only" repo keeps its current line. - Names are compared as written (`go` would not match `Go`). - **`extract.sh`** — the v5-identity `case` gets a default branch (SonarCloud `shell:S131`). - **New controls** — `tests/workflows/arrival_pack_anchor_override_test.sh` (7 cases), wired into `estate-rules.yml` as one step after the Nickel install. No action pins change. Minted repos are not touched here; carrying the guide, test and engine to them follows after merge. ## RSR Quality Checklist ### Required - [ ] Tests pass (`just test`) — not run locally (Idris2 and Zig are not installed in the session container). Left to CI. - [x] No banned language patterns - [x] No secrets, credentials, or `.env` files included - [x] SPDX header on the new test file ### As Applicable - [x] Documentation updated (`arrival-pack/README.adoc`, the proof guide) - [ ] `CHANGELOG` not updated ## Testing - `governance_policy_test.sh` → exit 0. Negative control: with the old guide restored it fails with `proof guide must carry the checked-cone exception`. - `arrival_pack_anchor_override_test.sh` → 7 controls, 0 failed. Negative control: against the engine on `main`, the two allowed-language cases fail. - `workflow_edges_test.sh`, `check_lock_sync_test.sh`, `scripts/check-lock-sync.sh`, arrival-pack `verify.sh`, `just validate-repo-map` → all pass. - A run of every script under `tests/` was still in progress when this PR was opened; result to follow in a comment only if anything changes. --- _Generated by [Claude Code](https://claude.ai/code/session_0136P7Zoc4g7WLgAwdMTnzPM)_ --------- Co-authored-by: Claude <noreply@anthropic.com>



Summary
The template now generates the
## Proofsblock inside the arrival-pack region (hyperpolymath/rsr-template-repo#413), with the PROOF-POLICY §1.1 and §8.1 wording fixes from hyperpolymath/rsr-template-repo#400. This carries that engine here and regeneratesCLAUDE.md.It also clears a drift on
main:verify.shreported the arrival-pack region stale, because the deed changed after the pack was last generated. Regenerating brings it back in step.Owner decision by selector, 2026-11-15.
Changes
.machine_readable/arrival-pack/arrival-pack.nclandextract.sh: copied from the template at894038e.CLAUDE.md: regenerated. The hand-authored Proofs copy below the region (older wording) is removed, so the block appears once.tests/workflows/governance_policy_test.sh: the template's version, which asserts the Proofs block is inside the generated region.Regenerating also brings the template's newer estate-common text and a reworded Identity line (the id itself is unchanged), plus an "Anchor override" line read from this repo's own deed. Please check that line is true for this repo.
scripts/deed-field.shis deliberately not upgraded.RSR Quality Checklist
Required
just test) — not run locally. Left to CI..envfiles includedTesting
bash .machine_readable/arrival-pack/verify.sh→ DRIFT onmain; in sync after this change.tests/run before and after: no result changed. The same 3 fail both times in the session container (check_adoc_renders_test,devcontainer_test,ffi_strings_test); not investigated, not caused by this change.Generated by Claude Code
Summary by CodeRabbit