Skip to content

Run all four proof developments in the just recipes (ADR 0005 amendment upkeep) - #126

Open
hyperpolymath wants to merge 1 commit into
claude/pwg-names-ladderfrom
claude/nifty-dirac-u0se2a
Open

hyperpolymath wants to merge 1 commit into
claude/pwg-names-ladderfrom
claude/nifty-dirac-u0se2a

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

This is the upkeep (doctrine 16) that ADR 0005's 2026-11-17 amendment named and left undone. In #124 the amendment says that just proof-status and the other recipes D5 touched "still describe the developments they ran on 2026-10-27". This PR brings them in line with the amended D4 role table: Agda is the normative kernel, Rocq and core Lean are §2 recheck legs, Lean + Mathlib is a generator, and Idris2 is the reference.

Stacked PR. #124 merged into claude/pwg-names-ladder, which is still open against main as #119. scripts/check-recheck-legs.sh exists only on that branch, so this PR targets it. Retarget it to main once #119 merges.

One real defect fixed. Since #122 added the core-Lean leg, just proof-check-lean4 has failed on every run, whatever the toolchain. Its orphan guard counted lean4/ratified-order/RatifiedOrder.lean as a file that no lake package builds. proof-check-all failed with it.

No proof, ledger entry or grade changed.

Changes

  • build/just/proofs.just
    • New recipes: proof-check-rocq, proof-check-lean-core and proof-check-recheck-controls run bash scripts/check-recheck-legs.sh rocq|lean|controls. recheck-legs runs all three, as the proofs.yml job of that name does. A missing or wrong-version prover fails, because that is the script's own behaviour; nothing skips.
    • proof-check-all and verify-all now depend on recheck-legs. Both now also need coqc 8.18.0 and lean 4.16.0 on PATH.
    • proof-status lists the four developments by D4 role, with each one's gate, and prints the derived PWG census. It used to grep for a **Total** row that PROOF-STATUS.adoc no longer has. It no longer counts vendored .lake/ or _build/ files.
    • proof-check-lean4 orphan guard: it exempts exactly the LEAN_FILE that check-recheck-legs.sh names, so a stray file beside the leg still fails. If that variable cannot be read, the recipe fails. proof-check-rocq gets the same guard for .v files.
    • The "(No proof-check-coq …)" note is replaced by the recipes it asked for.
    • The one-line descriptions that just --list shows now name each recipe's role. Before, several of them showed a stray mid-paragraph line.
  • README.adoc: the repository map gains rows for rocq/ and lean4/ratified-order/, plus the D4 roles. The run-the-checks block gains just recheck-legs, and its verify-all comment is updated. The sentence "Only L1 and L4 carry a statement in all three" now names the three developments it meant (Agda, Lean with Mathlib, Idris2); its blame date of 2026-11-10 predates the recheck legs. Its claim is unchanged.
  • verification/proofs/README.adoc: adds the D4 role table, puts the recheck legs and roles in the tree, lists the new recipes, and describes the recheck-leg enforcement. It also fixes a pre-existing editorconfig indent error inside the tree block.
  • CHANGELOG.adoc: adds an entry under Unreleased → Fixed.
  • Left as history: INTEGRATION-REPORT.adoc, which is marked as a historical report, and ADR 0005's own D5 text, which the amendment supersedes. EXPLAINME.adoc has no prover-count prose.

RSR Quality Checklist

Required

  • Tests pass. just test is a template stub that tests nothing, so the real checks are listed under Testing.
  • Code is formatted (just fmt is also a stub). editorconfig-checker v3.1.2 is clean on all four files.
  • Linter is clean. ShellCheck 0.11.0 at --severity=style is clean on every tracked .sh and on the changed recipe bodies extracted with just --show. asciidoctor 2.0.20 with --failure-level=WARN is clean on the three .adoc files.
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments
  • No banned functions (just proof-scan-dangerous PASS)
  • SPDX license headers present (unchanged; aspect test PASS)
  • No secrets, credentials, or .env files included

As Applicable

  • Documentation updated for user-facing changes
  • CHANGELOG updated

Testing

Toolchain: Coq 8.18.0 (Ubuntu 24.04 apt, as CI uses), Lean 4.16.0 and ShellCheck 0.11.0 (both checked against the SHA-256 values pinned in proofs.yml and quality.yml), and just 1.40.0.

just recheck-legs                       -> PASS: Rocq leg (49/49 closed), Lean leg (49/49 axiom-free),
                                           6/6 planted controls caught
just proof-check-rocq, coqc absent      -> FAIL: coqc not on PATH ... it never skips   (exit 1)
just proof-check-lean-core, lean absent -> FAIL: lean not on PATH ... it never skips   (exit 1)
just proof-check-recheck-controls, coqc absent -> FAIL (exit 1)
ROCQ_VERSION=8.19.0 just proof-check-rocq -> FAIL: coqc is not version 8.19.0         (exit 1)
just proof-check-rocq + stray .v planted   -> FAIL: Rocq files no gate checks ...     (exit 1)
just proof-status                       -> the role table + census (28: PWG-3 15, PWG-2ii 7, ungraded 6)
just proof-scan-dangerous               -> PASS
bash scripts/pwg-check.sh               -> PASS, 29 obligation(s) derived, table and census match
bash scripts/test-gate-falsifiability.sh -> 29/29
bash tests/aspect_tests.sh              -> PASS=3 FAIL=0 WARN=0
tests/workflows/*_test.sh               -> all 5 exit 0

The proof-check-lean4 orphan guard was tested with a stub lake that exits 0, because building the Mathlib packages needs the Mathlib cache, which is not available here:

  • the old recipe on this tree: FAIL: Lean files belonging to no lake package: …/ratified-order/RatifiedOrder.lean (the defect).
  • the new recipe: PASS. With a stray .lean planted beside the leg it fails, and with LEAN_FILE missing from the script it fails.

Not run locally: build-lean, build-agda, and therefore verify-all and proof-check-all end to end. Agda 2.7.0.1 and the Mathlib cache are not installed here, and those recipe bodies are unchanged. just --dry-run confirms the new dependency order: verify-all runs build-lean, then build-agda, then recheck-legs, then the honesty gate and the PWG record.

Side note, not changed here: just 1.21 (Ubuntu apt) runs recipes from build/just/*.just imports in build/just/, so every imported recipe, the existing pwg-check included, fails under it. just 1.40.0 runs them from the repository root. .mise.toml leaves just commented out.



Generated by Claude Code

ADR 0005's 2026-11-17 amendment (#124) named this as upkeep (doctrine
16): `just proof-status` and the other recipes D5 touched still
described three provers.

build/just/proofs.just:
- add proof-check-rocq, proof-check-lean-core and
  proof-check-recheck-controls, running scripts/check-recheck-legs.sh
  rocq|lean|controls, and recheck-legs, which runs all three as the
  proofs.yml job of that name does. A missing or wrong-version prover
  fails; it never skips.
- proof-check-all and verify-all now include recheck-legs.
- proof-status lists the developments by D4 role and prints the derived
  PWG census. It used to look for a summary row that PROOF-STATUS no
  longer has. It no longer counts vendored .lake/_build files.
- fix proof-check-lean4, which had failed since #122. Its orphan guard
  counted the core-Lean leg as a file no lake package builds. It now
  exempts exactly the LEAN_FILE the recheck gate names. proof-check-rocq
  gets the same guard for .v files.
- the doc lines that just --list shows name each recipe's role.

README.adoc and verification/proofs/README.adoc gain the recheck legs,
the D4 roles and the new recipes. The README "all three" sentence now
names the three developments it meant. INTEGRATION-REPORT.adoc is a
historical report and is unchanged. No proof, ledger entry or grade
changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDgFtn2stHN9poWMAFr
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 208bfd77-0c99-4603-a410-ee954b95e2b7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Fork governance

Lane Status Run
DEED syntax (repo deed) 🟢 conformant run 44129270436
K9-DEED conformance (L0–L2; L3 not verified) 🟡 conformant (advisory debt) (job: success) same run
Hypatia verdict grid 🟢 no graded findings (job: success) · advisory in grid scope: 🔴 red (0 critical, 9 high, not grading) same run

Scope: the three lanes below are static checks at the named commit. A
green row means every applicable check in its declared scope passed;
orange means evidence is missing, not that nothing was found. The
Hypatia verdict covers GATING rows only; advisory reporters are listed
in its grid and their severity counts are limited to the grid scope.
A blocking gate may inspect findings outside the delta grid’s grade; open
the linked run and check annotations for the failing step and, where
applicable, the finding. No row is a security certification.

K9-DEED conformance

k9-deed L0–L2 yellow

🟡 advisory · commit bdd9a69af514 · run 44129270436 · validator hyperpolymath/standards@857ff096af11

Category Status Pass Fail Indeterminate N/A Since previous revision
K9 contract typecheck 🟢 conformant 1 0 0 0 — no comparable baseline
K9 validator self-test 🟢 conformant 49 0 0 0 — no comparable baseline
K9 live corpus (L0–L2) 🟡 advisory 2 8 (8 advisory) 0 0 — no comparable baseline
K9 live corpus (L0–L2): 8 finding(s) / scope notes
  • .machine_readable/self-validating/examples/setup-repo.k9.ncl — fail (advisory): K9-S007: security flags request capabilities the grant does not cover: net.fetch fs.write process.spawn (default-deny: list them in pedigree.security.capabilities); K9-S009: leash is 'Hunt but no pedigree.signature block is present (presence required here; verificatio
  • .machine_readable/self-validating/methodology-guard.k9.ncl — fail (advisory): K9-S002: pedigree.schema_version is missing; K9-S003: pedigree.component_type is missing (required by contract v1.0.0 §6.2); K9-N001: component violates the K9.Component contract: error: missing definition for `schema_version` ┌─ /home/runner/work/
  • .machine_readable/self-validating/template-hunt.k9.ncl — fail (advisory): K9-S003: pedigree.component_type is an unfilled placeholder: 'TODO: describe component type (e.g., 'deployment', 'setup-script')'; K9-S005: pedigree.metadata.name is an unfilled placeholder: 'TODO: component-name'; K9-S007: security flags request capabilities the gran
  • .machine_readable/self-validating/template-kennel.k9.ncl — fail (advisory): K9-S003: pedigree.component_type is an unfilled placeholder: 'TODO: describe component type (e.g., 'build-config', 'metadata')'; K9-S005: pedigree.metadata.name is an unfilled placeholder: 'TODO: component-name'
  • .machine_readable/self-validating/template-yard.k9.ncl — fail (advisory): K9-S003: pedigree.component_type is an unfilled placeholder: 'TODO: describe component type (e.g., 'validated-config', 'schema')'; K9-S005: pedigree.metadata.name is an unfilled placeholder: 'TODO: component-name'
  • container/deploy.k9.ncl — fail (advisory): K9-S002: pedigree.schema_version is missing; K9-S003: pedigree.component_type is missing (required by contract v1.0.0 §6.2); K9-S004: pedigree.security.leash is missing; K9-S005: pedigree.metadata.name is missing; K9-S011: component declares a 'recipes' block at l
  • coordination.k9 — fail (advisory): K9-S002: pedigree.schema_version is missing; K9-S003: pedigree.component_type is missing (required by contract v1.0.0 §6.2); K9-N001: component does not typecheck against K9.Component: error: unexpected token ┌─ /home/runner/work/trope-checker/trope-checker/.k9-
  • session/custom-checks.k9 — fail (advisory): K9-S002: pedigree.schema_version is missing; K9-S003: pedigree.component_type is missing (required by contract v1.0.0 §6.2); K9-N001: component does not typecheck against K9.Component: error: unexpected token ┌─ /home/runner/work/trope-checker/trope-checker/sess

Scope: K9 components L0–L2 against contract v1.0.0 at the named standards commit. L3 signature verification and routed coordination-dialect files are not certified. Green is limited to this scope. Orange is missing evidence; yellow is grandfathered debt or warnings; grey is an explicit scope exclusion. report.json, badge.json and the validator logs are in the k9-grid artifact on the linked run.

Hypatia verdict grid

Hypatia grid green

🟢 clean · commit bdd9a69af514 · run 44129270436 · scope: this change (4 file(s))

Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change.

Unique graded findings across gating and advisory rows: 23 (23 reporter observations; 20 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Raw Hypatia alert-derived observations: 43 (code-scanning, Dependabot and secret-scanning; some may also be in SARIF; not an extra total).

Reporter Gate Status Critical High Medium Minor Since previous revision
Hypatia scan gating 🟢 clean 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
panic-attack assail advisory 🟢 clean 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
pons asinorum advisory 🟢 clean 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
echidnabot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
rhodibot (RSR compliance) advisory 🟢 clean 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
panicbot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
sustainabot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
glambot (presentation quality) advisory 🔵 minor 0 0 0 8 — no comparable baseline (no prior PR grid or unreadable snapshot)
seambot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
finishingbot (release readiness) advisory 🔴 high 0 9 4 2 — no comparable baseline (no prior PR grid or unreadable snapshot)
cipherbot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
accessibilitybot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline (no prior PR grid or unreadable snapshot)
Hypatia scan: 13 finding(s)
  • 13 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
panic-attack assail: 3 finding(s)
  • 3 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
echidnabot: not_applicable — proofs here are gated by their own toolchains (proofs.yml: Idris2, Lean, Agda); no ECHIDNA engine is configured, so this adapter could only ever report not_run
  • ⚪ not applicable: proofs here are gated by their own toolchains (proofs.yml: Idris2, Lean, Agda); no ECHIDNA engine is configured, so this adapter could only ever report not_run
rhodibot (RSR compliance): 11 finding(s)
  • 11 further finding(s) in files this change does not touch: reported, not graded (0 critical, 11 high).
panicbot: not_applicable — panic-attack already reports directly as its own row in the Hypatia verdict grid; enrolling panicbot would count the same findings twice
  • ⚪ not applicable: panic-attack already reports directly as its own row in the Hypatia verdict grid; enrolling panicbot would count the same findings twice
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet README)
  • ⚪ not applicable: reserved fleet slot; no adapter exists (gitbot-fleet README)
glambot (presentation quality): 82 finding(s)
  • info GS-001 — Install git-seo for comprehensive SEO analysis: https://github.com/hyperpolymath/git-seo
  • info MACH-007 — ECOSYSTEM.scm not found in .machine_readable/ directory.
  • info MACH-007 — META.scm not found in .machine_readable/ directory.
  • info MACH-007 — STATE.scm not found in .machine_readable/ directory.
  • info MACH-005 — No robots.txt found. Consider adding one for crawler control.
  • info VIS-005 — verification/proofs/README.adoc:5 — Line 82 characters exceeds max length of 80.
  • info VIS-005 — CHANGELOG.adoc:17 — Line 82 characters exceeds max length of 80.
  • info VIS-005 — README.adoc:1 — Line 97 characters exceeds max length of 80.
  • 74 further finding(s) in files this change does not touch: reported, not graded (0 critical, 2 high).
seambot: not_applicable — no seam register is declared (spec/seams/seam-register.json)
  • ⚪ not applicable: no seam register is declared (spec/seams/seam-register.json)
finishingbot (release readiness): 127 finding(s)
  • high V1-DOC-ROADMAP.adoc — Required file ROADMAP.adoc not found (Project roadmap).
  • high TOOL-001 — .tool-versions file not found for asdf/mise version management.
  • high SCM-001-NEUROSYM.scm — Required SCM file NEUROSYM.scm not found (Neurosymbolic AI documentation).
  • high SCM-001-AGENTIC.scm — Required SCM file AGENTIC.scm not found (Agentic AI integration documentation).
  • high SCM-001-PLAYBOOK.scm — Required SCM file PLAYBOOK.scm not found (Operational playbooks and procedures).
  • high SCM-001-ECOSYSTEM.scm — Required SCM file ECOSYSTEM.scm not found (Project's place in the ecosystem).
  • high SCM-001-META.scm — Required SCM file META.scm not found (Meta-level information and architectural decisions).
  • high SCM-001-STATE.scm — Required SCM file STATE.scm not found (Project state and progress tracking).
  • high PH-100 — Found 102 placeholders, exceeds maximum allowed (0)
  • medium V1-COM-CONTRIBUTING.md — CONTRIBUTING.md file not found (Contribution guidelines).
  • medium V1-COM-CODE_OF_CONDUCT.md — CODE_OF_CONDUCT.md file not found (Code of conduct).
  • medium V1-SEC-001 — SECURITY.md not found for responsible disclosure.
  • medium TEST-AG-002 — No direct single-line Agda source check was identified in the known workflow or recipe locations. Dynamic runners need separate review; no proof was executed.
  • info CLM-003 — README.adoc — README missing 'Usage examples' section
  • info CLM-003 — README.adoc — README missing 'Installation instructions' section
  • 112 further finding(s) in files this change does not touch: reported, not graded (0 critical, 1 high).
cipherbot: not_applicable — no cryptography is implemented in this repository; the hashes present are checksum/integrity pins, which cipherbot would report as cryptographic findings
  • ⚪ not applicable: no cryptography is implemented in this repository; the hashes present are checksum/integrity pins, which cipherbot would report as cryptographic findings
accessibilitybot: not_applicable — no served HTML surface; this is a checker library/CLI with AsciiDoc documentation
  • ⚪ not applicable: no served HTML surface; this is a checker library/CLI with AsciiDoc documentation

Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run.

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 17, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants