Repository navigation
Run all four proof developments in the just recipes (ADR 0005 amendment upkeep) - #126
hyperpolymath wants to merge 1 commit into
Conversation
ADR 0005's 2026-11-17 amendment (#124) named this as upkeep (doctrine 16): `just proof-status` and the other recipes D5 touched still described three provers. build/just/proofs.just: - add proof-check-rocq, proof-check-lean-core and proof-check-recheck-controls, running scripts/check-recheck-legs.sh rocq|lean|controls, and recheck-legs, which runs all three as the proofs.yml job of that name does. A missing or wrong-version prover fails; it never skips. - proof-check-all and verify-all now include recheck-legs. - proof-status lists the developments by D4 role and prints the derived PWG census. It used to look for a summary row that PROOF-STATUS no longer has. It no longer counts vendored .lake/_build files. - fix proof-check-lean4, which had failed since #122. Its orphan guard counted the core-Lean leg as a file no lake package builds. It now exempts exactly the LEAN_FILE the recheck gate names. proof-check-rocq gets the same guard for .v files. - the doc lines that just --list shows name each recipe's role. README.adoc and verification/proofs/README.adoc gain the recheck legs, the D4 roles and the new recipes. The README "all three" sentence now names the three developments it meant. INTEGRATION-REPORT.adoc is a historical report and is unchanged. No proof, ledger entry or grade changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDgFtn2stHN9poWMAFr
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Fork governance
Scope: the three lanes below are static checks at the named commit. A K9-DEED conformance🟡 advisory · commit
K9 live corpus (L0–L2): 8 finding(s) / scope notes
Scope: K9 components L0–L2 against contract v1.0.0 at the named standards commit. L3 signature verification and routed coordination-dialect files are not certified. Green is limited to this scope. Orange is missing evidence; yellow is grandfathered debt or warnings; grey is an explicit scope exclusion. report.json, badge.json and the validator logs are in the k9-grid artifact on the linked run. Hypatia verdict grid🟢 clean · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 23 (23 reporter observations; 20 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: 13 finding(s)
panic-attack assail: 3 finding(s)
echidnabot: not_applicable — proofs here are gated by their own toolchains (proofs.yml: Idris2, Lean, Agda); no ECHIDNA engine is configured, so this adapter could only ever report not_run
rhodibot (RSR compliance): 11 finding(s)
panicbot: not_applicable — panic-attack already reports directly as its own row in the Hypatia verdict grid; enrolling panicbot would count the same findings twice
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet README)
glambot (presentation quality): 82 finding(s)
seambot: not_applicable — no seam register is declared (spec/seams/seam-register.json)
finishingbot (release readiness): 127 finding(s)
cipherbot: not_applicable — no cryptography is implemented in this repository; the hashes present are checksum/integrity pins, which cipherbot would report as cryptographic findings
accessibilitybot: not_applicable — no served HTML surface; this is a checker library/CLI with AsciiDoc documentation
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |



Summary
This is the upkeep (doctrine 16) that ADR 0005's 2026-11-17 amendment named and left undone. In #124 the amendment says that
just proof-statusand the other recipes D5 touched "still describe the developments they ran on 2026-10-27". This PR brings them in line with the amended D4 role table: Agda is the normative kernel, Rocq and core Lean are §2 recheck legs, Lean + Mathlib is a generator, and Idris2 is the reference.Stacked PR. #124 merged into
claude/pwg-names-ladder, which is still open againstmainas #119.scripts/check-recheck-legs.shexists only on that branch, so this PR targets it. Retarget it tomainonce #119 merges.One real defect fixed. Since #122 added the core-Lean leg,
just proof-check-lean4has failed on every run, whatever the toolchain. Its orphan guard countedlean4/ratified-order/RatifiedOrder.leanas a file that no lake package builds.proof-check-allfailed with it.No proof, ledger entry or grade changed.
Changes
build/just/proofs.justproof-check-rocq,proof-check-lean-coreandproof-check-recheck-controlsrunbash scripts/check-recheck-legs.sh rocq|lean|controls.recheck-legsruns all three, as theproofs.ymljob of that name does. A missing or wrong-version prover fails, because that is the script's own behaviour; nothing skips.proof-check-allandverify-allnow depend onrecheck-legs. Both now also needcoqc8.18.0 andlean4.16.0 onPATH.proof-statuslists the four developments by D4 role, with each one's gate, and prints the derived PWG census. It used to grep for a**Total**row thatPROOF-STATUS.adocno longer has. It no longer counts vendored.lake/or_build/files.proof-check-lean4orphan guard: it exempts exactly theLEAN_FILEthatcheck-recheck-legs.shnames, so a stray file beside the leg still fails. If that variable cannot be read, the recipe fails.proof-check-rocqgets the same guard for.vfiles.just --listshows now name each recipe's role. Before, several of them showed a stray mid-paragraph line.README.adoc: the repository map gains rows forrocq/andlean4/ratified-order/, plus the D4 roles. The run-the-checks block gainsjust recheck-legs, and itsverify-allcomment is updated. The sentence "Only L1 and L4 carry a statement in all three" now names the three developments it meant (Agda, Lean with Mathlib, Idris2); its blame date of 2026-11-10 predates the recheck legs. Its claim is unchanged.verification/proofs/README.adoc: adds the D4 role table, puts the recheck legs and roles in the tree, lists the new recipes, and describes the recheck-leg enforcement. It also fixes a pre-existing editorconfig indent error inside the tree block.CHANGELOG.adoc: adds an entry under Unreleased → Fixed.INTEGRATION-REPORT.adoc, which is marked as a historical report, and ADR 0005's own D5 text, which the amendment supersedes.EXPLAINME.adochas no prover-count prose.RSR Quality Checklist
Required
just testis a template stub that tests nothing, so the real checks are listed under Testing.just fmtis also a stub). editorconfig-checker v3.1.2 is clean on all four files.--severity=styleis clean on every tracked.shand on the changed recipe bodies extracted withjust --show. asciidoctor 2.0.20 with--failure-level=WARNis clean on the three.adocfiles.unsafeblocks without// SAFETY:commentsjust proof-scan-dangerousPASS).envfiles includedAs Applicable
CHANGELOGupdatedTesting
Toolchain: Coq 8.18.0 (Ubuntu 24.04 apt, as CI uses), Lean 4.16.0 and ShellCheck 0.11.0 (both checked against the SHA-256 values pinned in
proofs.ymlandquality.yml), and just 1.40.0.The
proof-check-lean4orphan guard was tested with a stublakethat exits 0, because building the Mathlib packages needs the Mathlib cache, which is not available here:FAIL: Lean files belonging to no lake package: …/ratified-order/RatifiedOrder.lean(the defect)..leanplanted beside the leg it fails, and withLEAN_FILEmissing from the script it fails.Not run locally:
build-lean,build-agda, and thereforeverify-allandproof-check-allend to end. Agda 2.7.0.1 and the Mathlib cache are not installed here, and those recipe bodies are unchanged.just --dry-runconfirms the new dependency order:verify-allruns build-lean, then build-agda, then recheck-legs, then the honesty gate and the PWG record.Side note, not changed here: just 1.21 (Ubuntu apt) runs recipes from
build/just/*.justimports inbuild/just/, so every imported recipe, the existingpwg-checkincluded, fails under it. just 1.40.0 runs them from the repository root..mise.tomlleavesjustcommented out.Generated by Claude Code