Repository navigation
fix(ci): clear shellcheck findings (Gate: Code quality) - #129
hyperpolymath wants to merge 1 commit into
Conversation
…sifiability.sh SC1112: replace the unicode apostrophe in a jq comment with wording that needs no apostrophe (the comment sits inside a single-quoted jq program). SC2030/SC2031: meta_canary no longer mutates PASS/FAIL inside a command substitution; it saves and restores the counters instead. Behaviour is unchanged: canaries 19/19, pwg-check passes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZnfGP6tuXgjeDPhEv4
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
|
Fork governance
Scope: the three lanes below are static checks at the named commit. A K9-DEED conformance🟡 advisory · commit
K9 live corpus (L0–L2): 8 finding(s) / scope notes
Scope: K9 components L0–L2 against contract v1.0.0 at the named standards commit. L3 signature verification and routed coordination-dialect files are not certified. Green is limited to this scope. Orange is missing evidence; yellow is grandfathered debt or warnings; grey is an explicit scope exclusion. report.json, badge.json and the validator logs are in the k9-grid artifact on the linked run. Hypatia verdict grid🟢 clean · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high in grid scope) — reported, never grading the change. Unique graded findings across gating and advisory rows: 19 (19 reporter observations; 19 without sufficient identity to corroborate). Row counts remain per reporter; unique totals do not change gating.
Hypatia scan: 13 finding(s)
panic-attack assail: 3 finding(s)
echidnabot: not_applicable — proofs here are gated by their own toolchains (proofs.yml: Idris2, Lean, Agda); no ECHIDNA engine is configured, so this adapter could only ever report not_run
rhodibot (RSR compliance): 11 finding(s)
panicbot: not_applicable — panic-attack already reports directly as its own row in the Hypatia verdict grid; enrolling panicbot would count the same findings twice
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet README)
glambot (presentation quality): 82 finding(s)
seambot: not_applicable — no seam register is declared (spec/seams/seam-register.json)
finishingbot (release readiness): 127 finding(s)
cipherbot: not_applicable — no cryptography is implemented in this repository; the hashes present are checksum/integrity pins, which cipherbot would report as cryptographic findings
accessibilitybot: not_applicable — no served HTML surface; this is a checker library/CLI with AsciiDoc documentation
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
|
Add Carrot credits or activate Agent usage billing to use Autofix |



Summary
Fixes the
Gate: Code qualityshellcheck failure on main.scripts/pwg-derive.shSC1112: removed a unicode apostrophe from a comment inside the single-quoted jq program (reworded, no apostrophe needed).scripts/test-gate-falsifiability.shSC2030/SC2031:meta_canarynow saves and restoresPASS/FAILinstead of mutating them inside$(...). Behaviour is identical.Verification
shellcheck --severity=styleon both scripts: no SC1112, SC2030 or SC2031 remain (local 0.9.0; CI pins 0.11.0).scripts/test-gate-falsifiability.sh: 19/19 canaries pass, including the meta-canary.scripts/pwg-check.sh: passes.Not in this PR
The Scorecard reconcile failure (fork-governance.yml and release.yml reusable refs absent from actions.lock) and the Hypatia RE002 finding (instant-sync.yml harden-runner
egress-policy: audit) need the lock tooling and an egress allowlist respectively. Reported separately.Generated by Claude Code