fix(ci): the invisible-character gate never matched anything #57
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| K9! | ||
|
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: #!/bin/sh
set -eu
tmp="$(mktemp)"
trap 'rm -f "$tmp"' EXIT
printf 'K9!\n{ value = 1 }\n' > "$tmp"
nickel --version
if nickel typecheck "$tmp"; then
echo "This Nickel toolchain accepts the K9 header."
else
echo "This Nickel toolchain rejects the K9 header."
fiRepository: hyperpolymath/typedqliser Length of output: 207 🏁 Script executed: #!/bin/sh
set -eu
printf '%s\n' '--- container/deploy.k9.ncl ---'
cat -n container/deploy.k9.ncl
printf '%s\n' '--- relevant repository files ---'
git ls-files | grep -E '(^|/)(README|.*k9.*|.*nickel.*|.*deploy.*|package\.json|Cargo\.toml|flake\.nix|Makefile|\.github/.*)' | head -200Repository: hyperpolymath/typedqliser Length of output: 10168 🏁 Script executed: #!/bin/sh
set -eu
printf '%s\n' '--- K9 validation hook ---'
cat -n .githooks/validate-k9.sh
printf '%s\n' '--- K9 configuration ---'
cat -n k9iser.toml
printf '%s\n' '--- K9 template headers and validation references ---'
for f in .machine_readable/svc/k9/template-hunt.k9.ncl \
.machine_readable/svc/k9/template-kennel.k9.ncl \
.machine_readable/svc/k9/template-yard.k9.ncl \
container/README.adoc \
.machine_readable/svc/k9/README.adoc; do
if [ -f "$f" ]; then
printf '\n--- %s ---\n' "$f"
grep -n -E '^(K9!|#|.*nickel|.*validate|.*header|.*magic)' "$f" | head -120
fi
doneRepository: hyperpolymath/typedqliser Length of output: 20601 🌐 Web query:
💡 Result: The K9! magic header is not part of the standard Nickel language specification, but rather a mandatory requirement for K9, a separate project that utilizes Nickel as a configuration and validation format [1][2]. K9 is a system for self-validating components that uses Nickel for its logic and contract enforcement [1][3]. In the K9 ecosystem, source files (which use the.k9 or.k9.ncl extensions) are required to begin with the magic bytes K9! on the first line [1][4][2]. This header identifies the file as a K9 component, allowing specialized tools to distinguish them from standard Nickel files [1][5]. In summary: - K9! is not a feature of Nickel itself, but of the K9 Self-Validating Components project [1][6]. - The header is used for file identification and security tier detection (Kennel, Yard, or Hunt) [1][7]. - Standard Nickel files do not require or use this magic header [8]. Citations:
Do not pass the raw
🧰 Tools🪛 GitHub Check: Validate K9 contracts[warning] 1-1: [warning] 1-1: [failure] 1-1: 🤖 Prompt for AI Agents |
||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # deploy.k9.ncl — {{PROJECT_NAME}} deployment component (Hunt level) | ||
| # | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM RISK
The (*UTF) prefix forces strict UTF-8 validation. If a file contains invalid UTF-8 sequences, grep will error out and skip that file. Because stderr is redirected to /dev/null on line 133, these failures are silent, meaning invisible characters in malformed files will go undetected. Consider removing the stderr redirection or adding a mechanism to alert when files fail validation.