Skip to content

An obliterate in the history blocks every earlier undo, and undo reports success #238

Open

Description

@hyperpolymath

Found on 2026-11-17 while fixing redo in #231. Reproduced in a temporary sandbox root.

What happens

mkdir d; obliterate secret --force; undo.

undo prints "Cannot undo secret (irreversible: obliterate)", returns success, and leaves d in place. Every later undo does the same, so nothing before the obliterate can be undone.

Cause

In commands::undo (impl/rust-cli/src/commands.rs), last_n_undoable keeps returning the irreversible operation because it is never marked undone.

Decision needed (owner)

Either:

  • It is an intended barrier. Then undo should say so once, clearly, and return an error instead of success.
  • Undo should skip past it. Then the irreversible operation stays in the history and undo reverses the operation before it.

Keep RMR (reversible) and RMO (irreversible, with audit residue) distinct whichever is chosen; see docs/ECHO-TYPES-OCHRANCE-BRIDGE.adoc.

Done means

  • A test for the chosen behaviour.
  • In impl/rust-cli: cargo fmt --check, cargo clippy --all-targets --all-features -- -D warnings and cargo test pass. Commits signed.

Activity

  1. added
    bugSomething is broken or behaves incorrectly
    decisionA ruling is required before work can proceed
    scope:repoConfined to this repository
    on Nov 17, 2026
  2. coderabbitai commented on Nov 17, 2026

    @coderabbitai
    Contributor
    🔗 Related PRs

    #232 - Runtime holes: 13 of 15 closed, by containment through a directory handle and a fixed session root [open]


    📝 Issue Planner

    Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.

    • Create Plan

    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is broken or behaves incorrectlydecisionA ruling is required before work can proceedpriority:p3Low - nice to havescope:repoConfined to this repository

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions