Repository navigation
fix(react): preserve signing client hook order across chains - #54
Open
ayenisholah wants to merge 1 commit into
Open
ayenisholah wants to merge 1 commit into
ayenisholah wants to merge 1 commit into
Conversation
ayenisholah
marked this pull request as ready for review
November 3, 2026 10:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching a mounted useSigningClient consumer between Cosmos and Ethereum/Solana changes the number of React hooks called because the non-Cosmos return precedes useAsync. This can crash the consumer or disturb subsequent hooks.
Always call useAsync, enable requests only for a ready, connected Cosmos wallet, and retain the existing null/false/null response for other chain types. No public API changes. This is separate from the stale-request handling in #52 and import-cycle fix in #53.
Validation (Node 24.19.0):
AI-assisted code and tests reviewed locally. Signed commit; draft pending upstream CI approval.