Skip to content

fix(react): show pairing QR for named WalletConnect wallets - #55

Open
ayenisholah wants to merge 1 commit into
hyperweb-io:mainfrom
ayenisholah:fix/keplr-mobile-qr
Open

ayenisholah wants to merge 1 commit into
hyperweb-io:mainfrom
ayenisholah:fix/keplr-mobile-qr

Conversation

@ayenisholah

Copy link
Copy Markdown

When Keplr Mobile is selected on desktop, the modal can remain on “Requesting Connection” even after a pairing URI is available. QR rendering currently requires the exact wallet name WalletConnect, excluding keplr-mobile and other named WalletConnect adapters.

Select the QR view by the existing wallet-connect mode and include mode in the memo dependencies. Preserve the URI requirement and wallet-list precedence. No public API, dependency or version changes.

Related to #35: this addresses the desktop QR symptom only. The iOS handoff report remains outside this change, so this PR does not close the issue.

Validation (Node 24.19.0, pnpm 9.15.4):

  • Before: three regressions fail (Keplr, Leap, mode transition); ten modal controls pass.
  • After: complete React suite passes, 6 suites / 38 tests; final formatted modal suite passes, 13 tests.
  • Core/store dependency builds and React CJS/ESM/CSS build pass.
  • Changed-file ESLint has zero errors and four existing unused-variable warnings; Prettier and git diff --check pass.
  • Tests exercise the rendered modal, including generic WalletConnect, missing URI, extension wallets and wallet-list precedence. No live wallet/network E2E or iOS testing was performed.

AI-assisted implementation and tests reviewed locally. Signed commit; draft pending upstream CI approval and feedback.

@ayenisholah
ayenisholah marked this pull request as ready for review November 5, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant