Repository navigation
Installer: WER LocalDumps + recording folder (#433) - #1033
Merged
Merged
Conversation
Install-CrashDumps.ps1 writes HKLM LocalDumps (full, 5, %LOCALAPPDATA%\CoreVideoPro\crashes) for the three product executables in the elevated step; refusal is logged and never fails setup. Keys are removed on uninstall unless another version still needs them or they are not ours. Recording folder now follows the app default (Videos known folder). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
iamfatness
force-pushed
the
codex/rc-433
branch
from
October 23, 2026 21:23
315660b to
19cdd90
Compare
The 32-bit NSIS installer launches the 32-bit PowerShell, whose HKLM: drive is the WOW6432Node view that WerFault never reads. Open the hive with OpenBaseKey(Registry64) like the camera helper, handle a null elevated exit code by reading the keys back, test from the SysWOW64 host, honest welcome text, retention-aware installer test, docs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…th; tidy parent key Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
# Conflicts: # docs/BACKLOG.md
This was referenced Oct 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #433
Install-VirtualCamera.ps1in the installer (unchanged).scripts/alpha/Install-CrashDumps.ps1(packaged, called frominstaller.nsi): writesHKLM\...\Windows Error Reporting\LocalDumps\<exe>for CoreVideoPro.WinUI.exe, corevideo-native.exe, corevideo-zoom-engine.exe with DumpFolder=%LOCALAPPDATA%\CoreVideoPro\crashes(REG_EXPAND_SZ), DumpType=2, DumpCount=5. Interactive setup requests elevation (RunAs); silent/Smust already be elevated, same as the camera step. A declined/refused write exits 2, is logged toinstaller-logs\<release>-crashdumps.log, and setup continues (never fatal).setup-crash-dumps.ps1) are preserved. Uninstall removes only marked keys and keeps them while another CoreVideo Pro version is still registered.$VIDEOS\CoreVideo Pro, else%LOCALAPPDATA%\CoreVideo Pro, matchingRecordingFolderPolicy); never clobbered, preserved on uninstall.Test-CrashDumps.ps1(unelevated, throwaway HKCU key; 27 checks; wired into CInative-shell-windows);Test-AlphaInstaller.ps1extended (recording folder, HKLM keys when elevated or logged refusal when not, uninstall cleanup/preservation). NSIS script compile-checked with stub payload.docs/reference/installer.md,docs/BACKLOG.md([T2.1] Installer (scripts/alpha/installer.nsi) registers the virtual camera, enables WER LocalDumps, creates the reco #433 shipped, pending installed acceptance).Not verified: real elevated install (UAC RunAs path, actual dump landing in the crashes folder);
Test-AlphaInstallerwas not run (needs a built installer).🤖 Generated with Claude Code