test(builder): make pytest runnable without starlette; pin contract - #101
Open
iap wants to merge 1 commit into
Open
test(builder): make pytest runnable without starlette; pin contract#101iap wants to merge 1 commit into
iap wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Summary
pytest.ini'signore::starlette.exceptions.StarletteDeprecationWarningmade the whole suite unrunnable in any environment without starlette: pytest imports the warning category at config-parse time, so it died withModuleNotFoundErrorbefore collecting a single test (verified with a plainpython3).conftest.pyalready applies the identical filter conditionally at import time, so the ini filter was strictly redundant — removed, with a constraint comment so it is not re-added the next time the Starlette warning shows up in a venv.verify.py's expected registered-tools set now includesq_debug, so the "all tools registered" gate catches its removal (the secret-scan loop already covered it).tests/test_import_contract.pypinsensure_validinSSO_OIDC_SYMBOLS, making AGENTS.md's claim that the full public auth API is pinned actually true.Evidence: full suite 228 passed, 1 skipped; a starlette-less
python3 -m pytestpreviously crashed at config parse and now collects all 229 tests.Branch
This PR was opened from a branch using one of:
fix/…bugs/…feature/…(branch prefix
test/…— same convention aschore/…,sec/…on this repo)Checklist
python -m pytest -q -k "not adapter"verify.pyis greenGreptile Summary
This change makes pytest configuration resilient when Starlette is not installed and strengthens the checked public contracts for
ensure_validandq_debug. The focused checks completed successfully; the available environment’s broader collection is separately limited by an unrelated FastAPI/Starlette dependency mismatch.Confidence Score: 5/5
Safe to merge: the updated collection behavior and strengthened import and registration contracts work as intended.
No defects were established in the changed code. The optional-Starlette scenario, the public import contract, and the headless tool-registration check all completed successfully.
Files Needing Attention: None.
What T-Rex did
Reviews (1): Last reviewed commit: "test(builder): make pytest runnable with..." | Re-trigger Greptile