14: Strip PHP from the search reference trees - #3394
Merged
Conversation
Removes the PHP example and its implement-it-in-code prose from 168 pages across the criteria, aggregation, sort clause, URL search, activity log, AI actions, content type and embeddings reference trees, leaving each page's feature description, fields, semantics and REST example intact. Pages with no REST counterpart keep no example; none was invented. Deletes search_api.md, a PHP API page, and folds its conceptual introduction into the search landing page. Rewrites its 13 inbound references: de-linked where the sentence still carries the concept, repointed where a surviving reference page covers it. Restores the FieldValueCriterion::COMPARISON_* constants to code spans after ticket 07 removed their links (residue R4). Removes 177 search/ entries from the invariant baseline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Preview of modified files: Too many files modified in a single PR, preview link list is skipped. (182 files > 150) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket 14 of the Cohesivo SaaS conversion. Base:
saas-batch-3.A reader working through the search reference trees sees only examples they can
actually use. Each page still describes its feature, its fields, its semantics
and its behaviour; what is gone is the PHP sample and the implement-it-in-code
prose that surrounded it.
183 files changed, 3,102 deletions, 40 insertions. The insertions are almost
entirely the folded search landing page — this is a strip, not a rewrite.
The mechanical strip: 168 pages
These pages already presented a PHP example beside a REST example, so the
recipe was: remove the
### PHPheading and its``` phpblock, leave### REST APIintact. It held for 154 pages with zero insertions.Worth recording, because it was the real risk: removing 154 headings orphans
any inbound
#phpanchor link, andmkdocs --strictfails on broken anchorswhile no page-level link inventory contains them. Verified explicitly —
zero inbound
#phpanchors exist indocs/, so nothing was orphaned.The remaining 14 pages resisted the recipe and were done by hand.
search_api.mddeleted, and what happened to its 13 referencesIt is a PHP API page — its whole subject is
SearchServiceand Repositoryfiltering — so it is deleted outright and its conceptual introduction folded
into
docs/search/search.md, which now describes Criteria, Sort Clauses,Aggregations and embeddings as concepts and points at the REST
/viewsresource.
Its inbound references were resolved individually rather than mechanically:
words — the aggregation, embeddings and trash reference pages each define
the thing they were linking out to explain.
#search-in-trashanchors now go to
search_in_trash_reference.md./views"PHP API counterpart" aside inrest_requests.md.mkdocs.ymlnav entry are gone.The landing page's
cards()block namedsearch/search_api, andcards()calls
open()directly — a stale card is a hard build crash, not a warning.Residue R4
FieldValueCriterion::COMPARISON_*bullets indatetimeattribute_criterion.mdwere left as bare unbackticked text when ticket 07 removed their links. Six
bullets restored to code spans; already-backticked prose elsewhere left alone.
Verification
mkdocs build --strict→ exit 0.pytest -q→ 90 passed.search/still match``` phpor aninclude_code/include_filemacro naming a.phpfile.search/entries removed from the invariant baseline, takingphp_code_samplefrom 314 to 137. Other sections' entries left for tickets15–17.
Note
Some inbound references fixed here live in
content_management/content_api/pages that ticket 15 deletes outright. They were fixed anyway so this branch
builds standalone; they resolve as modify/delete conflicts in favour of the
deletion when 15 merges.
🤖 Generated with Claude Code