IBX-12374: Add PHP Behat suite configuration - #89
Merged
Conversation
bnowak
approved these changes
Sep 4, 2026
micszo
approved these changes
Sep 4, 2026
tomaszszopinski
approved these changes
Sep 4, 2026
ViniTou
changed the title
KamilSznajdrowicz
approved these changes
Sep 6, 2026
KamilSznajdrowicz
left a comment
KamilSznajdrowicz
left a comment
There was a problem hiding this comment.
Same case as https://github.com/ibexa/connector-quable/pull/49 - this repo has no Behat annotations either, so Rector has nothing to convert, but the attribute set guard is missing from rector.php
ViniTou
force-pushed
the
IBX-12374-behat-attributes
branch
from
September 7, 2026 10:30
df46c52 to
f8bcd57
Compare
ViniTou
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Part of the Behat 4 upgrade. Behat 4 removes docblock annotations (
@Given/@When/@Then) and YAML configuration; the Behat 3.32 already installed accepts PHP attributes and PHP config, so this converts the bundle ahead of theibexa/behatswitch without changing behaviour. Every bundle with Behat suites gets the same treatment independently.This bundle has no Behat contexts of its own (0 annotations), so only the suite configuration is affected:
behat_suites.phpis the--convert-configoutput ofbehat_suites.yml; the YAML file stays untilibexa/behatimports the PHP one, because the root config references it by filename and the two packages' versions drift within an app.For QA:
No functional change to the scenarios; same suites run.
Documentation:
N/A