Repository navigation
Conversation
iliaal
force-pushed
the
fix/aph-r6oy
branch
from
September 24, 2026 13:03
e026dfa to
73edcc8
Compare
XBM width and height were read with sscanf("%d"), whose behaviour on
overflow is undefined; glibc wraps 4294967298 to 2, so getimagesize()
reported a width of 2 and the bundled GD decoded a 2-pixel image, while
negative values came back as huge unsigned sizes. Parse the value with
strtol() and accept only 1 to INT_MAX in both readers, and bound the
bundled GD row byte count times height by INT_MAX.
Owner
Author
|
Promoted upstream as php#25293. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject malformed and overflowing XBM dimensions before image allocation. The regression tests cover invalid dimensions through both image APIs.