Repository navigation
Conversation
slprintf() stores its terminating NUL within the size it is given, and the DPB is written from offset 1 of a 256-byte buffer with a size of 256, so a user name, password, charset, or role that filled the buffer wrote one byte past its end. A value longer than 255 bytes also had its one-byte length truncated. Reject such values with a PDOException before writing them.
iliaal
force-pushed
the
fix/aph-pdo-firebird-dpb-overflow-x63u-84-work
branch
from
November 7, 2026 16:57
594c244 to
e00aab5
Compare
Owner
Author
|
Promoted upstream as php#25292. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserve Firebird DPB capacity for its version and terminator bytes, and reject values that exceed the one-byte length encoding or remaining capacity.