Repository navigation
Conversation
A DSN may embed a password (password=... for most drivers, PWD=... for odbc), so mark the $dsn argument of PDO::__construct() and PDO::connect() sensitive, as $password already is. The Pdo\* driver subclasses inherit both methods and get the same redaction.
iliaal
force-pushed
the
fix/aph-pdo-dsn-sensitive-84
branch
from
November 7, 2026 16:57
eeb732a to
7c3ae11
Compare
Owner
Author
|
Promoted upstream as php#25290. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSNs can contain passwords, but PDO only marks the separate password argument sensitive. Both
PDO::__construct()andPDO::connect()now redact the DSN in their exception frames, including inherited calls.The omission surfaced during PDO review and reproduces with CLI exception traces, including SQLite driver failures.