Repository navigation
Conversation
An exception thrown by session_get_cb left the call's return value undefined, which the return type check then reported as a TypeError chained over the user's exception. Skip that check for an undefined return value, as the PSK callbacks already do, so the original exception reaches the caller.
Owner
Author
|
Submitted upstream as php#25218. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception thrown by
session_get_cbleft the call's return value undefined, and the return type check reported it as a TypeError chained over the user's exception. Skip the check for an undefined value, as the PSK callbacks already do, so the original exception reaches the caller.Found in a large-scope review of the 8.6 session resumption callbacks. The new test fails on an unpatched PHP-8.6 ASAN build with the chained TypeError in both the Error and Exception stream error modes, and passes with the patch.