Repository navigation
feat(domino): register training and wire Plan, trainer and checkpoint #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a6bdb6a
feat(domino): register training and wire Plan, trainer and checkpoint
hereisaway 962ddcb
docs(domino): document training entry point and validation status
hereisaway 5c3a5cf
fix(domino): align metric offsets and document exact recovery
hereisaway 0d96acb
fix(domino): align masked attention, metrics and example payload
hereisaway f928540
fix(domino): address review hardening for masks, metrics and resume
hereisaway bcbbd5b
fix(domino): require complete resume topology and align example docs
hereisaway a47a0c9
fix(domino): require decay gamma for exact resume
hereisaway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "architectures": ["DominoDraftModel"], | ||
| "model_type": "domino", | ||
| "projector_type": "domino", | ||
| "hidden_size": 4096, | ||
| "intermediate_size": 12288, | ||
| "num_hidden_layers": 5, | ||
| "num_attention_heads": 32, | ||
| "num_key_value_heads": 8, | ||
| "vocab_size": 151936, | ||
| "rms_norm_eps": 1e-6, | ||
| "max_position_embeddings": 40960, | ||
| "rope_theta": 1000000.0, | ||
| "num_target_layers": 5, | ||
| "target_hidden_size": 4096, | ||
| "target_num_hidden_layers": 36, | ||
| "target_layer_ids": [1, 9, 17, 25, 33], | ||
| "mask_token_id": 151669, | ||
| "block_size": 16, | ||
| "emb_dim": 256, | ||
| "gru_hidden_dim": 1024, | ||
| "shift_label": true, | ||
| "pure_draft_prefix_len": 1, | ||
| "tie_word_embeddings": false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let a masked Domino run satisfy the required attention capability.
This line makes
draft_attention_executionrequired for the shipped Domino recipe. Evidence only activates that capability for FA4, cuDNN FlexAttention, or a windowed or sparse policy. Dense Domino uses none of those paths. Even if training and cleanup succeed, Evidence reportsincomplete_evidence. (raw.githubusercontent.com)Record the executed CUDA masked FlexAttention path and use that observation to activate the capability. Keep the dry-run pending. Add a terminal Evidence test that accepts the observed path and rejects a missing observation.
As per path instructions, “Required capabilities must fail closed” and selected Plan and observed Evidence must “remain distinct.”
Source: Path instructions