Skip to content

feat: update capture fields and add tests - #438

Open
cowan-macady wants to merge 2 commits into
masterfrom
maintain2
Open

cowan-macady wants to merge 2 commits into
masterfrom
maintain2

Conversation

@cowan-macady

@cowan-macady cowan-macady commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

implement ENG-9616

Checklist

  • pipenv run pytest passes
  • tests are included for new or changed behavior
  • pre-commit run --all-files passes
  • documentation (README, docstrings, examples) is changed or added

Affected client(s)

Description of change

update capture fields and add tests

@cowan-macady
cowan-macady requested a review from a team as a code owner November 20, 2026 11:05
Copilot AI balanced review requested due to automatic review settings November 20, 2026 11:05
@socket-security

socket-security Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedpylint@​4.1.3 ⏵ 4.1.492 +110010010070
Updatedruff@​0.17.3 ⏵ 0.17.6100100100100100
Updatedpytest-asyncio@​1.4.1.post1 ⏵ 1.5.0100 +1100100100100

View full report

@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
indykite_sdk/capture/_ops.py 93.75% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@deepsource-io

deepsource-io Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in fe084a6...4621772 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Secrets Nov 20, 2026 1:16p.m. Review ↗
Python Nov 20, 2026 1:16p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change introduces breaking public API changes without a major-release marker or migration guidance, and cleanup failures can skip node deletion, leaving test fixtures orphaned.

3 open issues
What changed in this PR

This PR extends the Python SDK’s Capture clients to support location-based routing and proxy creation on composite identity knowledge graphs.

Changes:

  • Adds create_proxy, location constants, and BatchResults with per-location results and chunk merging.
  • Updates synchronous and asynchronous Capture APIs, removing use_global_db in favor of node locations.
  • Adds unit and live integration coverage, updates documentation and examples, and refreshes locked dependencies.
File Description
tests/​unit/​capture/​test_capture.py Tests location-aware responses and mixed-shape chunk merging.
tests/​integration/​test_ciq_reference_values.py Adds a live test for graph-referenced CIQ upsert values.
tests/​integration/​test_capture_roundtrip.py Updates assertions for BatchResults.
tests/​integration/​test_capture_composite.py Adds opt-in composite routing and proxy tests.
tests/​integration/​conftest.py Documents composite test configuration.
README.md Explains composite routing and per-location results.
Pipfile.lock Refreshes runtime and development dependency pins.
indykite_sdk/​errors.py Updates chunk-failure results documentation and typing.
indykite_sdk/​capture/​models.py Adds proxy support, location constants, and result merging.
indykite_sdk/​capture/​client.py Updates synchronous Capture methods and batch handling.
indykite_sdk/​capture/​aio.py Applies equivalent asynchronous API changes.
indykite_sdk/​capture/​_ops.py Tracks request locations and parses location-specific responses.
indykite_sdk/​capture/​__init__.py Exports new result and location symbols.
examples/​capture_nodes.py Updates the example for the new result wrapper.

Review effort: Balanced

Comment thread indykite_sdk/capture/client.py Resolved
implement [ENG-9616]
Copilot AI balanced review requested due to automatic review settings November 20, 2026 13:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the Capture location-routing changes.

No open issues 🎉

3 resolved since last review

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants