Repository navigation
feat: update capture fields and add tests - #438
cowan-macady wants to merge 2 commits into
Conversation
implement [ENG-9616]
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Secrets | Nov 20, 2026 1:16p.m. | Review ↗ | |
| Python | Nov 20, 2026 1:16p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
🟡 Changes recommended
The change introduces breaking public API changes without a major-release marker or migration guidance, and cleanup failures can skip node deletion, leaving test fixtures orphaned.
3 open issues
What changed in this PR
This PR extends the Python SDK’s Capture clients to support location-based routing and proxy creation on composite identity knowledge graphs.
Changes:
- Adds
create_proxy, location constants, andBatchResultswith per-location results and chunk merging. - Updates synchronous and asynchronous Capture APIs, removing
use_global_dbin favor of node locations. - Adds unit and live integration coverage, updates documentation and examples, and refreshes locked dependencies.
| File | Description |
|---|---|
tests/unit/capture/test_capture.py |
Tests location-aware responses and mixed-shape chunk merging. |
tests/integration/test_ciq_reference_values.py |
Adds a live test for graph-referenced CIQ upsert values. |
tests/integration/test_capture_roundtrip.py |
Updates assertions for BatchResults. |
tests/integration/test_capture_composite.py |
Adds opt-in composite routing and proxy tests. |
tests/integration/conftest.py |
Documents composite test configuration. |
README.md |
Explains composite routing and per-location results. |
Pipfile.lock |
Refreshes runtime and development dependency pins. |
indykite_sdk/errors.py |
Updates chunk-failure results documentation and typing. |
indykite_sdk/capture/models.py |
Adds proxy support, location constants, and result merging. |
indykite_sdk/capture/client.py |
Updates synchronous Capture methods and batch handling. |
indykite_sdk/capture/aio.py |
Applies equivalent asynchronous API changes. |
indykite_sdk/capture/_ops.py |
Tracks request locations and parses location-specific responses. |
indykite_sdk/capture/__init__.py |
Exports new result and location symbols. |
examples/capture_nodes.py |
Updates the example for the new result wrapper. |
Review effort: Balanced
implement [ENG-9616]


implement ENG-9616
Checklist
pipenv run pytestpassespre-commit run --all-filespassesAffected client(s)
Description of change
update capture fields and add tests