Repository navigation
ci(deps): respect version constraints when pinning grace-period-safe … - #920
Open
arjun-rajappa wants to merge 1 commit into
Open
arjun-rajappa wants to merge 1 commit into
arjun-rajappa wants to merge 1 commit into
Conversation
…packages Parse requirement specifiers and environment markers from the requirements file and only downgrade to versions that satisfy them. Canonicalize package names (PEP 503) so names like typing_extensions and typing-extensions match, and select the newest candidate by version rather than upload date. Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pin_safe_versions.pydowngraded recently released packages without looking at the version constraints in the requirements files. It could pin to a version that violates a bound such asfastapi>=0.92.0,<0.129.0. It also silently skipped packages whose names differ only in-,_or., and it could try a back-ported older release before the newest one.