docs: fix docs/ci.md claiming a MacOS unit-test runner that doesn't exist - #713
Open
UgaTheDev wants to merge 1 commit into
Open
docs: fix docs/ci.md claiming a MacOS unit-test runner that doesn't exist#713UgaTheDev wants to merge 1 commit into
UgaTheDev wants to merge 1 commit into
Conversation
docs/ci.md claimed unit tests run 'with Python 3.11 - 3.13 on Ubuntu and MacOS runners'. unit.yaml's matrix is platform: [ubuntu-latest] only; there is no macOS runner. Fixes the doc to match the workflow it links to. Adding an actual macOS leg is a separate, maintainer-level decision (extra CI cost) and out of scope here. Ref: instructlab#705 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Kush Zingade <kush.zingade@gmail.com>
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/ci.mdsays unit tests run "with Python 3.11 - 3.13 on Ubuntu and MacOSrunners."
.github/workflows/unit.yaml's matrix isplatform: [ubuntu-latest]only — there is no macOS runner and never hasbeen in this workflow. This drops the false claim so the doc matches the
workflow it links to.
I considered the other direction — adding a real
macos-latestleg to thematrix — but that's a maintainer call (extra CI minutes/cost, and macOS
runners can behave differently for the CUDA-adjacent bits of this repo's
build), not something to sneak in as a docs fix. This PR only makes the doc
tell the truth about what CI already does; happy to help wire up an actual
macOS job in a separate PR if that's wanted.
Originally flagged in #705 (comment from 2026-07-29): "
docs/ci.mdclaims unit tests run "with Python 3.11 - 3.13 on Ubuntu and MacOS runners".unit.yaml's matrix isplatform: [ubuntu-latest], so there is no MacOS runner."One-line diff,
docs/ci.mdonly.