Repository navigation
Strip leading dot from file.ext to match Obsidian - #27
Merged
Merged
Conversation
Obsidian Bases exposes file.ext as "md", but mdbasequery used path.extname and returned ".md", so `file.ext == "md"` matched nothing. Strip the dot in core for indexed notes, this.file and link-derived file records; adapters keep returning the dotted extname. Fixes intellectronica#26 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thank you for the contribution, @andriyor ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
Obsidian Bases exposes
file.extwithout the dot (md), but mdbasequery took it frompath.extnameand returned.md, sofile.ext == "md"matched nothing.Changes
vault-index.ts), the syntheticthis.filefor the base (query.ts) and link-derived file records (evaluator.ts). Runtime adapters'extnameis unchanged.file.ext == "md"matches every note and projects"md".this.file.ext == ".base"test and test fixtures to the dotless form.AGENTS.md.Behaviour change
Queries written against the old value (
file.ext == ".md") will stop matching. Worth a line in the release notes.Checks
bun run lint-typecheck✓bun run test:bun— 115 passbun run test:node— 10 passbun run test:deno— 10 pass"file.ext": "md".🤖 Generated with Claude Code