Repository navigation
fix: name when a release hold lapses, and relay its lapse once - #1234
Merged
Merged
Conversation
Every hold line now names the time the hold lapses unless the cut renews it. The waits that end a hold name that lapse too, after which nothing holds the merge. The prompt hook's status block shows each lapsed cut once, so a session told of a hold is told when it no longer holds. Refs: iss-2610241107191205 Assisted-by: Claude:claude-opus-5-5
… relaying it The CONCURRENCY rule, its AGENTS.md short form and the launch, peers, land, build, reserve and status pages say that a hold binds only until it lapses, needs no one's leave to set aside after that, and is re-read just before it is acted on or passed on. Refs: iss-2610241107191205 Assisted-by: Claude:claude-opus-5-5
Resolves: iss-2610241107191205 Assisted-by: Claude:claude-opus-5-5
ReadStatus now takes the lapsed release cuts from the same read of the view as the holds. The two can no longer disagree, and a second read can no longer fail as if the holds had not been read. A lapse older than the shown markers' week is not named again, so a spent branch waiting for the sweep is not re-announced every week. The status brief quotes the new hold line and lists the lapsed cuts. Refs: iss-2610241107191205 Assisted-by: Claude:claude-opus-5-5
The markers carry the real clock's mtime while the test's clock is fake and earlier, so the prune never dropped them and the test passed with the shownKeep filter on lapsed cuts removed. Refs: iss-2610241107191205 Assisted-by: Claude:claude-opus-5-5
…ek on The lapse test's last step aged the shown markers and expected the week filter alone to hold the line back, but the markers it aged were not pruned, so the line stayed hidden by its marker and the test passed with the filter removed. A session that first reads the block a week after the lapse has no marker of its own, so only the filter keeps the lapse from it. Refs: iss-2610241107191205 Assisted-by: Claude:claude-opus-5-5
# Conflicts: # commands/peers.md # commands/reserve.md
The lapse clause already lives in the rules loader's CONCURRENCY domain, which the AGENTS.md short form points at; repeating it there pushed the merged file past the 32768 bytes a host may read, so it is dropped. Refs: iss-2610241107191205 Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A session told that a release cut holds the merges was never told when that hold stopped holding. A hold lapses when the cut stops renewing it, but nothing said so, so a session kept waiting on a hold that held nothing.
What changes:
Tests:
Resolves: iss-2610241107191205
Assisted-by: Claude:claude-opus-5-5