refactor: exportable md animations for modal - #28464
Open
reslear wants to merge 2 commits into
Open
Conversation
Contributor
|
Hey there, could you please create an issue for this? We'd like to understand the use case for this feature before we expose this API. Thanks! |
Contributor
I think there is already an open issue which address this PR: #24964 (#25243). |
3 tasks
Author
|
@liamdebeasi @DwieDima I suggested a more interesting solution in the form of presets see 2 #28499 |
mapsandapps
removed their request for review
February 1, 2024 20:31
brandyscarney
requested review from
a team and
BenOsodrac
and removed request for
a team
July 24, 2024 14:32
thetaPC
requested review from
a team and
OS-paulvisciano
and removed request for
a team,
BenOsodrac and
OS-paulvisciano
May 23, 2025 18:31
OS-paulvisciano
approved these changes
May 28, 2025
thetaPC
requested review from
a team and
gnbm
and removed request for
a team and
gnbm
May 28, 2025 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #28499 resolves #24964
It is convenient from the point of view when ios style need md style animation (https://ionicframework.com/docs/api/modal#enteranimation) that would not copy the code in the application and always use the latest changes.
exportable
mdEnterModalAnimationandmdLeaveModalAnimation