fix(menu): respect ion-app dir attribute for menu animation side - #31246
Merged
Conversation
|
@Arul1998 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
Arul1998
force-pushed
the
fix/menu-rtl-30226
branch
from
June 26, 2026 01:28
90d63e1 to
ec6d84e
Compare
github-actions
Bot
added
package: angular
Use isRTL with nearest ancestor dir lookup, fix sideChanged call site, and add unit/e2e tests for issue ionic-team#30226.
Arul1998
force-pushed
the
fix/menu-rtl-30226
branch
from
June 26, 2026 01:56
ec6d84e to
aec8b2d
Compare
github-actions
Bot
removed
package: angular
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
approved these changes
Aug 18, 2026
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR! 🙂
This screenshot is not needed because we already have screenshots for the menu in RTL and this fix only affects the animation which is covered by the spec tests.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30226
What is the current behavior?
When
dir="rtl"is set on<ion-app>(but not ondocument), the hamburger menu appears on the right side visually, but the open animation still slides in from the left. This happens becauseisEndSide()only checkeddocument.dir, not the nearest ancestordirattribute.What is the new behavior?
isEndSide()takes an optional host element and delegates toisRTL()instead of readingdocument.diritself.isRTL()now walks up from the given element to the nearest ancestor that declares adir, so<ion-app dir="rtl">applies to everything inside it even when the document isltr. It previously read only the element's owndirbefore falling back todocument.dir.sideChanged()inion-menualso passes the menu element so the side is correct before the first animation.ion-app dir="rtl"case.Does this introduce a breaking change?
Other information
ionic startsidemenu app → set<ion-app dir="rtl">→ open menu → animation should come from the right