Skip to content

Label the social icons in the collapsed mobile menu - #655

Open
iacore wants to merge 1 commit into
ircv3:masterfrom
iacore:patch-1
Open

iacore wants to merge 1 commit into
ircv3:masterfrom
iacore:patch-1

Conversation

@iacore

@iacore iacore commented Nov 11, 2026

Copy link
Copy Markdown

On a narrow screen the navigation collapses to a vertical list, and the four links at the bottom appeared as bare glyphs: a GitHub mark, a Twitter bird, a Mastodon mark and a speech bubble. A reader who does not recognise all four logos has nothing to go on.

This prints a label beside each icon below 46rem, in the same size and weight as the other collapsed entries:

  • GitHub
  • Twitter/X
  • Fediverse/Mastodon
  • Contact

Wider screens are unchanged; the labels are display: none above the mobile breakpoint. The icon spans gained aria-hidden="true" so the new text is the accessible name rather than needing the title attribute.

487px 1200px
labels shown icons only, as before

No Ruby toolchain on this machine, so I compiled css/style.sass with dart-sass and rendered the menu markup at 487px and 1200px in headless Chromium rather than running bundle exec jekyll serve.

On a narrow screen the nav collapses to a vertical list, where GitHub,
Twitter, the Fediverse account and contact each appeared as a bare
glyph. The reader has to know four logos to find the link.

The menu now prints a label beside each icon below 46rem, matching the
text of the other collapsed entries, and keeps the icons alone on wider
screens. The icon spans are marked aria-hidden so the new text is the
accessible name.
@sadiepowell

Copy link
Copy Markdown
Contributor

Its probably fine to just say "Twitter" and "Mastodon" rather than including the alternate names that people don't really use.

@iacore

iacore commented Nov 12, 2026

Copy link
Copy Markdown
Author

I use "Fediverse"

@jwheare

jwheare commented Nov 12, 2026

Copy link
Copy Markdown
Member

Dunno why the netlify PR preview action didn't run on this. @DarthGandalf you able to trigger that manually?

@DarthGandalf

Copy link
Copy Markdown
Member

Done.

You’ve received a Deploy Preview request from a fork by an author who isn’t a project member

This project requires approval before Deploy Previews from forks build, because they run unreviewed code that can access your environment variables and consume your team’s resources. You can change your untrusted deploys policy.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants