[#512] Sync names for physical quotas with logical quotas (main) - #514
Merged
Conversation
trel
reviewed
Aug 24, 2026
trel
left a comment
trel
left a comment
Member
There was a problem hiding this comment.
looks good to me. the consistency is pleasing.
Member
|
do we need a README or API.md update mentioning this change and/or support the old name for a bit with a warning in the log... it's pre 1.0... so formally, the answer is no. and that's fine. |
Contributor
Author
|
The change will be highlighted in the release notes, similar to how we've handled such changes in past releases. |
Member
|
gotcha. |
Contributor
Author
|
#510 has been merged. Taking this out of draft and preparing for merge. |
korydraughn
marked this pull request as ready for review
August 24, 2026 16:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All non-OIDC tests pass.
Will merge after #510.
Putting in draft until then.